Uploaded image for project: 'Sentry'
  1. Sentry
  2. SENTRY-1556

Simplify privilege cleaning

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.0, 2.0.0
    • Fix Version/s: 1.8.0, 2.0.0
    • Component/s: Sentry
    • Labels:
      None

      Description

      The SentryStore class has a privCleaner that cleans up orphaned privileges. Currently cleaning is happening after 50 notification requests are sent and it uses locking to synchronize.

      I think the whole thing can be simplified:

      1) We should consider whether it is possible to clean up a privilege simply when we see that there are no roles associated with it. In this case we do not need this at all.

      2) We can simply run a periodic job to clean up orphaned privileges and groups (which are not cleaned up at all now).

        Attachments

        1. SENTRY-1556.002.patch
          30 kB
          Krishna Kalyan
        2. SENTRY-1556.003.patch
          49 kB
          Krishna Kalyan
        3. SENTRY-1556.004.patch
          41 kB
          Krishna Kalyan
        4. SENTRY-1556.005.patch
          40 kB
          Krishna Kalyan
        5. SENTRY-1556.006.patch
          41 kB
          Krishna Kalyan
        6. SENTRY-1556.007.patch
          42 kB
          Krishna Kalyan
        7. SENTRY-1556.008.patch
          42 kB
          Krishna Kalyan
        8. SENTRY-1556.001-sentry-ha-redesign.patch
          42 kB
          Krishna Kalyan
        9. SENTRY-1556.002-sentry-ha-redesign.patch
          42 kB
          Krishna Kalyan

          Issue Links

            Activity

              People

              • Assignee:
                kkalyan Krishna Kalyan
                Reporter:
                akolb Alex Kolbasov
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: