Uploaded image for project: 'S2Graph'
  1. S2Graph
  2. S2GRAPH-66

Optimize toEdge, IndexEdgeDeserializable using mutable Map.

    Details

    • Type: Improvement
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 0.1.0
    • Labels:

      Description

      since Storage#toEdge is called lots of times(# of edges query traverse), I think it is worth to optimize futher.

      based on profile, we can notice that List#toMap and List#++ on two list takes many cpu time on toEdge(actually IndexEdgeDeserializable#fromKeyValues).

      we can avoid List#toMap and List#++ by using MapBuilder and give up functional style here.

      I think code looks ugly(maybe not), but we can remove unnecessary cpu usage.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                steamshon DOYUNG YOON
                Reporter:
                steamshon DOYUNG YOON
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Due:
                  Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 504h
                  504h
                  Remaining:
                  Remaining Estimate - 504h
                  504h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified