[S2GRAPH-81] Separate Serializable's toKeyValues into 3, toRowKey, toQualifier, toValue

• Type: Sub-task
• Status: Done
• Priority: Minor
• Resolution: Done
• Fix Version/s: 0.1.0
• Assignee: Do Yung Yoon
• Reporter: Do Yung Yoon
• Due: 03/Jun/16
• Created: 28/May/16 00:14
• Updated: 11/Jun/16 15:01
• Resolved: 11/Jun/16 15:01

Description

StorageSerializable trait under core.storage package only have following interface.

trait StorageSerializable[E] {
  def toKeyValues: Seq[SKeyValue]
}

This layer is responsible to build SKeyValue from Edge/Vertex, which will be used in each storage implementation to actually store them.

I am suggesting to separate this into 3 piece.

1. toRowKey
2. toQualifier
3. toValue

The reason behind of this suggestion is for read path.

When user query comes in, we need to build rpc into storage which require us to identify the row key.

Most of time, we only need to identify row key, when getEdges from certain start vertex.
Sometimes, we additionally need qualifier, when check if edge exist between vertex pair on specific Label.

We are identifying row, qualifier by using IndexEdgeSerializer, which currently build bytes for row, qualifier, value altogether.

I think by separating toKeyValues, read path can avoid unnecessary serialization.

Issue Links

• links to: GitHub Pull Request #52