Details

    • Type: Sub-task
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 0.1.0

      Description

      User query traverse on IndexEdge, and current implemenation for deserialize bytes array into IndexEdge first(IndexEdgeDeserializable), then call IndexEdge#toEdge to create Edge class.

      I found out following parts copy data which is unnecessary.

      props.map { case (k, v) => k -> InnerValLikeWithTs(v, version) }
      

      This inefficiency exist because IndexEdge use Map[Byte, InnerValLike] and Edge use Map[Byte, InnerValLikeWithTs] as type of props value.

      It sounds like micro optimization but since this is called a lot, actually dependent on # fetched edges, I think improving this would create some changes on performance.

      To remove unnecessary copy, I am suggesting change type of IndexEdge's props same with Edge's props type Map[Byte, InnerValLikeWithTs].

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                steamshon DOYUNG YOON
                Reporter:
                steamshon DOYUNG YOON
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Due:
                  Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 168h
                  168h
                  Remaining:
                  Remaining Estimate - 168h
                  168h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified