Lucene - Core
  1. Lucene - Core
  2. LUCENE-4968

Several ToParentBlockJoinQuery/Collector issues

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.1, 5.0
    • Component/s: modules/join
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      I hit several issues with ToParentBlockJoinQuery/Collector:

      • If a given Query sometimes has no child matches then we could hit
        AIOOBE, but should just get 0 children for that parent
      • TPBJC.getTopGroups incorrectly throws IllegalArgumentException
        when the child query happens to have no matches
      • We have checks that user didn't accidentally pass a child query
        that matches parent docs ... they are only assertions today but I
        think they should be real checks since it's easy to screw up
      1. LUCENE-4968.patch
        17 kB
        Michael McCandless

        Activity

        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk closing after 4.3.1 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk closing after 4.3.1 release
        Hide
        Shalin Shekhar Mangar added a comment -

        Back ported to 4.3.1 r1483274

        Show
        Shalin Shekhar Mangar added a comment - Back ported to 4.3.1 r1483274
        Hide
        Steve Rowe added a comment -

        If there are no objections, I'd like to backport this to 4.3.1.

        Show
        Steve Rowe added a comment - If there are no objections, I'd like to backport this to 4.3.1.
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] mikemccand
        http://svn.apache.org/viewvc?view=revision&revision=1477570

        LUCENE-4968: fix several block join issues

        Show
        Commit Tag Bot added a comment - [trunk commit] mikemccand http://svn.apache.org/viewvc?view=revision&revision=1477570 LUCENE-4968 : fix several block join issues
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] mikemccand
        http://svn.apache.org/viewvc?view=revision&revision=1477569

        LUCENE-4968: fix several block join issues

        Show
        Commit Tag Bot added a comment - [branch_4x commit] mikemccand http://svn.apache.org/viewvc?view=revision&revision=1477569 LUCENE-4968 : fix several block join issues
        Hide
        Michael McCandless added a comment -

        Patch.

        Show
        Michael McCandless added a comment - Patch.

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development