[LUCENE-4968] Several ToParentBlockJoinQuery/Collector issues

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.3.1, 6.0
• Component/s: modules/join
• Lucene Fields: New
• Assignee: Michael McCandless
• Reporter: Michael McCandless
• Created: 29/Apr/13 22:43
• Updated: 28/Aug/22 13:45
• Resolved: 30/Apr/13 11:35

Description

I hit several issues with ToParentBlockJoinQuery/Collector:

• If a given Query sometimes has no child matches then we could hit
  AIOOBE, but should just get 0 children for that parent

• TPBJC.getTopGroups incorrectly throws IllegalArgumentException
  when the child query happens to have no matches

• We have checks that user didn't accidentally pass a child query
  that matches parent docs ... they are only assertions today but I
  think they should be real checks since it's easy to screw up

Issue Links

• is related to: SOLR-9528 Make _docid_ (lucene id) a pseudo field
• is related to: LUCENE-7452 improve exception message: child query must only match non-parent docs, but parent docID=180314...