Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7452

improve exception message: child query must only match non-parent docs, but parent docID=180314...

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.2
    • Fix Version/s: 7.0, 6.3
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      when parent filter intersects with child query the exception exposes internal details: docnum and scorer class. I propose an exception message to suggest to execute a query intersecting them both. There is an opinion to add this suggestion in addition to existing details.
      My main concern against is, when index is constantly updated even SOLR-9582 allows to search for docnum it would be like catching the wind, also think about cloud case. But, user advised with executing query intersection can catch problem documents even if they occurs sporadically.

      1. LUCENE-7452.patch
        5 kB
        Mikhail Khludnev

        Issue Links

          Activity

          Hide
          mkhludnev Mikhail Khludnev added a comment - - edited

          What about this?

          java.lang.IllegalStateException: Child query must not match same docs with parent filter. Combine them as must clauses (+) to find a problem doc. docId=23, class org.apache.lucene.search.DisjunctionSumScorer

          java.lang.IllegalStateException: Parent query must not match any docs beside parent filter. Combine them as must (+) and must-not (-) clauses to find a problem doc. docID=12

          Show
          mkhludnev Mikhail Khludnev added a comment - - edited What about this? java.lang.IllegalStateException: Child query must not match same docs with parent filter. Combine them as must clauses (+) to find a problem doc. docId=23, class org.apache.lucene.search.DisjunctionSumScorer java.lang.IllegalStateException: Parent query must not match any docs beside parent filter. Combine them as must (+) and must-not (-) clauses to find a problem doc. docID=12
          Hide
          mikemccand Michael McCandless added a comment -

          +1, thanks Mikhail Khludnev!

          Show
          mikemccand Michael McCandless added a comment - +1, thanks Mikhail Khludnev !
          Hide
          mkhludnev Mikhail Khludnev added a comment -

          Alexandre Rafalovitch, what do you think about these exception messages?

          Show
          mkhludnev Mikhail Khludnev added a comment - Alexandre Rafalovitch , what do you think about these exception messages?
          Hide
          mkhludnev Mikhail Khludnev added a comment -

          If you have a concern or want to hold it a little, please chime in!

          Show
          mkhludnev Mikhail Khludnev added a comment - If you have a concern or want to hold it a little, please chime in!
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4ab8e9c26291f8ffdc8c649f01ca3b464fc2ca5c in lucene-solr's branch refs/heads/master from Mikhail Khludnev
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4ab8e9c ]

          LUCENE-7452: block join queries' exception message to suggest how to
          find a doc which violate orthogonality restriction.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4ab8e9c26291f8ffdc8c649f01ca3b464fc2ca5c in lucene-solr's branch refs/heads/master from Mikhail Khludnev [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4ab8e9c ] LUCENE-7452 : block join queries' exception message to suggest how to find a doc which violate orthogonality restriction.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 45628f1a0b3d0f3b4b6fdb827aaf09252520d962 in lucene-solr's branch refs/heads/branch_6x from Mikhail Khludnev
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=45628f1 ]

          LUCENE-7452: block join queries' exception message to suggest how to
          find a doc which, violates orthogonality restriction.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 45628f1a0b3d0f3b4b6fdb827aaf09252520d962 in lucene-solr's branch refs/heads/branch_6x from Mikhail Khludnev [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=45628f1 ] LUCENE-7452 : block join queries' exception message to suggest how to find a doc which, violates orthogonality restriction.
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          I was trying to think of a better way to phrase it, but could not. And - after a bit of sentence parsing - users should be able to figure out how to isolate the issue. It may also be useful to have a blog post or something demonstrating it. I'll try to write one when I have some free time.

          Show
          arafalov Alexandre Rafalovitch added a comment - I was trying to think of a better way to phrase it, but could not. And - after a bit of sentence parsing - users should be able to figure out how to isolate the issue. It may also be useful to have a blog post or something demonstrating it. I'll try to write one when I have some free time.
          Hide
          mkhludnev Mikhail Khludnev added a comment -

          Thanks, Alexandre!

          Show
          mkhludnev Mikhail Khludnev added a comment - Thanks, Alexandre!
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Closing after 6.3.0 release.

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

            People

            • Assignee:
              mkhludnev Mikhail Khludnev
              Reporter:
              mkhludnev Mikhail Khludnev
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development