[LUCENE-3396] Make TokenStream Reuse Mandatory for Analyzers

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0-ALPHA
• Component/s: modules/analysis
• Lucene Fields: New
• Assignee: Chris Male
• Reporter: Chris Male
• Created: 23/Aug/11 07:51
• Updated: 28/Aug/22 12:56
• Resolved: 14/Nov/11 11:04

Description

In LUCENE-2309 it became clear that we'd benefit a lot from Analyzer having to return reusable TokenStreams. This is a big chunk of work, but its time to bite the bullet.

I plan to attack this in the following way:

• Collapse the logic of ReusableAnalyzerBase into Analyzer
• Add a ReuseStrategy abstraction to Analyzer which controls whether the TokenStreamComponents are reused globally (as they are today) or per-field.
• Convert all Analyzers over to using TokenStreamComponents. I've already seen that some of the TokenStreams created in tests need some work to be reusable (even if they aren't reused).
• Remove Analyzer.reusableTokenStream and convert everything over to using .tokenStream (which will now be returning reusable TokenStreams).

Issue Links

• breaks: LUCENE-3721 CharFilters not being invoked in Solr

Sub-Tasks

• Cleanup Test TokenStreams so they are reusable: Closed
• Deprecate / Remove DutchAnalyzer.setStemDictionary: Closed
• All Analysis Consumers should use reusableTokenStream: Closed
• Analysis Consumers should end and close any TokenStreams: Open
• Rename Analyzer.reusableTokenStream() to tokenStream(): Closed