[IGNITE-23042] Sql. Forbid implicit casts between different type families

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0
• Component/s: sql
• Labels: ignite-3
• Assignee: Konstantin Orlov
• Reporter: Pavel Pereslegin
• Created: 21/Aug/24 10:24
• Updated: 16/Oct/24 11:19
• Resolved: 02/Oct/24 13:39

Description

At the moment, the rules for implicit type conversion are not formalized. As a result, we allow implicit casting of types from different families everywhere (including for function operands, which can be confusing).

We need to formalize the rules for safe implicit conversion and follow them.

• Whether to allow implicit type casts (of which types) during DML from one table to another.
• Whether to allow implicit casts in operations.
• Whether to allow implicit casts for function operands.
• ...

Update

During the discussion it was decided to forbid any implicit casts between different type families.

Issue Links

• blocks: IGNITE-23060 Sql. Move rules from typeFamiliesAreCompatible into IgniteCustomAssignmentsRules
• causes: IGNITE-23347 Comparison of strings works wrong
• causes: IGNITE-23351 COALESCE detects type wrong if first argument is null
• fixes: IGNITE-15123 Calcite. Multi-tuple insert fails on validation
• fixes: IGNITE-22358 Sql. Results of TypeFactory::leastRestrictiveType are incompatible with legal type transformations
• fixes: IGNITE-22447 Sql. Numeric aggregate functions accept VARCHAR types
• fixes: IGNITE-18663 Sql. DATE Literals are not validated correctly.
• fixes: IGNITE-19503 Sql. UUID. Some expressions and statements with types from incompatible families are not rejected.
• fixes: IGNITE-18677 Sql. Arithmetic operation between numeric type and varchar columns and literals
• is related to: IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type.
• relates to: IGNITE-19469 Sql. Functions. Type coercion of function arguments (SUBSTR function).
• relates to: IGNITE-22935 Sql. SELECT SUBSTR(1000, 1.0). Error: Was not expecting value 'INTEGER' for enumeration
• relates to: IGNITE-22779 Sql. Exception on insert with dyn params when type doesn't match
• relates to: IGNITE-22295 Sql. Allow comparable types for common columns in NATURAL / USING join conditions
• links to: GitHub Pull Request #4409