[IGNITE-22447] Sql. Numeric aggregate functions accept VARCHAR types

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: sql
• Labels: ignite-3
• Assignee: Unassigned
• Reporter: Maksim Zhuravkov
• Created: 07/Jun/24 14:20
• Updated: 02/Oct/24 13:43
• Resolved: 02/Oct/24 13:41

Description

Numeric aggregate functions accept character string values due to implicit casts added by type coercion:

SELECT AVG('100')
> Gets transformed into
SELECT AVG("100"::DECIMAL(MAX_PREC, MAX_SCALE)) 

Explanation
This particular cast is added since AVG function uses FamilyOperandTypeChecker that always coerces its arguments if possible (it calls TypeCoercion::builtinFunctionCoercion, which in turn calls TypeCoercion::implicitCast(t1, t2) .

Expected behaviour
Aggregate functions that accept only numeric types should be rejected by the validator, when called with arguments of other types.

Issue Links

• is fixed by: IGNITE-23042 Sql. Forbid implicit casts between different type families