[HDFS-9404] Findbugs issue reported in BlockRecoveryWorker$RecoveryTaskContiguous.recover()

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Component/s: datanode
• Assignee: Unassigned
• Reporter: Yongjun Zhang
• Created: 09/Nov/15 22:07
• Updated: 24/Nov/15 23:16
• Resolved: 09/Nov/15 22:09

Description

HDFS-9249 precommit jenkins run reported the following issue. The issue was not introduced by HDFS-9249 patch. Filing this jira to report it.

https://builds.apache.org/job/PreCommit-HDFS-Build/13431/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html

Code Warning
EC Call to org.apache.hadoop.hdfs.server.protocol.DatanodeRegistration.equals(org.apache.hadoop.hdfs.protocol.DatanodeInfo) in org.apache.hadoop.hdfs.server.datanode.BlockRecoveryWorker$RecoveryTaskContiguous.recover()

Details

EC_UNRELATED_TYPES: Call to equals() comparing different types

This method calls equals(Object) on two references of different class types and analysis suggests they will be to objects of different classes at runtime. Further, examination of the equals methods that would be invoked suggest that either this call will always return false, or else the equals method is not be symmetric (which is a property required by the contract for equals in class Object).

Issue Links

• duplicates: HDFS-9401 Fix findbugs warnings in BlockRecoveryWorker