Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9249

NPE is thrown if an IOException is thrown in NameNode constructor

    Details

    • Hadoop Flags:
      Reviewed

      Description

      This issue was found when running test case TestBackupNode.testCheckpointNode, but upon closer look, the problem is not due to the test case.

      Looks like an IOException was thrown in
      try {
      initializeGenericKeys(conf, nsId, namenodeId);
      initialize(conf);
      try

      { haContext.writeLock(); state.prepareToEnterState(haContext); state.enterState(haContext); }

      finally

      { haContext.writeUnlock(); }

      causing the namenode to stop, but the namesystem was not yet properly instantiated, causing NPE.

      I tried to reproduce locally, but to no avail.

      Because I could not reproduce the bug, and the log does not indicate what caused the IOException, I suggest make this a supportability JIRA to log the exception for future improvement.

      Stacktrace
      java.lang.NullPointerException: null
      at org.apache.hadoop.hdfs.server.namenode.NameNode.getFSImage(NameNode.java:906)
      at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:210)
      at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:827)
      at org.apache.hadoop.hdfs.server.namenode.BackupNode.<init>(BackupNode.java:89)
      at org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1474)
      at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.startBackupNode(TestBackupNode.java:102)
      at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:298)
      at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpointNode(TestBackupNode.java:130)
      The last few lines of log:
      2015-10-14 19:45:07,807 INFO namenode.NameNode (NameNode.java:createNameNode(1422)) - createNameNode [-checkpoint]
      2015-10-14 19:45:07,807 INFO impl.MetricsSystemImpl (MetricsSystemImpl.java:init(158)) - CheckpointNode metrics system started (again)
      2015-10-14 19:45:07,808 INFO namenode.NameNode (NameNode.java:setClientNamenodeAddress(402)) - fs.defaultFS is hdfs://localhost:37835
      2015-10-14 19:45:07,808 INFO namenode.NameNode (NameNode.java:setClientNamenodeAddress(422)) - Clients are to use localhost:37835 to access this namenode/service.
      2015-10-14 19:45:07,810 INFO hdfs.MiniDFSCluster (MiniDFSCluster.java:shutdown(1708)) - Shutting down the Mini HDFS Cluster
      2015-10-14 19:45:07,810 INFO namenode.FSNamesystem (FSNamesystem.java:stopActiveServices(1298)) - Stopping services started for active state
      2015-10-14 19:45:07,811 INFO namenode.FSEditLog (FSEditLog.java:endCurrentLogSegment(1228)) - Ending log segment 1
      2015-10-14 19:45:07,811 INFO namenode.FSNamesystem (FSNamesystem.java:run(5306)) - NameNodeEditLogRoller was interrupted, exiting
      2015-10-14 19:45:07,811 INFO namenode.FSEditLog (FSEditLog.java:printStatistics(703)) - Number of transactions: 3 Total time for transactions(ms): 0 Number of transactions batched in Syncs: 0 Number of syncs: 4 SyncTimes(ms): 2 1
      2015-10-14 19:45:07,811 INFO namenode.FSNamesystem (FSNamesystem.java:run(5373)) - LazyPersistFileScrubber was interrupted, exiting
      2015-10-14 19:45:07,822 INFO namenode.FileJournalManager (FileJournalManager.java:finalizeLogSegment(142)) - Finalizing edits file /data/jenkins/workspace/CDH5.5.0-Hadoop-HDFS-2.6.0/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/name1/current/edits_inprogress_0000000000000000001 > /data/jenkins/workspace/CDH5.5.0-HadoopHDFS-2.6.0/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/name1/current/edits_0000000000000000001-0000000000000000003
      2015-10-14 19:45:07,835 INFO namenode.FileJournalManager (FileJournalManager.java:finalizeLogSegment(142)) - Finalizing edits file /data/jenkins/workspace/CDH5.5.0-Hadoop-HDFS-2.6.0/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/name2/current/edits_inprogress_0000000000000000001 > /data/jenkins/workspace/CDH5.5.0-HadoopHDFS-2.6.0/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/name2/current/edits_0000000000000000001-0000000000000000003
      2015-10-14 19:45:07,836 INFO blockmanagement.CacheReplicationMonitor (CacheReplicationMonitor.java:run(169)) - Shutting down CacheReplicationMonitor
      2015-10-14 19:45:07,836 INFO ipc.Server (Server.java:stop(2485)) - Stopping server on 37835
      2015-10-14 19:45:07,837 INFO ipc.Server (Server.java:run(718)) - Stopping IPC Server listener on 37835
      2015-10-14 19:45:07,837 INFO ipc.Server (Server.java:run(844)) - Stopping IPC Server Responder
      2015-10-14 19:45:07,837 INFO blockmanagement.BlockManager (BlockManager.java:run(3781)) - Stopping ReplicationMonitor.
      2015-10-14 19:45:07,838 WARN blockmanagement.DecommissionManager (DecommissionManager.java:run(78)) - Monitor interrupted: java.lang.InterruptedException: sleep interrupted
      2015-10-14 19:45:07,844 INFO namenode.FSNamesystem (FSNamesystem.java:stopActiveServices(1298)) - Stopping services started for active state
      2015-10-14 19:45:07,845 INFO namenode.FSNamesystem (FSNamesystem.java:stopStandbyServices(1386)) - Stopping services started for standby state
      2015-10-14 19:45:07,848 INFO mortbay.log (Slf4jLog.java:info(67)) - Stopped HttpServer2$SelectChannelConnectorWithSafeStartup@localhost:0

      1. HDFS-9249.001.patch
        2 kB
        Wei-Chiu Chuang
      2. HDFS-9249.002.patch
        5 kB
        Wei-Chiu Chuang
      3. HDFS-9249.003.patch
        6 kB
        Wei-Chiu Chuang
      4. HDFS-9249.004.patch
        5 kB
        Wei-Chiu Chuang
      5. HDFS-9249.005.patch
        6 kB
        Wei-Chiu Chuang
      6. HDFS-9249.006.patch
        6 kB
        Wei-Chiu Chuang

        Activity

        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        The IOException can only be thrown by NameNode.initialize(Configuration conf)
        and because namesystem is a null pointer, the exception must have been thrown before loadNamesystem(conf) is called.

        Therefore, it can only come from

        loginAsNameNodeUser(conf)
        

        Inside that method, IOException is thrown by

        SecurityUtil.login(conf, DFS_NAMENODE_KEYTAB_FILE_KEY,
                DFS_NAMENODE_KERBEROS_PRINCIPAL_KEY, socAddr.getHostName());
        

        Three possibilities in this method:

        if (keytabFilename == null || keytabFilename.length() == 0) {
              throw new IOException("Running in secure mode, but config doesn't have a keytab");
            }
        

        or

        String principalName = SecurityUtil.getServerPrincipal(principalConfig,
                hostname);
        

        or

        UserGroupInformation.loginUserFromKeytab(principalName, keytabFilename);
        

        All are related to Kerberos, but without a logging message it's hard to tell which caused the exception.

        Show
        jojochuang Wei-Chiu Chuang added a comment - The IOException can only be thrown by NameNode.initialize(Configuration conf) and because namesystem is a null pointer, the exception must have been thrown before loadNamesystem(conf) is called. Therefore, it can only come from loginAsNameNodeUser(conf) Inside that method, IOException is thrown by SecurityUtil.login(conf, DFS_NAMENODE_KEYTAB_FILE_KEY, DFS_NAMENODE_KERBEROS_PRINCIPAL_KEY, socAddr.getHostName()); Three possibilities in this method: if (keytabFilename == null || keytabFilename.length() == 0) { throw new IOException( "Running in secure mode, but config doesn't have a keytab" ); } or String principalName = SecurityUtil.getServerPrincipal(principalConfig, hostname); or UserGroupInformation.loginUserFromKeytab(principalName, keytabFilename); All are related to Kerberos, but without a logging message it's hard to tell which caused the exception.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        If its being raised by ugi/keytab load faiiure, then you should be able to recreate it by attempting to create a NN configured to load a keytab that isn't there (or: set hadoop.auth = true, but keytab="").

        Show
        stevel@apache.org Steve Loughran added a comment - If its being raised by ugi/keytab load faiiure, then you should be able to recreate it by attempting to create a NN configured to load a keytab that isn't there (or: set hadoop.auth = true, but keytab="").
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Steve Loughran Thanks for the suggestion.
        The exception was thrown when auth is default (i.e. SIMPLE). I did what you suggested, and instead of NPE at BackupNode, an IOException is thrown by NameNode, but unlike BackupNode.stop(), NameNode.stop() checks if namesystem is null. Additionally, I looked further and found there are other IOException possibilities at other places.

        So I think in addition to logging the exception, BackupNode should also check for the null pointer.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Steve Loughran Thanks for the suggestion. The exception was thrown when auth is default (i.e. SIMPLE). I did what you suggested, and instead of NPE at BackupNode, an IOException is thrown by NameNode, but unlike BackupNode.stop(), NameNode.stop() checks if namesystem is null. Additionally, I looked further and found there are other IOException possibilities at other places. So I think in addition to logging the exception, BackupNode should also check for the null pointer.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Hadoop JIRA does not allow me to edit comments. But what I am saying is that instead of wildly guessing Kerberos is to blame, add more log info to expose the problem when it happens. After all, this is a bug that looks rarely happens.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Hadoop JIRA does not allow me to edit comments. But what I am saying is that instead of wildly guessing Kerberos is to blame, add more log info to expose the problem when it happens. After all, this is a bug that looks rarely happens.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Check for null pointer, and add more verbose log info when IOException is thrown.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Check for null pointer, and add more verbose log info when IOException is thrown.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 22m 50s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 49s There were no new javac warning messages.
        +1 javadoc 11m 42s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 32s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 41s mvn install still works.
        +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
        +1 findbugs 3m 1s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 4m 10s Pre-build of native portion
        -1 hdfs tests 62m 8s Tests failed in hadoop-hdfs.
            116m 59s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.ha.TestEditLogTailer



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12766847/HDFS-9249.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 8d2d3eb
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13009/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13009/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13009/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13009/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 22m 50s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 49s There were no new javac warning messages. +1 javadoc 11m 42s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 32s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 41s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 3m 1s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 4m 10s Pre-build of native portion -1 hdfs tests 62m 8s Tests failed in hadoop-hdfs.     116m 59s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestEditLogTailer Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766847/HDFS-9249.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8d2d3eb Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13009/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13009/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13009/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13009/console This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        This is more of a supportability improvement patch. The Findbugs warning is unrelated. It's supportability improvement therefore I deem there is no need for a test case. I can not reproduce the failed test, and it looks unrelated.

        Show
        jojochuang Wei-Chiu Chuang added a comment - This is more of a supportability improvement patch. The Findbugs warning is unrelated. It's supportability improvement therefore I deem there is no need for a test case. I can not reproduce the failed test, and it looks unrelated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Wei, in preparing for the next CDH release, you don't something wonderful
        1. Found a new way for the NN to fail, and got a stack trace off it.
        2. Delved into that stack trace to come up with some reasonable hypothesis as to the cause

        Those are achievements to exploit

        It's supportability improvement therefore I deem there is no need for a test case.

        If it was just the logging I'd agree, though looking at the destination code I'd ask for what I'm asking for first: use the java7 combined exception handler to also catch and log the HadoopIllegalArgumentException.

        But It's a fix for an NPE on shutdown, which is something we can verify.

        Given the code path you highlit does appear to trigger an IOE if you enable hadoop auth without defining a NN principal, the IOE should be repeatedly triggered. This means we can have a test which sets up an NN appropriately and then triggers the failure.

        This can then verify that the changes to the stop() call are the ones needed for a robust shutdown.

        That's why I want a test: to verify that all the problems have been identified and fixed.

        You've done the hard work: identify a possible cause, come up with a probable fix. All it needs is a little test to round it off -one which will even validate your hypothesis about probable cause.

        Show
        stevel@apache.org Steve Loughran added a comment - Wei, in preparing for the next CDH release, you don't something wonderful 1. Found a new way for the NN to fail, and got a stack trace off it. 2. Delved into that stack trace to come up with some reasonable hypothesis as to the cause Those are achievements to exploit It's supportability improvement therefore I deem there is no need for a test case. If it was just the logging I'd agree, though looking at the destination code I'd ask for what I'm asking for first: use the java7 combined exception handler to also catch and log the HadoopIllegalArgumentException . But It's a fix for an NPE on shutdown, which is something we can verify. Given the code path you highlit does appear to trigger an IOE if you enable hadoop auth without defining a NN principal, the IOE should be repeatedly triggered. This means we can have a test which sets up an NN appropriately and then triggers the failure. This can then verify that the changes to the stop() call are the ones needed for a robust shutdown. That's why I want a test: to verify that all the problems have been identified and fixed. You've done the hard work: identify a possible cause, come up with a probable fix. All it needs is a little test to round it off -one which will even validate your hypothesis about probable cause.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Hi Steve Loughran,
        thanks for the long and detailed guideline I am relatively new to the Hadoop world so I did not get it right the first time.

        I am now able to trigger the NPE by setting
        c.set("hadoop.security.authentication", "kerberos");
        c.set("dfs.namenode.keytab.file", "");
        for the backup node, while the primary name node is still configured in simple auth mode.

        If I apply the patch, it will then throw IOException "Running in secure mode, but config doesn't have a key tab" instead of NPE.

        Now, this does not imply this is what caused the NPE in the original jenkins job, but it does show the patch can shutdown relatively gracefully.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Hi Steve Loughran , thanks for the long and detailed guideline I am relatively new to the Hadoop world so I did not get it right the first time. I am now able to trigger the NPE by setting c.set("hadoop.security.authentication", "kerberos"); c.set("dfs.namenode.keytab.file", ""); for the backup node, while the primary name node is still configured in simple auth mode. If I apply the patch, it will then throw IOException "Running in secure mode, but config doesn't have a key tab" instead of NPE. Now, this does not imply this is what caused the NPE in the original jenkins job, but it does show the patch can shutdown relatively gracefully.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        don't worry about being new: welcome to the fun of debugging hadoop from stack traces.

        I agree, you may not have found the cause, but you have certainly found what would have triggered it, verified that there's logging and there's a shutdown.

        would you be able to derive a test from that? We shouldn't need to have a miniHDFS cluster spun up, just try to start an NN with those configuration options

        Show
        stevel@apache.org Steve Loughran added a comment - don't worry about being new: welcome to the fun of debugging hadoop from stack traces. I agree, you may not have found the cause, but you have certainly found what would have triggered it, verified that there's logging and there's a shutdown. would you be able to derive a test from that? We shouldn't need to have a miniHDFS cluster spun up, just try to start an NN with those configuration options
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Attaching rev2. This patch adds a test case that verifies the fix for the NPE when the authentication of backup node is incorrectly configured.

        Thanks Steve Loughran for thoughtful comments.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Attaching rev2. This patch adds a test case that verifies the fix for the NPE when the authentication of backup node is incorrectly configured. Thanks Steve Loughran for thoughtful comments.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 20m 16s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 52s There were no new javac warning messages.
        +1 javadoc 11m 33s There were no new javadoc warning messages.
        +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 37s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 46s mvn install still works.
        +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse.
        +1 findbugs 2m 46s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 35s Pre-build of native portion
        -1 hdfs tests 53m 4s Tests failed in hadoop-hdfs.
            104m 37s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.blockmanagement.TestNodeCount
          hadoop.hdfs.server.namenode.TestBackupNode



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767098/HDFS-9249.002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 52ac73f
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13034/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13034/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13034/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13034/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 20m 16s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 52s There were no new javac warning messages. +1 javadoc 11m 33s There were no new javadoc warning messages. +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 37s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 46s mvn install still works. +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse. +1 findbugs 2m 46s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 35s Pre-build of native portion -1 hdfs tests 53m 4s Tests failed in hadoop-hdfs.     104m 37s   Reason Tests Failed unit tests hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.server.namenode.TestBackupNode Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767098/HDFS-9249.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 52ac73f Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13034/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13034/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13034/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13034/console This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Reset authentication method at end of the test to clean up.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Reset authentication method at end of the test to clean up.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 20m 27s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 9m 20s There were no new javac warning messages.
        +1 javadoc 11m 29s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 35s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
        +1 findbugs 2m 38s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 27s Pre-build of native portion
        -1 hdfs tests 66m 12s Tests failed in hadoop-hdfs.
            117m 51s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767356/HDFS-9249.003.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7f0e1eb
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13048/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13048/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13048/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13048/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 20m 27s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 9m 20s There were no new javac warning messages. +1 javadoc 11m 29s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 35s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 2m 38s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 27s Pre-build of native portion -1 hdfs tests 66m 12s Tests failed in hadoop-hdfs.     117m 51s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767356/HDFS-9249.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7f0e1eb Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13048/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13048/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13048/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13048/console This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        The test failure is unrelated to this patch. The warning is also not related.

        Show
        jojochuang Wei-Chiu Chuang added a comment - The test failure is unrelated to this patch. The warning is also not related.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        I had an offline discussion with Yongjun Zhang and had learned a lot when it comes to supportability.

        Rev4 address his comments:
        Basically, do not ignore the null pointer, instead, catch NPE at its caller. This makes it easier to understand the IOException and NPE are related. Also, added comments in the test case to make it easier to understand.

        Show
        jojochuang Wei-Chiu Chuang added a comment - I had an offline discussion with Yongjun Zhang and had learned a lot when it comes to supportability. Rev4 address his comments: Basically, do not ignore the null pointer, instead, catch NPE at its caller. This makes it easier to understand the IOException and NPE are related. Also, added comments in the test case to make it easier to understand.
        Hide
        yzhangal Yongjun Zhang added a comment -

        Hi Wei-Chiu Chuang,

        Thanks for reporting and working on the issue. I did a review of the patch, and have some comments:
        1.

        217	    // HDFS-9249: BackupNode.stop() could be called before namesystem is
        218	    // properly instantiated if an IOException is thrown
        219	    if (namesystem != null) {
        220	      // Abort current log segment - otherwise the NN shutdown code
        221	      // will close it gracefully, which is incorrect.
        222	      getFSImage().getEditLog().abortCurrentLogSegment();
        223	    }
        

        When this code is reached, supposedly the BackupNode object is already constructed, thus namesystem should not be null. Are you saying that this method is called even before BackupNode constructor is finished? that sounds weird to me.

        2. When I ran the test you created, I just saw exception is thrown in the try block below and caught by itself then got rethrown. The remaining code in the test is not executed.

            NameNode nn;
            try {
              Configuration nnconf = new HdfsConfiguration(c);
              DFSTestUtil.formatNameNode(nnconf);
              nn = NameNode.createNameNode(new String[] {}, nnconf);
            } catch (IOException e) {
              LOG.info("IOException is thrown creating name node");
              throw e;
            }
        

        Wonder if I did something wrong?

        Thanks.

        Show
        yzhangal Yongjun Zhang added a comment - Hi Wei-Chiu Chuang , Thanks for reporting and working on the issue. I did a review of the patch, and have some comments: 1. 217 // HDFS-9249: BackupNode.stop() could be called before namesystem is 218 // properly instantiated if an IOException is thrown 219 if (namesystem != null ) { 220 // Abort current log segment - otherwise the NN shutdown code 221 // will close it gracefully, which is incorrect. 222 getFSImage().getEditLog().abortCurrentLogSegment(); 223 } When this code is reached, supposedly the BackupNode object is already constructed, thus namesystem should not be null. Are you saying that this method is called even before BackupNode constructor is finished? that sounds weird to me. 2. When I ran the test you created, I just saw exception is thrown in the try block below and caught by itself then got rethrown. The remaining code in the test is not executed. NameNode nn; try { Configuration nnconf = new HdfsConfiguration(c); DFSTestUtil.formatNameNode(nnconf); nn = NameNode.createNameNode( new String [] {}, nnconf); } catch (IOException e) { LOG.info( "IOException is thrown creating name node" ); throw e; } Wonder if I did something wrong? Thanks.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 3m 17s trunk passed
        +1 compile 0m 35s trunk passed with JDK v1.8.0_60
        +1 compile 0m 32s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 16s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        -1 findbugs 1m 54s hadoop-hdfs-project/hadoop-hdfs in trunk cannot run convertXmlToText from findbugs
        +1 javadoc 1m 8s trunk passed with JDK v1.8.0_60
        +1 javadoc 1m 52s trunk passed with JDK v1.7.0_79
        +1 mvninstall 0m 39s the patch passed
        +1 compile 0m 32s the patch passed with JDK v1.8.0_60
        +1 javac 0m 32s the patch passed
        +1 compile 0m 32s the patch passed with JDK v1.7.0_79
        +1 javac 0m 32s the patch passed
        -1 checkstyle 0m 16s Patch generated 1 new checkstyle issues in hadoop-hdfs-project/hadoop-hdfs (total was 186, now 187).
        +1 mvneclipse 0m 13s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 2m 10s the patch passed
        +1 javadoc 1m 10s the patch passed with JDK v1.8.0_60
        +1 javadoc 1m 50s the patch passed with JDK v1.7.0_79
        -1 unit 52m 2s hadoop-hdfs in the patch failed with JDK v1.8.0_60.
        -1 unit 49m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_79.
        -1 asflicense 0m 21s Patch generated 58 ASF License warnings.
        121m 40s



        Reason Tests
        JDK v1.8.0_60 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
        JDK v1.7.0_79 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics
          hadoop.hdfs.server.blockmanagement.TestNodeCount
          hadoop.hdfs.TestRecoverStripedFile
          hadoop.hdfs.TestFileAppend



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-02
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770183/HDFS-9249.004.patch
        JIRA Issue HDFS-9249
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 239c56fbac39 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build@2/patchprocess/apache-yetus-1a9afee/precommit/personality/hadoop.sh
        git revision trunk / 78d6890
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13345/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 226MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13345/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 17s trunk passed +1 compile 0m 35s trunk passed with JDK v1.8.0_60 +1 compile 0m 32s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 16s trunk passed +1 mvneclipse 0m 14s trunk passed -1 findbugs 1m 54s hadoop-hdfs-project/hadoop-hdfs in trunk cannot run convertXmlToText from findbugs +1 javadoc 1m 8s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 52s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 39s the patch passed +1 compile 0m 32s the patch passed with JDK v1.8.0_60 +1 javac 0m 32s the patch passed +1 compile 0m 32s the patch passed with JDK v1.7.0_79 +1 javac 0m 32s the patch passed -1 checkstyle 0m 16s Patch generated 1 new checkstyle issues in hadoop-hdfs-project/hadoop-hdfs (total was 186, now 187). +1 mvneclipse 0m 13s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 2m 10s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 50s the patch passed with JDK v1.7.0_79 -1 unit 52m 2s hadoop-hdfs in the patch failed with JDK v1.8.0_60. -1 unit 49m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_79. -1 asflicense 0m 21s Patch generated 58 ASF License warnings. 121m 40s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes JDK v1.7.0_79 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.TestFileAppend Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-02 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770183/HDFS-9249.004.patch JIRA Issue HDFS-9249 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 239c56fbac39 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build@2/patchprocess/apache-yetus-1a9afee/precommit/personality/hadoop.sh git revision trunk / 78d6890 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13345/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13345/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 226MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13345/console This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        (1) It is not intuitive initially because of the throw-catch control flow. When BackupNode is being instantiated, NameNode.NameNode() calls BackupNode.initialize().

        BackupNode.initialize() also instantiates namesystem object, but if an IOException is thrown before namesystem is instantiated, the controls goes to the catch block in NameNode.initialize(), which in turn calls NameNode.stop(). NameNode.stop() then attempts to call an method of namesystem object despite namesystem object is not instantiated.

        (2) I am not sure why this is happening. I tested the test case on both Mac and Linux and both turned out fine. The Hadoop QA also did not see the unexpected exception thrown.

        Thanks

        Show
        jojochuang Wei-Chiu Chuang added a comment - (1) It is not intuitive initially because of the throw-catch control flow. When BackupNode is being instantiated, NameNode.NameNode() calls BackupNode.initialize(). BackupNode.initialize() also instantiates namesystem object, but if an IOException is thrown before namesystem is instantiated, the controls goes to the catch block in NameNode.initialize(), which in turn calls NameNode.stop(). NameNode.stop() then attempts to call an method of namesystem object despite namesystem object is not instantiated. (2) I am not sure why this is happening. I tested the test case on both Mac and Linux and both turned out fine. The Hadoop QA also did not see the unexpected exception thrown. Thanks
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Also, could you apply&run the rev4 patch? It is possible that you applied the patch uncleanly and therefore not generate the expected result.

        Thank you very much

        Show
        jojochuang Wei-Chiu Chuang added a comment - Also, could you apply&run the rev4 patch? It is possible that you applied the patch uncleanly and therefore not generate the expected result. Thank you very much
        Hide
        yzhangal Yongjun Zhang added a comment -

        Hi Wei-Chiu Chuang,

        Thanks for the explanation. So namesystem is null only when the constructor failed, so the way you check in rev 003 makes sense to me.

        I think we can merge 003 (we still check whether namesystem is null in stop) and 004 (call stop and report exception if there is any) together with the following changes:

          private void stopAtException(Exception e) {
            try {
              this.stop();
            } catch (Exception ex) {
              LOG.warn("Encountered exception when handling exception ("
                  + e.getMessage() + "):", ex);
            }
          }
        ......
            } catch (IOException e) {
              stopAtException(e);
              throw e;
            } catch (HadoopIllegalArgumentException e) {
              stopAtException(e);
              throw e;
            }
        

        Notice that above rev 004, there is another call to {[this.stop()}} right below the one you modified, so my suggested change included both.

        Thanks.

        Show
        yzhangal Yongjun Zhang added a comment - Hi Wei-Chiu Chuang , Thanks for the explanation. So namesystem is null only when the constructor failed, so the way you check in rev 003 makes sense to me. I think we can merge 003 (we still check whether namesystem is null in stop ) and 004 (call stop and report exception if there is any) together with the following changes: private void stopAtException(Exception e) { try { this .stop(); } catch (Exception ex) { LOG.warn( "Encountered exception when handling exception (" + e.getMessage() + "):" , ex); } } ...... } catch (IOException e) { stopAtException(e); throw e; } catch (HadoopIllegalArgumentException e) { stopAtException(e); throw e; } Notice that above rev 004, there is another call to {[this.stop()}} right below the one you modified, so my suggested change included both. Thanks.
        Hide
        yzhangal Yongjun Zhang added a comment -

        BTW, it's a good find of yours about the try/catch code could run into the null pointer situation. Thanks.

        Show
        yzhangal Yongjun Zhang added a comment - BTW, it's a good find of yours about the try/catch code could run into the null pointer situation. Thanks.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Thanks Yongjun Zhang!
        Rev 5 is based on Yongjun's suggestions. The improved code looks cleaner and handles more cases.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Thanks Yongjun Zhang ! Rev 5 is based on Yongjun's suggestions. The improved code looks cleaner and handles more cases.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 7s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 3m 9s trunk passed
        +1 compile 0m 36s trunk passed with JDK v1.8.0_66
        +1 compile 0m 35s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 17s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        -1 findbugs 2m 5s hadoop-hdfs-project/hadoop-hdfs in trunk cannot run convertXmlToText from findbugs
        +1 javadoc 1m 14s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 58s trunk passed with JDK v1.7.0_79
        +1 mvninstall 0m 44s the patch passed
        +1 compile 0m 36s the patch passed with JDK v1.8.0_66
        +1 javac 0m 36s the patch passed
        +1 compile 0m 34s the patch passed with JDK v1.7.0_79
        +1 javac 0m 34s the patch passed
        +1 checkstyle 0m 16s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 2m 14s the patch passed
        +1 javadoc 1m 14s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 58s the patch passed with JDK v1.7.0_79
        -1 unit 70m 5s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 68m 2s hadoop-hdfs in the patch failed with JDK v1.7.0_79.
        -1 asflicense 0m 21s Patch generated 56 ASF License warnings.
        159m 22s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestSnapshotCommands
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
        JDK v1.7.0_79 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery



        Subsystem Report/Notes
        Docker Client=1.7.0 Server=1.7.0 Image:test-patch-base-hadoop-date2015-11-05
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770829/HDFS-9249.005.patch
        JIRA Issue HDFS-9249
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 60fd003c6452 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-e8bd3ad/precommit/personality/hadoop.sh
        git revision trunk / ff47f35
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/13399/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13399/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13399/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13399/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13399/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13399/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13399/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13399/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 226MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13399/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 9s trunk passed +1 compile 0m 36s trunk passed with JDK v1.8.0_66 +1 compile 0m 35s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 17s trunk passed +1 mvneclipse 0m 14s trunk passed -1 findbugs 2m 5s hadoop-hdfs-project/hadoop-hdfs in trunk cannot run convertXmlToText from findbugs +1 javadoc 1m 14s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 58s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 44s the patch passed +1 compile 0m 36s the patch passed with JDK v1.8.0_66 +1 javac 0m 36s the patch passed +1 compile 0m 34s the patch passed with JDK v1.7.0_79 +1 javac 0m 34s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvneclipse 0m 15s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 2m 14s the patch passed +1 javadoc 1m 14s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 58s the patch passed with JDK v1.7.0_79 -1 unit 70m 5s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 68m 2s hadoop-hdfs in the patch failed with JDK v1.7.0_79. -1 asflicense 0m 21s Patch generated 56 ASF License warnings. 159m 22s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestSnapshotCommands   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes JDK v1.7.0_79 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery Subsystem Report/Notes Docker Client=1.7.0 Server=1.7.0 Image:test-patch-base-hadoop-date2015-11-05 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770829/HDFS-9249.005.patch JIRA Issue HDFS-9249 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 60fd003c6452 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-e8bd3ad/precommit/personality/hadoop.sh git revision trunk / ff47f35 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/13399/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.html whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13399/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13399/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13399/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13399/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13399/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13399/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13399/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 226MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13399/console This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Removed an extra space to meet code style expectation.
        The ASF licenses warnings are false positives.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Removed an extra space to meet code style expectation. The ASF licenses warnings are false positives.
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks Wei-Chiu Chuang for the new rev, +1 pending jenkins.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks Wei-Chiu Chuang for the new rev, +1 pending jenkins.
        Hide
        yzhangal Yongjun Zhang added a comment -
        Show
        yzhangal Yongjun Zhang added a comment - Kicked off jenkins build at https://builds.apache.org/job/PreCommit-HDFS-Build/13431/ .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 7s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 3m 14s trunk passed
        +1 compile 0m 36s trunk passed with JDK v1.8.0_66
        +1 compile 0m 34s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 17s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        -1 findbugs 2m 5s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings.
        +1 javadoc 1m 17s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 5s trunk passed with JDK v1.7.0_79
        +1 mvninstall 0m 42s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.8.0_66
        +1 javac 0m 39s the patch passed
        +1 compile 0m 34s the patch passed with JDK v1.7.0_79
        +1 javac 0m 34s the patch passed
        +1 checkstyle 0m 17s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 16s the patch passed
        +1 javadoc 1m 16s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 6s the patch passed with JDK v1.7.0_79
        -1 unit 67m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 65m 26s hadoop-hdfs in the patch failed with JDK v1.7.0_79.
        -1 asflicense 0m 23s Patch generated 56 ASF License warnings.
        154m 50s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.hdfs.TestSafeMode
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
        JDK v1.7.0_79 Failed junit tests hadoop.hdfs.server.blockmanagement.TestNodeCount
          hadoop.hdfs.TestEncryptionZonesWithKMS



        Subsystem Report/Notes
        Docker Client=1.7.0 Server=1.7.0 Image:test-patch-base-hadoop-date2015-11-07
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771040/HDFS-9249.006.patch
        JIRA Issue HDFS-9249
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 9b20e906b344 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh
        git revision trunk / 1ee2db5
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/13431/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13431/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13431/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13431/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13431/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13431/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13431/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 227MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13431/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 14s trunk passed +1 compile 0m 36s trunk passed with JDK v1.8.0_66 +1 compile 0m 34s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 17s trunk passed +1 mvneclipse 0m 15s trunk passed -1 findbugs 2m 5s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 17s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 5s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 42s the patch passed +1 compile 0m 39s the patch passed with JDK v1.8.0_66 +1 javac 0m 39s the patch passed +1 compile 0m 34s the patch passed with JDK v1.7.0_79 +1 javac 0m 34s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 16s the patch passed +1 javadoc 1m 16s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 6s the patch passed with JDK v1.7.0_79 -1 unit 67m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 65m 26s hadoop-hdfs in the patch failed with JDK v1.7.0_79. -1 asflicense 0m 23s Patch generated 56 ASF License warnings. 154m 50s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.TestSafeMode   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport JDK v1.7.0_79 Failed junit tests hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.TestEncryptionZonesWithKMS Subsystem Report/Notes Docker Client=1.7.0 Server=1.7.0 Image:test-patch-base-hadoop-date2015-11-07 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771040/HDFS-9249.006.patch JIRA Issue HDFS-9249 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 9b20e906b344 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh git revision trunk / 1ee2db5 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/13431/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/13431/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13431/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13431/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13431/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13431/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13431/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13431/console This message was automatically generated.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8781 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8781/)
        HDFS-9249. NPE is thrown if an IOException is thrown in NameNode (yzhang: rev 2741a2109b98d0febb463cb318018ecbd3995102)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8781 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8781/ ) HDFS-9249 . NPE is thrown if an IOException is thrown in NameNode (yzhang: rev 2741a2109b98d0febb463cb318018ecbd3995102) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Hide
        yzhangal Yongjun Zhang added a comment -

        Committed to trunk and branch-2.

        Thanks Wei-Chiu Chuang for the contribution and Steve Loughran for the review.

        Show
        yzhangal Yongjun Zhang added a comment - Committed to trunk and branch-2. Thanks Wei-Chiu Chuang for the contribution and Steve Loughran for the review.
        Hide
        yzhangal Yongjun Zhang added a comment -

        BTW, I created HDFS-9404 for the findbugs issue (not introduced by the patch here), and it turned out to be a duplicate of HDFS-9401.

        Show
        yzhangal Yongjun Zhang added a comment - BTW, I created HDFS-9404 for the findbugs issue (not introduced by the patch here), and it turned out to be a duplicate of HDFS-9401 .
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #648 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/648/)
        HDFS-9249. NPE is thrown if an IOException is thrown in NameNode (yzhang: rev 2741a2109b98d0febb463cb318018ecbd3995102)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #648 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/648/ ) HDFS-9249 . NPE is thrown if an IOException is thrown in NameNode (yzhang: rev 2741a2109b98d0febb463cb318018ecbd3995102) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #659 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/659/)
        HDFS-9249. NPE is thrown if an IOException is thrown in NameNode (yzhang: rev 2741a2109b98d0febb463cb318018ecbd3995102)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #659 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/659/ ) HDFS-9249 . NPE is thrown if an IOException is thrown in NameNode (yzhang: rev 2741a2109b98d0febb463cb318018ecbd3995102) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1382 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1382/)
        HDFS-9249. NPE is thrown if an IOException is thrown in NameNode (yzhang: rev 2741a2109b98d0febb463cb318018ecbd3995102)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1382 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1382/ ) HDFS-9249 . NPE is thrown if an IOException is thrown in NameNode (yzhang: rev 2741a2109b98d0febb463cb318018ecbd3995102) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2528 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2528/)
        HDFS-9249. NPE is thrown if an IOException is thrown in NameNode (yzhang: rev 2741a2109b98d0febb463cb318018ecbd3995102)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2528 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2528/ ) HDFS-9249 . NPE is thrown if an IOException is thrown in NameNode (yzhang: rev 2741a2109b98d0febb463cb318018ecbd3995102) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2589 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2589/)
        HDFS-9249. NPE is thrown if an IOException is thrown in NameNode (yzhang: rev 2741a2109b98d0febb463cb318018ecbd3995102)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2589 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2589/ ) HDFS-9249 . NPE is thrown if an IOException is thrown in NameNode (yzhang: rev 2741a2109b98d0febb463cb318018ecbd3995102) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #589 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/589/)
        HDFS-9249. NPE is thrown if an IOException is thrown in NameNode (yzhang: rev 2741a2109b98d0febb463cb318018ecbd3995102)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #589 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/589/ ) HDFS-9249 . NPE is thrown if an IOException is thrown in NameNode (yzhang: rev 2741a2109b98d0febb463cb318018ecbd3995102) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java

          People

          • Assignee:
            jojochuang Wei-Chiu Chuang
            Reporter:
            jojochuang Wei-Chiu Chuang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development