[HDFS-9401] Fix findbugs warnings in BlockRecoveryWorker

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Target Version/s: 2.8.0
• Assignee: Brahma Reddy Battula
• Reporter: Brahma Reddy Battula
• Created: 08/Nov/15 13:39
• Updated: 30/Aug/16 01:23
• Resolved: 10/Nov/15 06:59

Description

Noticed following findbug in HDFS-9400

Call to org.apache.hadoop.hdfs.server.protocol.DatanodeRegistration.equals(org.apache.hadoop.hdfs.protocol.DatanodeInfo) in org.apache.hadoop.hdfs.server.datanode.BlockRecoveryWorker$RecoveryTaskContiguous.recover()
Bug type EC_UNRELATED_TYPES (click for details) 
In class org.apache.hadoop.hdfs.server.datanode.BlockRecoveryWorker$RecoveryTaskContiguous
In method org.apache.hadoop.hdfs.server.datanode.BlockRecoveryWorker$RecoveryTaskContiguous.recover()
Actual type org.apache.hadoop.hdfs.protocol.DatanodeInfo
Expected org.apache.hadoop.hdfs.server.protocol.DatanodeRegistration
Value loaded from id
Value loaded from bpReg
org.apache.hadoop.hdfs.server.protocol.DatanodeRegistration.equals(Object) used to determine equality
At BlockRecoveryWorker.java:[line 116]

https://builds.apache.org/job/PreCommit-HDFS-Build/13433/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html

Issue Links

• is broken by: HDFS-9255 Consolidate block recovery related implementation into a single class
• is duplicated by: HDFS-9404 Findbugs issue reported in BlockRecoveryWorker$RecoveryTaskContiguous.recover()
• relates to: HDFS-3837 Fix DataNode.recoverBlock findbugs warning