[HDFS-6830] BlockInfo.addStorage fails when DN changes the storage for a block replica

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0
• Fix Version/s: 2.6.0
• Component/s: namenode
• Target Version/s: 2.6.0
• Hadoop Flags: Reviewed
• Assignee: Arpit Agarwal
• Reporter: Arpit Agarwal
• Created: 07/Aug/14 03:37
• Updated: 05/Sep/16 16:52
• Resolved: 12/Aug/14 21:43

Description

The call to removeStorageInfo is wrong because the block is still in the DatanodeStorage's list of blocks and the callee does not expect it to be.

      } else {
        // The block is on the DN but belongs to a different storage.
        // Update our state.
        removeStorage(getStorageInfo(idx));
        added = false;      // Just updating storage. Return false.
      }

It is a very unlikely code path to hit since storage updates usually occur via incremental block reports.

Issue Links

• duplicates: HDFS-9334 NameNode crash caused by ArrayIndexOutOfBoundsException
• is duplicated by: HDFS-6805 NPE is thrown at Namenode , for every block report sent from DN
• is related to: HDFS-9334 NameNode crash caused by ArrayIndexOutOfBoundsException
• is related to: HDFS-7960 The full block report should prune zombie storages even if they're not empty
• relates to: HDFS-8380 Always call addStoredBlock on blocks which have been shifted from one storage to another