Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-6830

BlockInfo.addStorage fails when DN changes the storage for a block replica

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.5.0
    • 2.6.0
    • namenode
    • None
    • Reviewed

    Description

      The call to removeStorageInfo is wrong because the block is still in the DatanodeStorage's list of blocks and the callee does not expect it to be.

            } else {
              // The block is on the DN but belongs to a different storage.
              // Update our state.
              removeStorage(getStorageInfo(idx));
              added = false;      // Just updating storage. Return false.
            }
      

      It is a very unlikely code path to hit since storage updates usually occur via incremental block reports.

      Attachments

        1. HDFS-6830.04.patch
          7 kB
          Arpit Agarwal
        2. HDFS-6830.03.patch
          7 kB
          Arpit Agarwal
        3. HDFS-6830.02.patch
          5 kB
          Arpit Agarwal
        4. HDFS-6830.01.patch
          3 kB
          Arpit Agarwal

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            arp Arpit Agarwal Assign to me
            arp Arpit Agarwal
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment