[HDFS-9334] NameNode crash caused by ArrayIndexOutOfBoundsException

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.4.1
• Component/s: namenode
• Assignee: Xiaoqiao He
• Reporter: Xiaoqiao He
• Created: 29/Oct/15 03:06
• Updated: 05/Sep/16 17:02
• Resolved: 05/Sep/16 17:02

Description

when remove block from list of blocks by method listRemove in BlockInfo.java, and findStorageInfo(storage) return -1 means not found, prev.setNext(prev.findStorageInfo(storage), next) or next.setPrevious(next.findStorageInfo(storage), prev) could throw ArrayIndexOutOfBoundsException cause NameNode Process exit.

BlockInfo.java

  BlockInfo listRemove(BlockInfo head, DatanodeStorageInfo storage) {
    if(head == null)
      return null;
    int dnIndex = this.findStorageInfo(storage);
    if(dnIndex < 0) // this block is not on the data-node list
      return head;

    BlockInfo next = this.getNext(dnIndex);
    BlockInfo prev = this.getPrevious(dnIndex);
    this.setNext(dnIndex, null);
    this.setPrevious(dnIndex, null);
    if(prev != null)
      prev.setNext(prev.findStorageInfo(storage), next);
    if(next != null)
      next.setPrevious(next.findStorageInfo(storage), prev);
    if(this == head)  // removing the head
      head = next;
    return head;
  }

Issue Links

• is duplicated by: HDFS-6830 BlockInfo.addStorage fails when DN changes the storage for a block replica
• relates to: HDFS-6830 BlockInfo.addStorage fails when DN changes the storage for a block replica