[HDFS-3171] The DatanodeID "name" field is overloaded

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-alpha
• Component/s: datanode
• Hadoop Flags: Reviewed
• Assignee: Eli Collins
• Reporter: Eli Collins
• Created: 31/Mar/12 17:00
• Updated: 28/Sep/15 20:58
• Resolved: 01/Apr/12 03:48

Description

The DatanodeID "name" field is currently overloaded, when the DN creates a DatanodeID to register with the NN it sets "name" to be the datanode hostname, which is the DN's "hostName" member. This isnot necesarily a FQDN, it is either set explicitly or determined by the DNS class, which could return the machine's hostname or the result of a DNS lookup, if configured to do so. The NN then clobbers the "name" field of the DatanodeID with the IP part of the new DatanodeID "name" field it creates (and sets the DatanodeID "hostName" field to the reported "name"). The DN gets the DatanodeID back from the NN and clobbers its "hostName" member with the "name" field of the returned DatanodeID. This makes the code hard to reason about eg DN#getMachine name sometimes returns a hostname and sometimes not, depending on when it's called in sequence with the registration. Ditto for uses of the "name" field. I think these contortions were originally performed because the DatanodeID didn't have a hostName field (it was part of DatanodeInfo) and so there was no way to communicate both at the same time. Now that the hostName field is in DatanodeID (as of HDFS-3164) we can establish the invariant that the "name" field always and only has an IP address and the "hostName" field always and only has a hostname.

In HDFS-3144 I'm going to rename the "name" field so its clear that it contains an IP address. The above is enough scope for one change.

Issue Links

• is depended upon by: HDFS-3144 Refactor DatanodeID#getName by use
• is related to: HADOOP-8348 Server$Listener.getAddress(..) may throw NullPointerException
• is related to: HDFS-2609 DataNode.getDNRegistrationByMachineName can probably be removed or simplified
• is related to: HDFS-3164 Move DatanodeInfo#hostName to DatanodeID