Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-2609

DataNode.getDNRegistrationByMachineName can probably be removed or simplified

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Later
    • 0.23.0
    • None
    • datanode
    • None

    Description

      I noticed this while working on HDFS-1971: The getDNRegistrationByMachineName iterates over block pools to return a given block pool's registration object based on its machineName field. But, the machine name for every BPOfferService is identical - they're always constructed by just calling DataNode.getName. All of the call sites for this function are from tests, as well. So, maybe it's not necessary, or at least it might be able to be simplified or moved to a test method.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            eli Eli Collins
            tlipcon Todd Lipcon
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment