Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.9.0, 2.8.2
    • Component/s: httpfs, scripts
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Do the same for HttpFS as HADOOP-14050.

      No need to fix trunk because HDFS-10860 will take care of it.

        Issue Links

          Activity

          Hide
          cheersyang Weiwei Yang added a comment -

          Attached a patch for branch-2. I have tested this locally, the only problem to me was the "-Dproc_httpfs" was in the middle of the jvm opts, not like other daemons right after .../java -Dproc_xx, a little bit inconsistent. That is because httpfs was started by tomcat catalina.sh, that script takes care of the assembling of classpaths, putting a bunch of stuff ahead of CATALINA_OPTS, such as $LOGGING_CONFIG and $LOGGING_MANAGER. Guess we are OK with that? HADOOP-14050 has the same problem.

          Show
          cheersyang Weiwei Yang added a comment - Attached a patch for branch-2. I have tested this locally, the only problem to me was the "-Dproc_httpfs" was in the middle of the jvm opts, not like other daemons right after .../java -Dproc_xx, a little bit inconsistent. That is because httpfs was started by tomcat catalina.sh, that script takes care of the assembling of classpaths, putting a bunch of stuff ahead of CATALINA_OPTS, such as $LOGGING_CONFIG and $LOGGING_MANAGER. Guess we are OK with that? HADOOP-14050 has the same problem.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 57s Docker mode activated.
          0 shelldocs 0m 18s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 9s branch-2 passed
          +1 mvnsite 0m 50s branch-2 passed
          +1 mvnsite 0m 41s the patch passed
          +1 shellcheck 0m 9s There were no new shellcheck issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 unit 0m 19s hadoop-hdfs-httpfs in the patch passed with JDK v1.7.0_121.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          25m 22s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HDFS-11390
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851105/HDFS-11390-branch-2.01.patch
          Optional Tests asflicense mvnsite unit shellcheck shelldocs
          uname Linux 93225615de93 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 378d626
          shellcheck v0.4.5
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18329/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18329/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 57s Docker mode activated. 0 shelldocs 0m 18s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 9s branch-2 passed +1 mvnsite 0m 50s branch-2 passed +1 mvnsite 0m 41s the patch passed +1 shellcheck 0m 9s There were no new shellcheck issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 0m 19s hadoop-hdfs-httpfs in the patch passed with JDK v1.7.0_121. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 25m 22s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-11390 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851105/HDFS-11390-branch-2.01.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 93225615de93 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 378d626 shellcheck v0.4.5 JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18329/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18329/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hi John Zhuge

          Does the patch look good to you? Please let me know.

          Show
          cheersyang Weiwei Yang added a comment - Hi John Zhuge Does the patch look good to you? Please let me know.
          Hide
          jzhuge John Zhuge added a comment -

          +1 (non-binding) The change LGTM. Tested the patch on CDH5.

          As for "-Dproc_httpfs" in the middle of the jvm opts, JAVA_OPTS may be a little better, but not too much. Here is how the java command line is formulated in catalina.sh:

          "$_RUNJAVA" "$LOGGING_CONFIG" $LOGGING_MANAGER $JAVA_OPTS $CATALINA_OPTS
          

          You can see long entries for LOGGING_CONFIG and LOGGING_MANAGER on the jvm command line after applying the patch:

          52941 Bootstrap -Djava.util.logging.config.file=.../share/hadoop/httpfs/tomcat/conf/logging.properties -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager -Djdk.tls.ephemeralDHKeySize=2048 -Dproc_httpfs -Dhttpfs.home.dir=...
          
          Show
          jzhuge John Zhuge added a comment - +1 (non-binding) The change LGTM. Tested the patch on CDH5. As for "-Dproc_httpfs" in the middle of the jvm opts, JAVA_OPTS may be a little better, but not too much. Here is how the java command line is formulated in catalina.sh: "$_RUNJAVA" "$LOGGING_CONFIG" $LOGGING_MANAGER $JAVA_OPTS $CATALINA_OPTS You can see long entries for LOGGING_CONFIG and LOGGING_MANAGER on the jvm command line after applying the patch: 52941 Bootstrap -Djava.util.logging.config.file=.../share/hadoop/httpfs/tomcat/conf/logging.properties -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager -Djdk.tls.ephemeralDHKeySize=2048 -Dproc_httpfs -Dhttpfs.home.dir=...
          Hide
          cheersyang Weiwei Yang added a comment - - edited

          Hi John Zhuge

          Thanks, I noticed that too. Since HADOOP-14050 is already committed, lets use same approach here and stick to the current patch, agree?

          Show
          cheersyang Weiwei Yang added a comment - - edited Hi John Zhuge Thanks, I noticed that too. Since HADOOP-14050 is already committed, lets use same approach here and stick to the current patch, agree?
          Hide
          jzhuge John Zhuge added a comment -

          Ok with me.

          Show
          jzhuge John Zhuge added a comment - Ok with me.
          Hide
          xiaochen Xiao Chen added a comment -

          +1 committing this

          Show
          xiaochen Xiao Chen added a comment - +1 committing this
          Hide
          xiaochen Xiao Chen added a comment -

          Committed this to branch-2 and branch-2.8. Thanks Weiwei Yang for the patch and John Zhuge for reporting/testing!

          Show
          xiaochen Xiao Chen added a comment - Committed this to branch-2 and branch-2.8. Thanks Weiwei Yang for the patch and John Zhuge for reporting/testing!
          Hide
          cheersyang Weiwei Yang added a comment -

          Thanks Xiao Chen!

          Show
          cheersyang Weiwei Yang added a comment - Thanks Xiao Chen !
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

            People

            • Assignee:
              cheersyang Weiwei Yang
              Reporter:
              jzhuge John Zhuge
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development