Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.9.0, 2.8.2
    • Component/s: kms, scripts
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Like other hadoop daemons, we should start the kms process with -Dproc_<daemon-name> (e.g. -Dproc_kms).
      This will help ops script to easily grep the process with this name.

        Issue Links

          Activity

          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.
          Hide
          jzhuge John Zhuge added a comment -

          Filed HDFS-11390 for HttpFS in branch-2.

          Show
          jzhuge John Zhuge added a comment - Filed HDFS-11390 for HttpFS in branch-2.
          Hide
          shahrs87 Rushabh S Shah added a comment -

          Thanks John Zhuge for reviewing and testing.
          Thanks Kihwal Lee for review and for committing.

          Show
          shahrs87 Rushabh S Shah added a comment - Thanks John Zhuge for reviewing and testing. Thanks Kihwal Lee for review and for committing.
          Hide
          kihwal Kihwal Lee added a comment -

          Committed this to branch-2 and branch-2.8. Thanks for fixing this Rushabh. Thanks for testing it, John Zhuge.

          Show
          kihwal Kihwal Lee added a comment - Committed this to branch-2 and branch-2.8. Thanks for fixing this Rushabh. Thanks for testing it, John Zhuge .
          Hide
          kihwal Kihwal Lee added a comment -

          +1

          Show
          kihwal Kihwal Lee added a comment - +1
          Hide
          jzhuge John Zhuge added a comment -

          +1 (non-binding)

          Tested the patch on CDH5 trunk (loosely based on branch-2.6).

          Show
          jzhuge John Zhuge added a comment - +1 (non-binding) Tested the patch on CDH5 trunk (loosely based on branch-2.6).
          Hide
          shahrs87 Rushabh S Shah added a comment -

          Hi John Zhuge,
          can you please review the patch ?

          Show
          shahrs87 Rushabh S Shah added a comment - Hi John Zhuge , can you please review the patch ?
          Hide
          jzhuge John Zhuge added a comment -

          Ignore my previous comment, the command line already has -Dproc_kms.

          Show
          jzhuge John Zhuge added a comment - Ignore my previous comment, the command line already has -Dproc_kms .
          Hide
          jzhuge John Zhuge added a comment -

          Rushabh S Shah Thanks for the contribution. Do you plan to fix trunk? In hadoop-kms.sh.

          Show
          jzhuge John Zhuge added a comment - Rushabh S Shah Thanks for the contribution. Do you plan to fix trunk? In hadoop-kms.sh .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 45s branch-2 passed
          +1 mvnsite 0m 26s branch-2 passed
          +1 mvnsite 0m 20s the patch passed
          +1 shellcheck 0m 9s There were no new shellcheck issues.
          +1 shelldocs 0m 7s There were no new shelldocs issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 unit 0m 17s hadoop-kms in the patch passed with JDK v1.7.0_121.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          9m 30s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HADOOP-14050
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12850655/HADOOP-14050-branch-2.patch
          Optional Tests asflicense mvnsite unit shellcheck shelldocs
          uname Linux 712f1d74c985 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / c699ce7
          shellcheck v0.4.5
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11562/testReport/
          modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11562/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 45s branch-2 passed +1 mvnsite 0m 26s branch-2 passed +1 mvnsite 0m 20s the patch passed +1 shellcheck 0m 9s There were no new shellcheck issues. +1 shelldocs 0m 7s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 0m 17s hadoop-kms in the patch passed with JDK v1.7.0_121. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 9m 30s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HADOOP-14050 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12850655/HADOOP-14050-branch-2.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 712f1d74c985 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / c699ce7 shellcheck v0.4.5 JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11562/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11562/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          shahrs87 Rushabh S Shah added a comment -

          Applies cleanly to branch-2.7/branch-2.8.
          Allen Wittenauer: do you mind reviewing this tiny patch ?

          Show
          shahrs87 Rushabh S Shah added a comment - Applies cleanly to branch-2.7/branch-2.8. Allen Wittenauer : do you mind reviewing this tiny patch ?
          Hide
          shahrs87 Rushabh S Shah added a comment -

          FYI, HADOOP-13597 did this for 3.0.0.

          Thanks! I did notice that but still we need this change for brach-2 and branch-2.8 (and maybe for branch-2.7).

          Show
          shahrs87 Rushabh S Shah added a comment - FYI, HADOOP-13597 did this for 3.0.0. Thanks! I did notice that but still we need this change for brach-2 and branch-2.8 (and maybe for branch-2.7).
          Hide
          aw Allen Wittenauer added a comment -

          FYI, HADOOP-13597 did this for 3.0.0.

          Show
          aw Allen Wittenauer added a comment - FYI, HADOOP-13597 did this for 3.0.0.

            People

            • Assignee:
              shahrs87 Rushabh S Shah
              Reporter:
              shahrs87 Rushabh S Shah
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development