Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10759

Change fsimage bool isStriped from boolean to an enum

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1, 3.0.0-beta1, 3.0.0-alpha2
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: hdfs

      Description

      The new erasure coding project has updated the protocol for fsimage such that the INodeFile has a boolean 'isStriped'. I think this is better as an enum or integer since a boolean precludes any future block types.

      For example:

      enum BlockType {
        CONTIGUOUS = 0,
        STRIPED = 1,
      }
      

      We can also make this more robust to future changes where there are different block types supported in a staged rollout. Here, we would use UNKNOWN_BLOCK_TYPE as the first value since this is the default value. See here for more discussion.

      enum BlockType {
        UNKNOWN_BLOCK_TYPE = 0,
        CONTIGUOUS = 1,
        STRIPED = 2,
      }
      

      But I'm not convinced this is necessary since there are other enums that don't use this approach.

      1. HDFS-10759.0001.patch
        69 kB
        Ewan Higgs
      2. HDFS-10759.0002.patch
        69 kB
        Ewan Higgs
      3. HDFS-10759.0003.patch
        68 kB
        Ewan Higgs
      4. HDFS-10759.0004.patch
        72 kB
        Ewan Higgs

        Issue Links

          Activity

          Hide
          ehiggs Ewan Higgs added a comment -

          Attached patch which converts isStriped to an enum on the protocol level. This has been rebased to 0690f0969efef201b074a8b26400b2e5ba9b97ad.

          Show
          ehiggs Ewan Higgs added a comment - Attached patch which converts isStriped to an enum on the protocol level. This has been rebased to 0690f0969efef201b074a8b26400b2e5ba9b97ad.
          Hide
          ehiggs Ewan Higgs added a comment -

          Zhe Zhang, Rui Gao or Kai Zheng are probably ideal reviewers.

          Show
          ehiggs Ewan Higgs added a comment - Zhe Zhang , Rui Gao or Kai Zheng are probably ideal reviewers.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 27s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
          0 mvndep 0m 33s Maven dependency ordering for branch
          +1 mvninstall 8m 7s trunk passed
          +1 compile 1m 31s trunk passed
          +1 checkstyle 0m 44s trunk passed
          +1 mvnsite 1m 33s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 3m 21s trunk passed
          +1 javadoc 1m 19s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 23s the patch passed
          +1 compile 1m 29s the patch passed
          +1 cc 1m 29s the patch passed
          +1 javac 1m 29s the patch passed
          -0 checkstyle 0m 42s hadoop-hdfs-project: The patch generated 21 new + 1109 unchanged - 5 fixed = 1130 total (was 1114)
          +1 mvnsite 1m 29s the patch passed
          +1 mvneclipse 0m 20s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 35s the patch passed
          +1 javadoc 1m 22s the patch passed
          +1 unit 0m 58s hadoop-hdfs-client in the patch passed.
          -1 unit 76m 2s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          107m 41s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.server.datanode.TestDataNodeLifeline
            hadoop.hdfs.server.namenode.TestFileTruncate



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10759
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826797/HDFS-10759.0001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux ef105645de10 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0690f09
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16615/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16615/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16615/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16615/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 0m 33s Maven dependency ordering for branch +1 mvninstall 8m 7s trunk passed +1 compile 1m 31s trunk passed +1 checkstyle 0m 44s trunk passed +1 mvnsite 1m 33s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 21s trunk passed +1 javadoc 1m 19s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 23s the patch passed +1 compile 1m 29s the patch passed +1 cc 1m 29s the patch passed +1 javac 1m 29s the patch passed -0 checkstyle 0m 42s hadoop-hdfs-project: The patch generated 21 new + 1109 unchanged - 5 fixed = 1130 total (was 1114) +1 mvnsite 1m 29s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 35s the patch passed +1 javadoc 1m 22s the patch passed +1 unit 0m 58s hadoop-hdfs-client in the patch passed. -1 unit 76m 2s hadoop-hdfs in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 107m 41s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.server.datanode.TestDataNodeLifeline   hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10759 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826797/HDFS-10759.0001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux ef105645de10 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0690f09 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16615/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16615/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16615/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16615/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          zhz Zhe Zhang added a comment -

          Sorry for the late response. I just labeled this as a 3.0 blocker, and will get back on this soon.

          Pinging Andrew Wang Jing Zhao for additional thoughts.

          Show
          zhz Zhe Zhang added a comment - Sorry for the late response. I just labeled this as a 3.0 blocker, and will get back on this soon. Pinging Andrew Wang Jing Zhao for additional thoughts.
          Hide
          andrew.wang Andrew Wang added a comment -

          Idea seems fine to me, I like evolvable datatypes.

          Show
          andrew.wang Andrew Wang added a comment - Idea seems fine to me, I like evolvable datatypes.
          Hide
          jingzhao Jing Zhao added a comment -

          Yeah I also think the idea is good. But we need to guarantee the compatibility: the old fsimage should still be supported and new enum types should be easily added (which means we may need to add UNKNOWN_TYPE in the enum according to the link).

          Show
          jingzhao Jing Zhao added a comment - Yeah I also think the idea is good. But we need to guarantee the compatibility: the old fsimage should still be supported and new enum types should be easily added (which means we may need to add UNKNOWN_TYPE in the enum according to the link).
          Hide
          ehiggs Ewan Higgs added a comment -

          Jing Zhao

          But we need to guarantee the compatibility: the old fsimage should still be supported and new enum types should be easily added (which means we may need to add UNKNOWN_TYPE in the enum according to the link).

          I looked into this but really as this is an optional field, it should default to the existing behaviour (i.e. default is contiguous and not "unknown"). If omitting the enum meant the block type was "unknown" new code wouldn't be able to handle legacy blocks (since none of them have this field set). This would mean the enum would be, in effect, required for all blocks since we need to specify that it's not unknown.

          Instead, I've made the default contiguous so existing blocks can be handled.

          Show
          ehiggs Ewan Higgs added a comment - Jing Zhao But we need to guarantee the compatibility: the old fsimage should still be supported and new enum types should be easily added (which means we may need to add UNKNOWN_TYPE in the enum according to the link). I looked into this but really as this is an optional field, it should default to the existing behaviour (i.e. default is contiguous and not "unknown"). If omitting the enum meant the block type was "unknown" new code wouldn't be able to handle legacy blocks (since none of them have this field set). This would mean the enum would be, in effect, required for all blocks since we need to specify that it's not unknown. Instead, I've made the default contiguous so existing blocks can be handled.
          Hide
          ehiggs Ewan Higgs added a comment -

          Attached is HDFS-10759.0002.patch which will make this change backwards compatible to the existing boolean isStriped in the fsimage. This is done by making the BlockType enum work with CONTIGUOUS=0, STRIPED=1 as this mirrors the boolean behaviour.

          As both the boolean and the enum are optional, they are usually left out of the wire protocol. If they are explicitly set then they will have the same semantic values on the wire now.

          Given the following messages:

          /**                                                                             
           * Types of recognized blocks.                                                 
           */                                                                            
          enum BlockTypeProto {                                                           
              CONTIGUOUS = 0;                                                            
              STRIPED = 1;                                                               
          }   
           
            message INodeFile {                                                          
              optional uint32 replication = 1;                                           
              optional uint64 modificationTime = 2;                                      
              optional uint64 accessTime = 3;                                            
              optional uint64 preferredBlockSize = 4;                                    
              optional fixed64 permission = 5;                                           
              repeated BlockProto blocks = 6;                                            
              optional FileUnderConstructionFeature fileUC = 7;                          
              optional AclFeatureProto acl = 8;                                           
              optional XAttrFeatureProto xAttrs = 9;                                     
              optional uint32 storagePolicyID = 10;                                      
              optional BlockTypeProto blockType = 11;                                     
            }                                                                            
                                                                                          
            /* ehiggs - old style using bool blockType */                                 
            message INodeFileOld {                                                       
              optional uint32 replication = 1;                                           
              optional uint64 modificationTime = 2;                                      
              optional uint64 accessTime = 3;                                            
              optional uint64 preferredBlockSize = 4;                                    
              optional fixed64 permission = 5;                                           
              repeated BlockProto blocks = 6;                                            
              optional FileUnderConstructionFeature fileUC = 7;                          
              optional AclFeatureProto acl = 8;                                          
              optional XAttrFeatureProto xAttrs = 9;                                     
              optional uint32 storagePolicyID = 10;                                      
              optional bool isStriped = 11;                                              
            }  
          

          We can then see that these serialise as the same values:

          In [1]: import fsimage_pb2
           
          In [2]: f_enum = fsimage_pb2.INodeSection.INodeFile()
           
          In [3]: f_bool = fsimage_pb2.INodeSection.INodeFileOld()
           
          In [4]: f_enum.SerializeToString() # Wire format of entirely optional message. Empty!
          Out[4]: ''
           
          In [5]: f_bool.SerializeToString() # With a bool, everything is still empty. No surprises.
          Out[5]: ''
           
          In [6]: f_enum.blockType = 0
           
          In [7]: f_bool.isStriped = False
           
          In [8]: f_enum.SerializeToString() # wire format of explicit BlockType.CONTIGUOUS
          Out[8]: 'X\x00'
           
          In [9]: f_bool.SerializeToString() # wire format of explicit false
          Out[9]: 'X\x00'
           
          In [10]: f_enum.blockType = 1 # Set explicity to STRIPED
           
          In [11]: f_bool.isStriped = True # turn isStriped to True.
           
          In [12]: f_enum.SerializeToString()
          Out[12]: 'X\x01'
           
          In [13]: f_bool.SerializeToString()
          Out[13]: 'X\x01'
          
          Show
          ehiggs Ewan Higgs added a comment - Attached is HDFS-10759 .0002.patch which will make this change backwards compatible to the existing boolean isStriped in the fsimage . This is done by making the BlockType enum work with CONTIGUOUS=0, STRIPED=1 as this mirrors the boolean behaviour. As both the boolean and the enum are optional, they are usually left out of the wire protocol. If they are explicitly set then they will have the same semantic values on the wire now. Given the following messages: /** * Types of recognized blocks. */ enum BlockTypeProto { CONTIGUOUS = 0; STRIPED = 1; } message INodeFile { optional uint32 replication = 1; optional uint64 modificationTime = 2; optional uint64 accessTime = 3; optional uint64 preferredBlockSize = 4; optional fixed64 permission = 5; repeated BlockProto blocks = 6; optional FileUnderConstructionFeature fileUC = 7; optional AclFeatureProto acl = 8; optional XAttrFeatureProto xAttrs = 9; optional uint32 storagePolicyID = 10; optional BlockTypeProto blockType = 11; } /* ehiggs - old style using bool blockType */ message INodeFileOld { optional uint32 replication = 1; optional uint64 modificationTime = 2; optional uint64 accessTime = 3; optional uint64 preferredBlockSize = 4; optional fixed64 permission = 5; repeated BlockProto blocks = 6; optional FileUnderConstructionFeature fileUC = 7; optional AclFeatureProto acl = 8; optional XAttrFeatureProto xAttrs = 9; optional uint32 storagePolicyID = 10; optional bool isStriped = 11; } We can then see that these serialise as the same values: In [1]: import fsimage_pb2 In [2]: f_enum = fsimage_pb2.INodeSection.INodeFile() In [3]: f_bool = fsimage_pb2.INodeSection.INodeFileOld() In [4]: f_enum.SerializeToString() # Wire format of entirely optional message. Empty! Out[4]: '' In [5]: f_bool.SerializeToString() # With a bool, everything is still empty. No surprises. Out[5]: '' In [6]: f_enum.blockType = 0 In [7]: f_bool.isStriped = False In [8]: f_enum.SerializeToString() # wire format of explicit BlockType.CONTIGUOUS Out[8]: 'X\x00' In [9]: f_bool.SerializeToString() # wire format of explicit false Out[9]: 'X\x00' In [10]: f_enum.blockType = 1 # Set explicity to STRIPED In [11]: f_bool.isStriped = True # turn isStriped to True. In [12]: f_enum.SerializeToString() Out[12]: 'X\x01' In [13]: f_bool.SerializeToString() Out[13]: 'X\x01'
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 6s HDFS-10759 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue HDFS-10759
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837786/HDFS-10759.0002.patch
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17959/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 6s HDFS-10759 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-10759 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837786/HDFS-10759.0002.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17959/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          I like the proposal and retriggered the Jenkins build for patch 0002, but it doesn't apply any more. Ewan Higgs would you rebase your patch? Thanks

          Show
          jojochuang Wei-Chiu Chuang added a comment - I like the proposal and retriggered the Jenkins build for patch 0002, but it doesn't apply any more. Ewan Higgs would you rebase your patch? Thanks
          Hide
          ehiggs Ewan Higgs added a comment -

          Attached a new patch, updated to apply to:

          commit 6938b677111a5fa6bf654717b310220f98b7cf20
          Author: Brahma Reddy Battula <brahma@apache.org>
          Date:   Sat Dec 31 16:16:02 2016 +0530
          
              HADOOP-13883. Addendum patch to correct the message and alphabetized  with the earlier patch. Contributed by Yiqun Lin.
          
          Show
          ehiggs Ewan Higgs added a comment - Attached a new patch, updated to apply to: commit 6938b677111a5fa6bf654717b310220f98b7cf20 Author: Brahma Reddy Battula <brahma@apache.org> Date: Sat Dec 31 16:16:02 2016 +0530 HADOOP-13883. Addendum patch to correct the message and alphabetized with the earlier patch. Contributed by Yiqun Lin.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 26s Maven dependency ordering for branch
          +1 mvninstall 12m 30s trunk passed
          +1 compile 1m 21s trunk passed
          +1 checkstyle 0m 40s trunk passed
          +1 mvnsite 1m 22s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 3m 12s trunk passed
          +1 javadoc 1m 2s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 25s the patch passed
          +1 compile 1m 23s the patch passed
          +1 cc 1m 23s the patch passed
          +1 javac 1m 23s the patch passed
          -0 checkstyle 0m 38s hadoop-hdfs-project: The patch generated 3 new + 775 unchanged - 3 fixed = 778 total (was 778)
          +1 mvnsite 1m 20s the patch passed
          +1 mvneclipse 0m 21s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 3m 22s the patch passed
          +1 javadoc 0m 57s the patch passed
          +1 unit 0m 54s hadoop-hdfs-client in the patch passed.
          -1 unit 66m 43s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          100m 3s



          Reason Tests
          Failed junit tests hadoop.hdfs.web.TestWebHDFSXAttr
            hadoop.hdfs.web.TestWebHDFS
            hadoop.hdfs.web.TestWebHdfsWithRestCsrfPreventionFilter
            hadoop.hdfs.web.TestWebHdfsTokens
            hadoop.hdfs.server.namenode.TestAuditLogs
          Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-10759
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845293/HDFS-11026.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
          uname Linux 2f0ceeb94074 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6938b67
          Default Java 1.8.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17999/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17999/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17999/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17999/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 26s Maven dependency ordering for branch +1 mvninstall 12m 30s trunk passed +1 compile 1m 21s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 1m 22s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 3m 12s trunk passed +1 javadoc 1m 2s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 25s the patch passed +1 compile 1m 23s the patch passed +1 cc 1m 23s the patch passed +1 javac 1m 23s the patch passed -0 checkstyle 0m 38s hadoop-hdfs-project: The patch generated 3 new + 775 unchanged - 3 fixed = 778 total (was 778) +1 mvnsite 1m 20s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 22s the patch passed +1 javadoc 0m 57s the patch passed +1 unit 0m 54s hadoop-hdfs-client in the patch passed. -1 unit 66m 43s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 100m 3s Reason Tests Failed junit tests hadoop.hdfs.web.TestWebHDFSXAttr   hadoop.hdfs.web.TestWebHDFS   hadoop.hdfs.web.TestWebHdfsWithRestCsrfPreventionFilter   hadoop.hdfs.web.TestWebHdfsTokens   hadoop.hdfs.server.namenode.TestAuditLogs Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-10759 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845293/HDFS-11026.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux 2f0ceeb94074 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6938b67 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17999/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17999/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17999/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17999/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ehiggs Ewan Higgs added a comment -

          The WebFS failures are broken on trunk for me. I cannot reproduce the timeout locally on OS X or Ubuntu 16.10.

          Show
          ehiggs Ewan Higgs added a comment - The WebFS failures are broken on trunk for me. I cannot reproduce the timeout locally on OS X or Ubuntu 16.10.
          Hide
          andrew.wang Andrew Wang added a comment -

          Hi Ewan Higgs, I think you accidentally attached a patch for HDFS-11026 instead. FWIW, TestWebHDFS also does pass for me on trunk.

          Show
          andrew.wang Andrew Wang added a comment - Hi Ewan Higgs , I think you accidentally attached a patch for HDFS-11026 instead. FWIW, TestWebHDFS also does pass for me on trunk.
          Hide
          ehiggs Ewan Higgs added a comment -

          Attached the correct patch.

          Show
          ehiggs Ewan Higgs added a comment - Attached the correct patch.
          Hide
          ehiggs Ewan Higgs added a comment -

          The TestWebHDFS* test failues appear to have been impacted by HDFS-11280. A patch was committed and then reverted and has since been fixed.

          Show
          ehiggs Ewan Higgs added a comment - The TestWebHDFS* test failues appear to have been impacted by HDFS-11280 . A patch was committed and then reverted and has since been fixed.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
          0 mvndep 0m 7s Maven dependency ordering for branch
          +1 mvninstall 13m 49s trunk passed
          +1 compile 1m 35s trunk passed
          +1 checkstyle 0m 46s trunk passed
          +1 mvnsite 1m 34s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 3m 29s trunk passed
          +1 javadoc 1m 5s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 22s the patch passed
          +1 compile 1m 29s the patch passed
          +1 cc 1m 29s the patch passed
          +1 javac 1m 29s the patch passed
          -0 checkstyle 0m 44s hadoop-hdfs-project: The patch generated 21 new + 1093 unchanged - 3 fixed = 1114 total (was 1096)
          +1 mvnsite 1m 28s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 1s The patch has no whitespace issues.
          +1 findbugs 3m 46s the patch passed
          +1 javadoc 0m 59s the patch passed
          +1 unit 0m 58s hadoop-hdfs-client in the patch passed.
          +1 unit 68m 45s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          104m 58s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-10759
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845755/HDFS-10759.0003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 2f2b884d4dc4 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a605ff3
          Default Java 1.8.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18033/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18033/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18033/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 0m 7s Maven dependency ordering for branch +1 mvninstall 13m 49s trunk passed +1 compile 1m 35s trunk passed +1 checkstyle 0m 46s trunk passed +1 mvnsite 1m 34s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 29s trunk passed +1 javadoc 1m 5s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 22s the patch passed +1 compile 1m 29s the patch passed +1 cc 1m 29s the patch passed +1 javac 1m 29s the patch passed -0 checkstyle 0m 44s hadoop-hdfs-project: The patch generated 21 new + 1093 unchanged - 3 fixed = 1114 total (was 1096) +1 mvnsite 1m 28s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 3m 46s the patch passed +1 javadoc 0m 59s the patch passed +1 unit 0m 58s hadoop-hdfs-client in the patch passed. +1 unit 68m 45s hadoop-hdfs in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 104m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-10759 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845755/HDFS-10759.0003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 2f2b884d4dc4 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a605ff3 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18033/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18033/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18033/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          Thanks for the rev Ewan. Overall this looks really good, just nitty review comments. Since this is a big patch with a lot of mechanical changes, I'll try to review promptly to reduce rebase overhead. Some review comments:

          • It looks like checkstyle is unhappy, I think your IDE is set to wider than 80 chars line width, some other issues too.
          • It'd be good to have a test that the default value of the proto enum is CONTIGUOUS as expected, per Jing's concern.
          • INodeFile#BLOCK_TYPE_MASK_CONTIGUOUS is unused
          • BLOCK_ID_MASK_STRIPED could use a comment, I double taked initially when I saw blockType was being compared against a variable named MASK, and it was the same value as BLOCK_ID_MASK.
          • BlockType could use some more unit tests with filled in lower values.
          Show
          andrew.wang Andrew Wang added a comment - Thanks for the rev Ewan. Overall this looks really good, just nitty review comments. Since this is a big patch with a lot of mechanical changes, I'll try to review promptly to reduce rebase overhead. Some review comments: It looks like checkstyle is unhappy, I think your IDE is set to wider than 80 chars line width, some other issues too. It'd be good to have a test that the default value of the proto enum is CONTIGUOUS as expected, per Jing's concern. INodeFile#BLOCK_TYPE_MASK_CONTIGUOUS is unused BLOCK_ID_MASK_STRIPED could use a comment, I double taked initially when I saw blockType was being compared against a variable named MASK, and it was the same value as BLOCK_ID_MASK. BlockType could use some more unit tests with filled in lower values.
          Hide
          ehiggs Ewan Higgs added a comment -

          Attached an updated patch that reflects Andrew Wang's comments.

          • Checkstyle is mostly satisfied except where I've been consistent with previous code.
          • testBlockTypeProtoDefaultsToContiguous added to verify that INodeFile defaults to Contiguous blocks.
          • Removed INodeFile#BLOCK_TYPE_MASK_CONTIGUOUS
          • BLOCK_ID_MASK_STRIPED now has some more documentation.
          • Further testing on BlockType.
          Show
          ehiggs Ewan Higgs added a comment - Attached an updated patch that reflects Andrew Wang 's comments. Checkstyle is mostly satisfied except where I've been consistent with previous code. testBlockTypeProtoDefaultsToContiguous added to verify that INodeFile defaults to Contiguous blocks. Removed INodeFile#BLOCK_TYPE_MASK_CONTIGUOUS BLOCK_ID_MASK_STRIPED now has some more documentation. Further testing on BlockType.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 22s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
          0 mvndep 0m 33s Maven dependency ordering for branch
          +1 mvninstall 14m 4s trunk passed
          +1 compile 1m 22s trunk passed
          +1 checkstyle 0m 44s trunk passed
          +1 mvnsite 1m 26s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 3m 21s trunk passed
          +1 javadoc 1m 0s trunk passed
          0 mvndep 0m 6s Maven dependency ordering for patch
          +1 mvninstall 1m 22s the patch passed
          +1 compile 1m 24s the patch passed
          +1 cc 1m 24s the patch passed
          +1 javac 1m 24s the patch passed
          -0 checkstyle 0m 42s hadoop-hdfs-project: The patch generated 3 new + 1093 unchanged - 5 fixed = 1096 total (was 1098)
          +1 mvnsite 1m 22s the patch passed
          +1 mvneclipse 0m 21s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 30s the patch passed
          +1 javadoc 0m 59s the patch passed
          +1 unit 0m 56s hadoop-hdfs-client in the patch passed.
          -1 unit 92m 44s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          128m 41s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestMaintenanceState



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-10759
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847190/HDFS-10759.0004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 276c7fe19a7e 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1f344e0
          Default Java 1.8.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18161/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18161/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18161/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18161/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 0m 33s Maven dependency ordering for branch +1 mvninstall 14m 4s trunk passed +1 compile 1m 22s trunk passed +1 checkstyle 0m 44s trunk passed +1 mvnsite 1m 26s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 21s trunk passed +1 javadoc 1m 0s trunk passed 0 mvndep 0m 6s Maven dependency ordering for patch +1 mvninstall 1m 22s the patch passed +1 compile 1m 24s the patch passed +1 cc 1m 24s the patch passed +1 javac 1m 24s the patch passed -0 checkstyle 0m 42s hadoop-hdfs-project: The patch generated 3 new + 1093 unchanged - 5 fixed = 1096 total (was 1098) +1 mvnsite 1m 22s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 30s the patch passed +1 javadoc 0m 59s the patch passed +1 unit 0m 56s hadoop-hdfs-client in the patch passed. -1 unit 92m 44s hadoop-hdfs in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 128m 41s Reason Tests Failed junit tests hadoop.hdfs.TestMaintenanceState Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-10759 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847190/HDFS-10759.0004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 276c7fe19a7e 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1f344e0 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18161/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/18161/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18161/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18161/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          +1 LGTM, thanks Ewan for the contribution! I've committed this to trunk.

          Show
          andrew.wang Andrew Wang added a comment - +1 LGTM, thanks Ewan for the contribution! I've committed this to trunk.
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Jenkins build Hadoop-trunk-Commit #11136 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11136/)
          HDFS-10759. Change fsimage bool isStriped from boolean to an enum. (wang: rev a2a5d7b5bca715835d92816e7b267b59f7270708)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockIdManager.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/proto/fsimage.proto
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFileAttributes.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/FSImageFormatPBSnapshot.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDeadDatanode.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/LocatedBlock.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageReconstructor.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStripedINodeFile.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoContiguous.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockUnderConstructionFeature.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicies.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatPBINode.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImage.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoStriped.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/hdfs.proto
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocolPB/TestPBHelper.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java
          • (add) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/BlockType.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          • (add) hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/hdfs/protocol/TestBlockType.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Jenkins build Hadoop-trunk-Commit #11136 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11136/ ) HDFS-10759 . Change fsimage bool isStriped from boolean to an enum. (wang: rev a2a5d7b5bca715835d92816e7b267b59f7270708) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockIdManager.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/proto/fsimage.proto (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFileAttributes.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/FSImageFormatPBSnapshot.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDeadDatanode.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/LocatedBlock.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageReconstructor.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStripedINodeFile.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoContiguous.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockUnderConstructionFeature.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicies.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatPBINode.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImage.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoStriped.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/hdfs.proto (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocolPB/TestPBHelper.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java (add) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/BlockType.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java (add) hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/hdfs/protocol/TestBlockType.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java

            People

            • Assignee:
              ehiggs Ewan Higgs
              Reporter:
              ehiggs Ewan Higgs
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development