Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-23283

Provide clear and consistent logging about the period of enabled chores

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      Similar to HBASE-23038, we should always log info about our enabled chores. Right now wether or not we get some information is up to particular Chore constructors and by and large we don't get any log messages when things can get started, even if the period is something impossibly long (e.g. 3000 days).

      When we go to schedule the chore here:

            if (chore.getPeriod() <= 0) {
              LOG.info("The period is {} seconds, {} is disabled", chore.getPeriod(), chore.getName());
              return false;
            }
      

      we should add an else clause that says it's enabled. It looks like we could then just call chore.toString to get the proper details about the chore and its period.

      Attachments

        1. HBASE-23283.000.patch
          1 kB
          Mingliang Liu

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            liuml07 Mingliang Liu
            busbey Sean Busbey
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment