[HBASE-23283] Provide clear and consistent logging about the period of enabled chores

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.3.0, 1.7.0
• Fix Version/s: 3.0.0-alpha-1, 2.3.0, 1.6.0, 2.1.8, 2.2.3
• Component/s: Operability
• Assignee: Mingliang Liu
• Reporter: Sean Busbey
• Created: 13/Nov/19 03:55
• Updated: 16/Nov/19 03:41
• Resolved: 15/Nov/19 03:17

Description

Similar to HBASE-23038, we should always log info about our enabled chores. Right now wether or not we get some information is up to particular Chore constructors and by and large we don't get any log messages when things can get started, even if the period is something impossibly long (e.g. 3000 days).

When we go to schedule the chore here:

      if (chore.getPeriod() <= 0) {
        LOG.info("The period is {} seconds, {} is disabled", chore.getPeriod(), chore.getName());
        return false;
      }

we should add an else clause that says it's enabled. It looks like we could then just call chore.toString to get the proper details about the chore and its period.