Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-23038

Provide consistent and clear logging about disabling chores

    XMLWordPrintableJSON

    Details

      Description

      Right now if you want to disable any of our chores you can set the period to be <= 0. Sometimes, if you do this you get a nice message:

      2019-09-16 22:10:16,756 INFO  [master-1:16000.activeMasterManager] master.HMaster: The period is 0 seconds, MobCompactionChore is disabled
      

      And sometimes you get an opaque message:

      2019-09-16 22:09:45,333 INFO  [master-1:16000.activeMasterManager] hbase.ChoreService: Could not successfully schedule chore: LogsCleaner
      2019-09-16 22:09:45,340 INFO  [master-1:16000.activeMasterManager] hbase.ChoreService: Could not successfully schedule chore: HFileCleaner
      

      This is because sometimes we just blindly submit to ChoreService which submits to a java ScheduledExecutorService and then catches the IllegalArgumentException.

      We should remove the one-offs and make it so ChoreService checks the period before accepting a submittal and produces a consistent "Foo is disabled" message.

        Attachments

        1. HBASE-23038.master.003.patch
          2 kB
          Sanjeet Nishad
        2. HBASE-23038.002.patch
          1 kB
          Sanjeet Nishad
        3. HBASE-23038.001.patch
          1 kB
          Sanjeet Nishad

          Activity

            People

            • Assignee:
              sanjeetnishad Sanjeet Nishad
              Reporter:
              busbey Sean Busbey
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: