[HBASE-22054] Space Quota: Compaction is not working for super user in case of NO_WRITES_COMPACTIONS

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.2.0, 2.3.0, 2.1.5
• Labels: Quota Space
• Hadoop Flags: Reviewed

Release Note

This change allows the system and superusers to initiate compactions, even when a space quota violation policy disallows compactions from happening. The original intent behind disallowing of compactions was to prevent end-user compactions from creating undue I/O load, not disallowing *any* compaction in the system.

• Assignee: Sakthi
• Reporter: Ajeet Rai
• Created: 15/Mar/19 12:40
• Updated: 01/May/19 07:57
• Resolved: 30/Apr/19 19:07

Description

Space Quota: Compaction is not working for super user. Compaction command is issued successfully at client but actually compaction is not happening.

In debug log below message is printed:

as an active space quota violation policy disallows compaction.
Reference:
https://lists.apache.org/thread.html/d09aa7abaacf1f0be9d59fa9260515ddc0c17ac0aba9cc0f2ac569bf@%3Cuser.hbase.apache.org%3E

Actually in requestCompactionInternal method of  CompactSplit class ,there is no check for super user and compcations are disallowed

  RegionServerSpaceQuotaManager spaceQuotaManager =
        this.server.getRegionServerSpaceQuotaManager();
    if (spaceQuotaManager != null &&
        spaceQuotaManager.areCompactionsDisabled(region.getTableDescriptor().getTableName())) {
      String reason = "Ignoring compaction request for " + region +
          " as an active space quota violation " + " policy disallows compactions.";
      tracker.notExecuted(store, reason);
      completeTracker.completed(store);
      LOG.debug(reason);
      return;
    }