Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-22054

Space Quota: Compaction is not working for super user in case of NO_WRITES_COMPACTIONS

    XMLWordPrintableJSON

Details

    • Reviewed
    • Hide
      This change allows the system and superusers to initiate compactions, even when a space quota violation policy disallows compactions from happening. The original intent behind disallowing of compactions was to prevent end-user compactions from creating undue I/O load, not disallowing *any* compaction in the system.
      Show
      This change allows the system and superusers to initiate compactions, even when a space quota violation policy disallows compactions from happening. The original intent behind disallowing of compactions was to prevent end-user compactions from creating undue I/O load, not disallowing *any* compaction in the system.

    Description

      Space Quota: Compaction is not working for super user. Compaction command is issued successfully at client but actually compaction is not happening.

      In debug log below message is printed:

      as an active space quota violation policy disallows compaction.
      Reference:
      https://lists.apache.org/thread.html/d09aa7abaacf1f0be9d59fa9260515ddc0c17ac0aba9cc0f2ac569bf@%3Cuser.hbase.apache.org%3E

      Actually in requestCompactionInternal method of  CompactSplit class ,there is no check for super user and compcations are disallowed

        RegionServerSpaceQuotaManager spaceQuotaManager =
              this.server.getRegionServerSpaceQuotaManager();
          if (spaceQuotaManager != null &&
              spaceQuotaManager.areCompactionsDisabled(region.getTableDescriptor().getTableName())) {
            String reason = "Ignoring compaction request for " + region +
                " as an active space quota violation " + " policy disallows compactions.";
            tracker.notExecuted(store, reason);
            completeTracker.completed(store);
            LOG.debug(reason);
            return;
          }
      
      

       

      Attachments

        1. hbase-22054.master.001.patch
          7 kB
          Sakthi
        2. hbase-22054.master.002.patch
          9 kB
          Sakthi
        3. hbase-22054.master.003.patch
          9 kB
          Sakthi
        4. hbase-22054.master.004.patch
          10 kB
          Sakthi
        5. hbase-22054.master.005.patch
          11 kB
          Sakthi

        Activity

          People

            sakthi Sakthi
            a00408367 Ajeet Rai
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: