[HBASE-12187] Review in source the paper "Simple Testing Can Prevent Most Critical Failures"

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Implemented
• Assignee: Unassigned
• Reporter: Michael Stack
• Created: 07/Oct/14 15:08
• Updated: 17/Jun/22 17:09
• Resolved: 11/Jun/22 18:58

Description

Review the helpful paper https://www.usenix.org/system/files/conference/osdi14/osdi14-paper-yuan.pdf

It describes 'catastrophic failures', especially issues where exceptions are thrown but not properly handled. Their static analysis tool Aspirator turns up a bunch of the obvious offenders (Lets add to test-patch.sh alongside findbugs?). This issue is about going through code base making sub-issues to root out these and others (Don't we have the test described in figure #6 already? I thought we did? If we don't, need to add).

Issue Links

• relates to: HBASE-11912 Catch some bad practices at compile time with error-prone

Sub-Tasks

• Fix new issues found by coverity static analysis: Closed
• Catch some bad practices at compile time with error-prone: Closed
• Restore incremental compilation: Closed
• Add Maven build support module for a custom version of error-prone: Closed
• Address issues found by error-prone in hbase-common: Closed
• Add Aspirator rules to error-prone: Closed
• Disable error-prone for hbase-protocol-shaded: Closed
• Address issues found by error-prone in hbase-hadoop2-compat: Closed
• Address issues found by error-prone in hbase-client: Closed