Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Component/s: None
    • Labels:
      None

      Description

      Add a new Maven build support module that builds and publishes a custom error-prone artifact for use by the rest of the build.

      1. HBASE-12349.v6.patch
        35 kB
        Mike Drob
      2. HBASE-12349.v5.patch
        34 kB
        Mike Drob
      3. HBASE-12349.v4.patch
        34 kB
        Mike Drob
      4. HBASE-12349.v3.patch
        33 kB
        Mike Drob
      5. HBASE-12349.v2.patch
        41 kB
        Mike Drob
      6. HBASE-12349.patch
        17 kB
        Mike Drob

        Issue Links

          Activity

          Hide
          apurtell Andrew Purtell added a comment -

          Ding Yuan kindly implemented the 'Aspirator' static analysis as a custom error-prone version based on 1.1.2, containing three new bugcheckers, and pushed this to: https://github.com/diy1/error-prone-aspirator

          The original error-prone source distribution was released by Google under the ASL 2.0 (https://code.google.com/p/error-prone/) The custom distribution mentioned above carries it forward (https://github.com/diy1/error-prone-aspirator/blob/master/COPYING)

          Any concerns with importing this wholesale into an HBase build support module?

          Show
          apurtell Andrew Purtell added a comment - Ding Yuan kindly implemented the 'Aspirator' static analysis as a custom error-prone version based on 1.1.2, containing three new bugcheckers, and pushed this to: https://github.com/diy1/error-prone-aspirator The original error-prone source distribution was released by Google under the ASL 2.0 ( https://code.google.com/p/error-prone/ ) The custom distribution mentioned above carries it forward ( https://github.com/diy1/error-prone-aspirator/blob/master/COPYING ) Any concerns with importing this wholesale into an HBase build support module?
          Hide
          apurtell Andrew Purtell added a comment -

          Ping the RM crew: Enis Soztutar Lars Hofhansl stack

          Show
          apurtell Andrew Purtell added a comment - Ping the RM crew: Enis Soztutar Lars Hofhansl stack
          Hide
          apurtell Andrew Purtell added a comment -

          Elliott Clark, we talked before about tucking hbase-checkstyle under a common parent for build support modules, assuming that's still not a problem? (It worked for me previously.)

          Show
          apurtell Andrew Purtell added a comment - Elliott Clark , we talked before about tucking hbase-checkstyle under a common parent for build support modules, assuming that's still not a problem? (It worked for me previously.)
          Hide
          eclark Elliott Clark added a comment -

          No, in fact it's great. Sorry I didn't get to it.

          Show
          eclark Elliott Clark added a comment - No, in fact it's great. Sorry I didn't get to it.
          Hide
          apurtell Andrew Purtell added a comment -

          BTW, another thing I'd like to do with a custom error-prone is add support for disabling certain bugcheckers at the package level, to address https://issues.apache.org/jira/browse/HBASE-11912?focusedCommentId=14176448&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14176448 along with suitably annotated package-info.java files (http://docs.oracle.com/javase/specs/jls/se7/html/jls-7.html#jls-7.4.1) in the protobuf 'generated' packages.

          Show
          apurtell Andrew Purtell added a comment - BTW, another thing I'd like to do with a custom error-prone is add support for disabling certain bugcheckers at the package level, to address https://issues.apache.org/jira/browse/HBASE-11912?focusedCommentId=14176448&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14176448 along with suitably annotated package-info.java files ( http://docs.oracle.com/javase/specs/jls/se7/html/jls-7.html#jls-7.4.1 ) in the protobuf 'generated' packages.
          Hide
          apurtell Andrew Purtell added a comment -

          Actually the above might work today, let me try it. If it works I'll propose the change in a new subtask of the parent of this issue

          Show
          apurtell Andrew Purtell added a comment - Actually the above might work today, let me try it. If it works I'll propose the change in a new subtask of the parent of this issue
          Hide
          lhofhansl Lars Hofhansl added a comment -

          Sounds good to me. I assume 2.0.0 only?
          (At least in 0.94 this would not make much sense)

          Show
          lhofhansl Lars Hofhansl added a comment - Sounds good to me. I assume 2.0.0 only? (At least in 0.94 this would not make much sense)
          Hide
          apurtell Andrew Purtell added a comment -

          It may not be necessary to fork error-prone if we just need to add additional custom bugcheckers. See https://groups.google.com/forum/#!topic/error-prone-discuss/WL-mNWt3R9M

          Show
          apurtell Andrew Purtell added a comment - It may not be necessary to fork error-prone if we just need to add additional custom bugcheckers. See https://groups.google.com/forum/#!topic/error-prone-discuss/WL-mNWt3R9M
          Hide
          apurtell Andrew Purtell added a comment - - edited

          Sounds good to me. I assume 2.0.0 only?

          Depending on how it goes in master, I'd like to eventually port this back to all active branches where we are using a multimodule model, so not 0.94

          Show
          apurtell Andrew Purtell added a comment - - edited Sounds good to me. I assume 2.0.0 only? Depending on how it goes in master, I'd like to eventually port this back to all active branches where we are using a multimodule model, so not 0.94
          Hide
          apurtell Andrew Purtell added a comment -

          add support for disabling certain bugcheckers at the package level [...] along with suitably annotated package-info.java files in the protobuf 'generated' packages ...

          So much for that, the SuppressWarnings annotation type doesn't have a PACKAGE level target, on purpose (and see http://stackoverflow.com/questions/8910759/why-cant-i-suppresswarnings-on-a-package)

          Show
          apurtell Andrew Purtell added a comment - add support for disabling certain bugcheckers at the package level [...] along with suitably annotated package-info.java files in the protobuf 'generated' packages ... So much for that, the SuppressWarnings annotation type doesn't have a PACKAGE level target, on purpose (and see http://stackoverflow.com/questions/8910759/why-cant-i-suppresswarnings-on-a-package )
          Hide
          apurtell Andrew Purtell added a comment - - edited

          Related discussion on enabling or disabling bugcheckers or promoting warnings to errors and vice versa by way of command line: https://groups.google.com/forum/#!topic/error-prone-discuss/v00Vr_pFxJg
          As long as we can set such options from the Maven compiler plugin configuration we should be able to eventually wrap all module compilations with error-prone without changing it such that a fork is necessary. And some of the experimental bugcheckers look useful, would be good to try them out.

          Show
          apurtell Andrew Purtell added a comment - - edited Related discussion on enabling or disabling bugcheckers or promoting warnings to errors and vice versa by way of command line: https://groups.google.com/forum/#!topic/error-prone-discuss/v00Vr_pFxJg As long as we can set such options from the Maven compiler plugin configuration we should be able to eventually wrap all module compilations with error-prone without changing it such that a fork is necessary. And some of the experimental bugcheckers look useful, would be good to try them out.
          Hide
          d.yuan Ding Yuan added a comment -

          Ping. Just checking if the custom error-prone has been integrated? Or if there is anything that I can further help?

          Show
          d.yuan Ding Yuan added a comment - Ping. Just checking if the custom error-prone has been integrated? Or if there is anything that I can further help?
          Hide
          mdrob Mike Drob added a comment -

          This might be easier now:

          Maven
          Starting in version 3.5, maven-compiler-plugin allows the processor path to be configured with the annotationProcessorPaths parameter.

          For a complete example, see: examples/plugin/maven.

          So I think we could add the additional bug checks without needing to fork or publish a custom error-prone version.

          Show
          mdrob Mike Drob added a comment - This might be easier now: Maven Starting in version 3.5, maven-compiler-plugin allows the processor path to be configured with the annotationProcessorPaths parameter. For a complete example, see: examples/plugin/maven . So I think we could add the additional bug checks without needing to fork or publish a custom error-prone version.
          Hide
          apurtell Andrew Purtell added a comment -

          Oh that's great, because packaging up HBase build specific rules into a custom version was basically a nonstarter

          Show
          apurtell Andrew Purtell added a comment - Oh that's great, because packaging up HBase build specific rules into a custom version was basically a nonstarter
          Hide
          mdrob Mike Drob added a comment -

          Was hacking around on this yesterday, it's a little bit tricky because if we create a new module and introduce a top-level dependency for javac on it then that model can't build because of the bootstrapping problem. Haven't figured out how to override that in just the module, I feel like there should be a maven incantation for it but I haven't found it yet.

          Show
          mdrob Mike Drob added a comment - Was hacking around on this yesterday, it's a little bit tricky because if we create a new module and introduce a top-level dependency for javac on it then that model can't build because of the bootstrapping problem. Haven't figured out how to override that in just the module, I feel like there should be a maven incantation for it but I haven't found it yet.
          Hide
          mdrob Mike Drob added a comment -

          Progress update: have some ugly hacks on this.

          I know I'm missing license headers, and have hard-coded plugin version in maven, but I'm almost to a place where this works.

          Big issue now is that compiling protoc goes from ~15s to ~5m which I consider a deal breaker. Maybe not to commit, but to turning error-prone on by default.

          I started to do a few fixups on the code based on errors that were getting reported, but stopped when the protoc issue made the process take way too long.

          Andrew Purtell - care to take a look at what's here so far and provide thoughts?

          Show
          mdrob Mike Drob added a comment - Progress update: have some ugly hacks on this. I know I'm missing license headers, and have hard-coded plugin version in maven, but I'm almost to a place where this works. Big issue now is that compiling protoc goes from ~15s to ~5m which I consider a deal breaker. Maybe not to commit, but to turning error-prone on by default. I started to do a few fixups on the code based on errors that were getting reported, but stopped when the protoc issue made the process take way too long. Andrew Purtell - care to take a look at what's here so far and provide thoughts?
          Hide
          apurtell Andrew Purtell added a comment -

          I don't think we want to do this by default but can turn on under the release profile for RCs and nightlies.

          Show
          apurtell Andrew Purtell added a comment - I don't think we want to do this by default but can turn on under the release profile for RCs and nightlies.
          Hide
          mdrob Mike Drob added a comment -

          Got this into a workable state, finally.

          • Create new hbase-build-support module to hold hbase-error-prone.
            • We need this so that we can separate the compilation configurations to compile our rules using plain javac and compile the rest using javac+rules
            • Eventually, we would move hbase-checkstyle and hbase-resource-bundle into there also, I think.
          • Created hbase-build-configuration module to hold the error-prone profile. Moved all other modules to inherit from it instead of hbase-root.
            • This can have other configurations in it that we don't want affecting the build support modules, but I don't know what they'd be at this point. Even without them, this is kind of clunky but still necessary, I think.
          • While testing this, I ended up fixing a few error-prone bugs to make sure that the results are actually correct. I can back them out and include them separately, but it seems fine to include them. There's still plenty more follow on work to be done.
          • Added a placeholder custom error-prone rule that never fails. Can remove this when we have other rules in place, but I wanted to have some java source available.

          Future work we will want to add @Generated to all of the protoc code, this will speed up error-prone-javac a bit, and also start chopping away the reported errors and then the warnings. There's plenty of work to do, unsure how much is false positives and how much is true, but it's a non zero amount of actual bugs.

          test-patch is very very likely to fail, we'll see if there's something I can iterate on in this patch or wait until the next one.

          Show
          mdrob Mike Drob added a comment - Got this into a workable state, finally. Create new hbase-build-support module to hold hbase-error-prone. We need this so that we can separate the compilation configurations to compile our rules using plain javac and compile the rest using javac+rules Eventually, we would move hbase-checkstyle and hbase-resource-bundle into there also, I think. Created hbase-build-configuration module to hold the error-prone profile. Moved all other modules to inherit from it instead of hbase-root. This can have other configurations in it that we don't want affecting the build support modules, but I don't know what they'd be at this point. Even without them, this is kind of clunky but still necessary, I think. While testing this, I ended up fixing a few error-prone bugs to make sure that the results are actually correct. I can back them out and include them separately, but it seems fine to include them. There's still plenty more follow on work to be done. Added a placeholder custom error-prone rule that never fails. Can remove this when we have other rules in place, but I wanted to have some java source available. Future work we will want to add @Generated to all of the protoc code, this will speed up error-prone-javac a bit, and also start chopping away the reported errors and then the warnings. There's plenty of work to do, unsure how much is false positives and how much is true, but it's a non zero amount of actual bugs. test-patch is very very likely to fail, we'll see if there's something I can iterate on in this patch or wait until the next one.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          0 mvndep 0m 47s Maven dependency ordering for branch
          +1 mvninstall 4m 39s master passed
          +1 compile 13m 5s master passed
          +1 checkstyle 4m 2s master passed
          +1 mvneclipse 8m 20s master passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes .
          -1 findbugs 2m 29s hbase-protocol-shaded in master has 27 extant Findbugs warnings.
          -1 findbugs 3m 24s hbase-server in master has 9 extant Findbugs warnings.
          -1 findbugs 0m 38s hbase-rest in master has 3 extant Findbugs warnings.
          +1 javadoc 6m 57s master passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 11m 58s the patch passed
          +1 compile 11m 18s the patch passed
          +1 javac 11m 18s the patch passed
          +1 checkstyle 3m 49s the patch passed
          +1 mvneclipse 7m 35s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 39s The patch has no ill-formed XML file.
          +1 hadoopcheck 33m 2s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-build-support hbase-build-configuration hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes .
          -1 findbugs 0m 8s hbase-error-prone in the patch failed.
          +1 javadoc 8m 30s the patch passed
          +1 unit 0m 8s hbase-build-support in the patch passed.
          +1 unit 0m 7s hbase-error-prone in the patch passed.
          +1 unit 0m 6s hbase-build-configuration in the patch passed.
          +1 unit 0m 7s hbase-resource-bundle in the patch passed.
          +1 unit 0m 8s hbase-annotations in the patch passed.
          -1 unit 2m 4s hbase-common in the patch failed.
          +1 unit 0m 30s hbase-protocol-shaded in the patch passed.
          +1 unit 0m 9s hbase-metrics-api in the patch passed.
          +1 unit 3m 2s hbase-procedure in the patch passed.
          +1 unit 0m 22s hbase-hadoop-compat in the patch passed.
          +1 unit 0m 15s hbase-metrics in the patch passed.
          +1 unit 0m 27s hbase-hadoop2-compat in the patch passed.
          +1 unit 0m 18s hbase-protocol in the patch passed.
          +1 unit 2m 39s hbase-client in the patch passed.
          +1 unit 0m 26s hbase-prefix-tree in the patch passed.
          -1 unit 103m 49s hbase-server in the patch failed.
          +1 unit 0m 26s hbase-testing-util in the patch passed.
          +1 unit 2m 1s hbase-thrift in the patch passed.
          +1 unit 0m 35s hbase-rsgroup in the patch passed.
          +1 unit 7m 10s hbase-shell in the patch passed.
          +1 unit 2m 0s hbase-endpoint in the patch passed.
          +1 unit 0m 31s hbase-it in the patch passed.
          +1 unit 0m 50s hbase-examples in the patch passed.
          +1 unit 3m 7s hbase-rest in the patch passed.
          +1 unit 0m 25s hbase-external-blockcache in the patch passed.
          +1 unit 4m 50s hbase-spark in the patch passed.
          +1 unit 0m 26s hbase-spark-it in the patch passed.
          +1 unit 0m 28s hbase-assembly in the patch passed.
          +1 unit 0m 26s hbase-shaded in the patch passed.
          +1 unit 1m 34s hbase-archetypes in the patch passed.
          -1 unit 3m 1s root in the patch failed.
          +1 asflicense 10m 5s The patch does not generate ASF License warnings.
          304m 10s



          Reason Tests
          Failed junit tests hadoop.hbase.util.TestConcatenatedLists
            hadoop.hbase.util.TestConcatenatedLists
          Timed out junit tests org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure
            org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure
            org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure
            org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure
            org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure
            org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure
            org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId
            org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
            org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics
            org.apache.hadoop.hbase.master.assignment.TestAssignmentManager
            org.apache.hadoop.hbase.quotas.TestSnapshotQuotaObserverChore
            org.apache.hadoop.hbase.TestHBaseTestingUtility
            org.apache.hadoop.hbase.mapred.TestTableInputFormat
            org.apache.hadoop.hbase.master.TestMasterFileSystemWithWALDir
            org.apache.hadoop.hbase.TestMultiVersions
            org.apache.hadoop.hbase.quotas.TestQuotaStatusRPCs
            org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator
            org.apache.hadoop.hbase.security.access.TestAccessController2
            org.apache.hadoop.hbase.master.TestAssignmentListener
            org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence
            org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster
            org.apache.hadoop.hbase.quotas.TestQuotaTableUtil
            org.apache.hadoop.hbase.client.TestMultiRespectsLimits
            org.apache.hadoop.hbase.master.balancer.TestFavoredStochasticLoadBalancer
            org.apache.hadoop.hbase.quotas.TestRegionSizeUse
            org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService
            org.apache.hadoop.hbase.client.TestMetaWithReplicas
            org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster
            org.apache.hadoop.hbase.master.TestTableStateManager
            org.apache.hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner
            org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
            org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash
            org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService
            org.apache.hadoop.hbase.master.TestSplitLogManager
            org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS
            org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
            org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport
            org.apache.hadoop.hbase.TestClusterBootOrder
            org.apache.hadoop.hbase.master.TestRollingRestart
            org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer
            org.apache.hadoop.hbase.master.TestDistributedLogSplitting
            org.apache.hadoop.hbase.quotas.TestSpaceQuotas
            org.apache.hadoop.hbase.client.TestSplitOrMergeStatus
            org.apache.hadoop.hbase.master.TestMasterShutdown
            org.apache.hadoop.hbase.security.TestSecureIPC
            org.apache.hadoop.hbase.TestJMXListener
            org.apache.hadoop.hbase.master.TestMaster
            org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient
            org.apache.hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient
            org.apache.hadoop.hbase.TestAcidGuarantees
            org.apache.hadoop.hbase.TestGlobalMemStoreSize
            org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL
            org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
            org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes
            org.apache.hadoop.hbase.quotas.TestSpaceQuotasWithSnapshots
            org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString
            org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions
            org.apache.hadoop.hbase.TestInfoServers
            org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication
            org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache
            org.apache.hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths
            org.apache.hadoop.hbase.security.access.TestCellACLs
            org.apache.hadoop.hbase.TestHBaseOnOtherDfsCluster
            org.apache.hadoop.hbase.client.TestFastFail
            org.apache.hadoop.hbase.master.TestRestartCluster
            org.apache.hadoop.hbase.master.procedure.TestProcedureAdmin
            org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports
            org.apache.hadoop.hbase.security.visibility.TestWithDisabledAuthorization
            org.apache.hadoop.hbase.client.TestLeaseRenewal
            org.apache.hadoop.hbase.master.TestWarmupRegion
            org.apache.hadoop.hbase.master.procedure.TestMasterProcedureEvents
            org.apache.hadoop.hbase.security.visibility.TestDefaultScanLabelGeneratorStack
            org.apache.hadoop.hbase.security.access.TestWithDisabledAuthorization
            org.apache.hadoop.hbase.client.TestTableSnapshotScanner
            org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient
            org.apache.hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver
            org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
            org.apache.hadoop.hbase.client.TestFromClientSideNoCodec
            org.apache.hadoop.hbase.master.TestRegionPlacement2
            org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher
            org.apache.hadoop.hbase.quotas.TestQuotaAdmin
            org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedure
            org.apache.hadoop.hbase.master.procedure.TestModifyColumnFamilyProcedure
            org.apache.hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure
            org.apache.hadoop.hbase.master.assignment.TestSplitTableRegionProcedure
            org.apache.hadoop.hbase.client.TestAsyncAdminBuilder
            org.apache.hadoop.hbase.TestPartialResultsFromClientSide
            org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
            org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure
            org.apache.hadoop.hbase.master.procedure.TestModifyNamespaceProcedure
            org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure
            org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure
            org.apache.hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure
            org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat
            org.apache.hadoop.hbase.master.TestMetaShutdownHandler
            org.apache.hadoop.hbase.client.TestUpdateConfiguration
            org.apache.hadoop.hbase.master.procedure.TestTruncateTableProcedure
            org.apache.hadoop.hbase.master.procedure.TestCloneSnapshotProcedure



          Subsystem Report/Notes
          Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37
          JIRA Issue HBASE-12349
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877400/HBASE-12349.v2.patch
          Optional Tests asflicense javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle
          uname Linux 33217a3d9df3 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
          git revision master / 353627b
          Default Java 1.8.0_131
          findbugs v3.1.0-RC3
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7664/artifact/patchprocess/branch-findbugs-hbase-protocol-shaded-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7664/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7664/artifact/patchprocess/branch-findbugs-hbase-rest-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7664/artifact/patchprocess/patch-findbugs-hbase-build-support_hbase-error-prone.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/7664/artifact/patchprocess/patch-unit-hbase-common.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/7664/artifact/patchprocess/patch-unit-hbase-server.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/7664/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7664/testReport/
          modules C: hbase-build-support hbase-build-support/hbase-error-prone hbase-build-configuration hbase-resource-bundle hbase-annotations hbase-common hbase-protocol-shaded hbase-metrics-api hbase-procedure hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-prefix-tree hbase-server hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7664/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. 0 mvndep 0m 47s Maven dependency ordering for branch +1 mvninstall 4m 39s master passed +1 compile 13m 5s master passed +1 checkstyle 4m 2s master passed +1 mvneclipse 8m 20s master passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . -1 findbugs 2m 29s hbase-protocol-shaded in master has 27 extant Findbugs warnings. -1 findbugs 3m 24s hbase-server in master has 9 extant Findbugs warnings. -1 findbugs 0m 38s hbase-rest in master has 3 extant Findbugs warnings. +1 javadoc 6m 57s master passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 11m 58s the patch passed +1 compile 11m 18s the patch passed +1 javac 11m 18s the patch passed +1 checkstyle 3m 49s the patch passed +1 mvneclipse 7m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 39s The patch has no ill-formed XML file. +1 hadoopcheck 33m 2s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-build-support hbase-build-configuration hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . -1 findbugs 0m 8s hbase-error-prone in the patch failed. +1 javadoc 8m 30s the patch passed +1 unit 0m 8s hbase-build-support in the patch passed. +1 unit 0m 7s hbase-error-prone in the patch passed. +1 unit 0m 6s hbase-build-configuration in the patch passed. +1 unit 0m 7s hbase-resource-bundle in the patch passed. +1 unit 0m 8s hbase-annotations in the patch passed. -1 unit 2m 4s hbase-common in the patch failed. +1 unit 0m 30s hbase-protocol-shaded in the patch passed. +1 unit 0m 9s hbase-metrics-api in the patch passed. +1 unit 3m 2s hbase-procedure in the patch passed. +1 unit 0m 22s hbase-hadoop-compat in the patch passed. +1 unit 0m 15s hbase-metrics in the patch passed. +1 unit 0m 27s hbase-hadoop2-compat in the patch passed. +1 unit 0m 18s hbase-protocol in the patch passed. +1 unit 2m 39s hbase-client in the patch passed. +1 unit 0m 26s hbase-prefix-tree in the patch passed. -1 unit 103m 49s hbase-server in the patch failed. +1 unit 0m 26s hbase-testing-util in the patch passed. +1 unit 2m 1s hbase-thrift in the patch passed. +1 unit 0m 35s hbase-rsgroup in the patch passed. +1 unit 7m 10s hbase-shell in the patch passed. +1 unit 2m 0s hbase-endpoint in the patch passed. +1 unit 0m 31s hbase-it in the patch passed. +1 unit 0m 50s hbase-examples in the patch passed. +1 unit 3m 7s hbase-rest in the patch passed. +1 unit 0m 25s hbase-external-blockcache in the patch passed. +1 unit 4m 50s hbase-spark in the patch passed. +1 unit 0m 26s hbase-spark-it in the patch passed. +1 unit 0m 28s hbase-assembly in the patch passed. +1 unit 0m 26s hbase-shaded in the patch passed. +1 unit 1m 34s hbase-archetypes in the patch passed. -1 unit 3m 1s root in the patch failed. +1 asflicense 10m 5s The patch does not generate ASF License warnings. 304m 10s Reason Tests Failed junit tests hadoop.hbase.util.TestConcatenatedLists   hadoop.hbase.util.TestConcatenatedLists Timed out junit tests org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure   org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure   org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure   org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure   org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure   org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure   org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId   org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2   org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics   org.apache.hadoop.hbase.master.assignment.TestAssignmentManager   org.apache.hadoop.hbase.quotas.TestSnapshotQuotaObserverChore   org.apache.hadoop.hbase.TestHBaseTestingUtility   org.apache.hadoop.hbase.mapred.TestTableInputFormat   org.apache.hadoop.hbase.master.TestMasterFileSystemWithWALDir   org.apache.hadoop.hbase.TestMultiVersions   org.apache.hadoop.hbase.quotas.TestQuotaStatusRPCs   org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator   org.apache.hadoop.hbase.security.access.TestAccessController2   org.apache.hadoop.hbase.master.TestAssignmentListener   org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence   org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster   org.apache.hadoop.hbase.quotas.TestQuotaTableUtil   org.apache.hadoop.hbase.client.TestMultiRespectsLimits   org.apache.hadoop.hbase.master.balancer.TestFavoredStochasticLoadBalancer   org.apache.hadoop.hbase.quotas.TestRegionSizeUse   org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService   org.apache.hadoop.hbase.client.TestMetaWithReplicas   org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster   org.apache.hadoop.hbase.master.TestTableStateManager   org.apache.hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner   org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures   org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash   org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService   org.apache.hadoop.hbase.master.TestSplitLogManager   org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS   org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable   org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport   org.apache.hadoop.hbase.TestClusterBootOrder   org.apache.hadoop.hbase.master.TestRollingRestart   org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer   org.apache.hadoop.hbase.master.TestDistributedLogSplitting   org.apache.hadoop.hbase.quotas.TestSpaceQuotas   org.apache.hadoop.hbase.client.TestSplitOrMergeStatus   org.apache.hadoop.hbase.master.TestMasterShutdown   org.apache.hadoop.hbase.security.TestSecureIPC   org.apache.hadoop.hbase.TestJMXListener   org.apache.hadoop.hbase.master.TestMaster   org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient   org.apache.hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient   org.apache.hadoop.hbase.TestAcidGuarantees   org.apache.hadoop.hbase.TestGlobalMemStoreSize   org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL   org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor   org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes   org.apache.hadoop.hbase.quotas.TestSpaceQuotasWithSnapshots   org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString   org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions   org.apache.hadoop.hbase.TestInfoServers   org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication   org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache   org.apache.hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths   org.apache.hadoop.hbase.security.access.TestCellACLs   org.apache.hadoop.hbase.TestHBaseOnOtherDfsCluster   org.apache.hadoop.hbase.client.TestFastFail   org.apache.hadoop.hbase.master.TestRestartCluster   org.apache.hadoop.hbase.master.procedure.TestProcedureAdmin   org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports   org.apache.hadoop.hbase.security.visibility.TestWithDisabledAuthorization   org.apache.hadoop.hbase.client.TestLeaseRenewal   org.apache.hadoop.hbase.master.TestWarmupRegion   org.apache.hadoop.hbase.master.procedure.TestMasterProcedureEvents   org.apache.hadoop.hbase.security.visibility.TestDefaultScanLabelGeneratorStack   org.apache.hadoop.hbase.security.access.TestWithDisabledAuthorization   org.apache.hadoop.hbase.client.TestTableSnapshotScanner   org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient   org.apache.hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver   org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide   org.apache.hadoop.hbase.client.TestFromClientSideNoCodec   org.apache.hadoop.hbase.master.TestRegionPlacement2   org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher   org.apache.hadoop.hbase.quotas.TestQuotaAdmin   org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedure   org.apache.hadoop.hbase.master.procedure.TestModifyColumnFamilyProcedure   org.apache.hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure   org.apache.hadoop.hbase.master.assignment.TestSplitTableRegionProcedure   org.apache.hadoop.hbase.client.TestAsyncAdminBuilder   org.apache.hadoop.hbase.TestPartialResultsFromClientSide   org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas   org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure   org.apache.hadoop.hbase.master.procedure.TestModifyNamespaceProcedure   org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure   org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure   org.apache.hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure   org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat   org.apache.hadoop.hbase.master.TestMetaShutdownHandler   org.apache.hadoop.hbase.client.TestUpdateConfiguration   org.apache.hadoop.hbase.master.procedure.TestTruncateTableProcedure   org.apache.hadoop.hbase.master.procedure.TestCloneSnapshotProcedure Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 JIRA Issue HBASE-12349 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877400/HBASE-12349.v2.patch Optional Tests asflicense javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle uname Linux 33217a3d9df3 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision master / 353627b Default Java 1.8.0_131 findbugs v3.1.0-RC3 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7664/artifact/patchprocess/branch-findbugs-hbase-protocol-shaded-warnings.html findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7664/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7664/artifact/patchprocess/branch-findbugs-hbase-rest-warnings.html findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7664/artifact/patchprocess/patch-findbugs-hbase-build-support_hbase-error-prone.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/7664/artifact/patchprocess/patch-unit-hbase-common.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/7664/artifact/patchprocess/patch-unit-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/7664/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7664/testReport/ modules C: hbase-build-support hbase-build-support/hbase-error-prone hbase-build-configuration hbase-resource-bundle hbase-annotations hbase-common hbase-protocol-shaded hbase-metrics-api hbase-procedure hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-prefix-tree hbase-server hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7664/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          mdrob Mike Drob added a comment -

          v3: Back out changes related to actually fixing the error-prone bugs, so this is purely a packaging and organizational change. error-prone fixes can be tackled in the future.

          Show
          mdrob Mike Drob added a comment - v3: Back out changes related to actually fixing the error-prone bugs, so this is purely a packaging and organizational change. error-prone fixes can be tackled in the future.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 28s Maven dependency ordering for branch
          +1 mvninstall 3m 12s master passed
          +1 compile 10m 20s master passed
          +1 checkstyle 3m 19s master passed
          +1 mvneclipse 6m 50s master passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes .
          -1 findbugs 1m 58s hbase-protocol-shaded in master has 27 extant Findbugs warnings.
          -1 findbugs 2m 39s hbase-server in master has 9 extant Findbugs warnings.
          -1 findbugs 0m 32s hbase-rest in master has 3 extant Findbugs warnings.
          +1 javadoc 6m 58s master passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 11m 14s the patch passed
          +1 compile 12m 25s the patch passed
          +1 javac 12m 25s the patch passed
          +1 checkstyle 4m 9s the patch passed
          +1 mvneclipse 7m 58s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 43s The patch has no ill-formed XML file.
          +1 hadoopcheck 33m 41s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-build-support hbase-build-configuration hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes .
          -1 findbugs 0m 8s hbase-error-prone in the patch failed.
          +1 javadoc 8m 1s the patch passed
          +1 unit 0m 10s hbase-build-support in the patch passed.
          +1 unit 0m 9s hbase-error-prone in the patch passed.
          +1 unit 0m 7s hbase-build-configuration in the patch passed.
          +1 unit 0m 8s hbase-resource-bundle in the patch passed.
          +1 unit 0m 9s hbase-annotations in the patch passed.
          +1 unit 2m 27s hbase-common in the patch passed.
          +1 unit 0m 35s hbase-protocol-shaded in the patch passed.
          +1 unit 0m 11s hbase-metrics-api in the patch passed.
          +1 unit 3m 12s hbase-procedure in the patch passed.
          +1 unit 0m 26s hbase-hadoop-compat in the patch passed.
          +1 unit 0m 19s hbase-metrics in the patch passed.
          +1 unit 0m 34s hbase-hadoop2-compat in the patch passed.
          +1 unit 0m 24s hbase-protocol in the patch passed.
          +1 unit 2m 55s hbase-client in the patch passed.
          +1 unit 0m 30s hbase-prefix-tree in the patch passed.
          +1 unit 129m 31s hbase-server in the patch passed.
          +1 unit 0m 21s hbase-testing-util in the patch passed.
          +1 unit 1m 54s hbase-thrift in the patch passed.
          +1 unit 0m 29s hbase-rsgroup in the patch passed.
          +1 unit 7m 4s hbase-shell in the patch passed.
          +1 unit 1m 51s hbase-endpoint in the patch passed.
          +1 unit 0m 25s hbase-it in the patch passed.
          +1 unit 0m 46s hbase-examples in the patch passed.
          +1 unit 3m 1s hbase-rest in the patch passed.
          +1 unit 0m 20s hbase-external-blockcache in the patch passed.
          +1 unit 4m 42s hbase-spark in the patch passed.
          +1 unit 0m 23s hbase-spark-it in the patch passed.
          +1 unit 0m 22s hbase-assembly in the patch passed.
          +1 unit 0m 21s hbase-shaded in the patch passed.
          +1 unit 1m 25s hbase-archetypes in the patch passed.
          +1 unit 158m 55s root in the patch passed.
          +1 asflicense 7m 37s The patch does not generate ASF License warnings.
          474m 10s



          Subsystem Report/Notes
          Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37
          JIRA Issue HBASE-12349
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877722/HBASE-12349.v3.patch
          Optional Tests asflicense javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle
          uname Linux 6c887d3850b1 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / c423dc7
          Default Java 1.8.0_131
          findbugs v3.1.0-RC3
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7690/artifact/patchprocess/branch-findbugs-hbase-protocol-shaded-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7690/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7690/artifact/patchprocess/branch-findbugs-hbase-rest-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7690/artifact/patchprocess/patch-findbugs-hbase-build-support_hbase-error-prone.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7690/testReport/
          modules C: hbase-build-support hbase-build-support/hbase-error-prone hbase-build-configuration hbase-resource-bundle hbase-annotations hbase-common hbase-protocol-shaded hbase-metrics-api hbase-procedure hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-prefix-tree hbase-server hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7690/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 28s Maven dependency ordering for branch +1 mvninstall 3m 12s master passed +1 compile 10m 20s master passed +1 checkstyle 3m 19s master passed +1 mvneclipse 6m 50s master passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . -1 findbugs 1m 58s hbase-protocol-shaded in master has 27 extant Findbugs warnings. -1 findbugs 2m 39s hbase-server in master has 9 extant Findbugs warnings. -1 findbugs 0m 32s hbase-rest in master has 3 extant Findbugs warnings. +1 javadoc 6m 58s master passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 11m 14s the patch passed +1 compile 12m 25s the patch passed +1 javac 12m 25s the patch passed +1 checkstyle 4m 9s the patch passed +1 mvneclipse 7m 58s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 43s The patch has no ill-formed XML file. +1 hadoopcheck 33m 41s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-build-support hbase-build-configuration hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . -1 findbugs 0m 8s hbase-error-prone in the patch failed. +1 javadoc 8m 1s the patch passed +1 unit 0m 10s hbase-build-support in the patch passed. +1 unit 0m 9s hbase-error-prone in the patch passed. +1 unit 0m 7s hbase-build-configuration in the patch passed. +1 unit 0m 8s hbase-resource-bundle in the patch passed. +1 unit 0m 9s hbase-annotations in the patch passed. +1 unit 2m 27s hbase-common in the patch passed. +1 unit 0m 35s hbase-protocol-shaded in the patch passed. +1 unit 0m 11s hbase-metrics-api in the patch passed. +1 unit 3m 12s hbase-procedure in the patch passed. +1 unit 0m 26s hbase-hadoop-compat in the patch passed. +1 unit 0m 19s hbase-metrics in the patch passed. +1 unit 0m 34s hbase-hadoop2-compat in the patch passed. +1 unit 0m 24s hbase-protocol in the patch passed. +1 unit 2m 55s hbase-client in the patch passed. +1 unit 0m 30s hbase-prefix-tree in the patch passed. +1 unit 129m 31s hbase-server in the patch passed. +1 unit 0m 21s hbase-testing-util in the patch passed. +1 unit 1m 54s hbase-thrift in the patch passed. +1 unit 0m 29s hbase-rsgroup in the patch passed. +1 unit 7m 4s hbase-shell in the patch passed. +1 unit 1m 51s hbase-endpoint in the patch passed. +1 unit 0m 25s hbase-it in the patch passed. +1 unit 0m 46s hbase-examples in the patch passed. +1 unit 3m 1s hbase-rest in the patch passed. +1 unit 0m 20s hbase-external-blockcache in the patch passed. +1 unit 4m 42s hbase-spark in the patch passed. +1 unit 0m 23s hbase-spark-it in the patch passed. +1 unit 0m 22s hbase-assembly in the patch passed. +1 unit 0m 21s hbase-shaded in the patch passed. +1 unit 1m 25s hbase-archetypes in the patch passed. +1 unit 158m 55s root in the patch passed. +1 asflicense 7m 37s The patch does not generate ASF License warnings. 474m 10s Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 JIRA Issue HBASE-12349 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877722/HBASE-12349.v3.patch Optional Tests asflicense javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle uname Linux 6c887d3850b1 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / c423dc7 Default Java 1.8.0_131 findbugs v3.1.0-RC3 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7690/artifact/patchprocess/branch-findbugs-hbase-protocol-shaded-warnings.html findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7690/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7690/artifact/patchprocess/branch-findbugs-hbase-rest-warnings.html findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7690/artifact/patchprocess/patch-findbugs-hbase-build-support_hbase-error-prone.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7690/testReport/ modules C: hbase-build-support hbase-build-support/hbase-error-prone hbase-build-configuration hbase-resource-bundle hbase-annotations hbase-common hbase-protocol-shaded hbase-metrics-api hbase-procedure hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-prefix-tree hbase-server hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7690/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          mdrob Mike Drob added a comment -

          v4: Fix findbugs declaration for new modules.

          Show
          mdrob Mike Drob added a comment - v4: Fix findbugs declaration for new modules.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 18s Maven dependency ordering for branch
          +1 mvninstall 4m 11s master passed
          +1 compile 13m 0s master passed
          +1 checkstyle 3m 59s master passed
          +1 mvneclipse 8m 23s master passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes .
          -1 findbugs 2m 26s hbase-protocol-shaded in master has 27 extant Findbugs warnings.
          -1 findbugs 3m 11s hbase-server in master has 9 extant Findbugs warnings.
          -1 findbugs 0m 39s hbase-rest in master has 3 extant Findbugs warnings.
          +1 javadoc 8m 31s master passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 13m 58s the patch passed
          +1 compile 11m 17s the patch passed
          +1 javac 11m 17s the patch passed
          +1 checkstyle 4m 11s the patch passed
          +1 mvneclipse 7m 22s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 40s The patch has no ill-formed XML file.
          +1 hadoopcheck 31m 4s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-build-support hbase-build-configuration hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes .
          +1 findbugs 18m 52s the patch passed
          +1 javadoc 9m 14s the patch passed
          +1 unit 0m 9s hbase-build-support in the patch passed.
          +1 unit 0m 9s hbase-error-prone in the patch passed.
          +1 unit 0m 6s hbase-build-configuration in the patch passed.
          +1 unit 0m 9s hbase-resource-bundle in the patch passed.
          +1 unit 0m 8s hbase-annotations in the patch passed.
          +1 unit 2m 28s hbase-common in the patch passed.
          +1 unit 0m 37s hbase-protocol-shaded in the patch passed.
          +1 unit 0m 15s hbase-metrics-api in the patch passed.
          +1 unit 3m 21s hbase-procedure in the patch passed.
          +1 unit 0m 25s hbase-hadoop-compat in the patch passed.
          +1 unit 0m 17s hbase-metrics in the patch passed.
          +1 unit 0m 31s hbase-hadoop2-compat in the patch passed.
          +1 unit 0m 22s hbase-protocol in the patch passed.
          +1 unit 3m 2s hbase-client in the patch passed.
          +1 unit 0m 32s hbase-prefix-tree in the patch passed.
          +1 unit 121m 50s hbase-server in the patch passed.
          +1 unit 0m 21s hbase-testing-util in the patch passed.
          +1 unit 1m 49s hbase-thrift in the patch passed.
          +1 unit 0m 29s hbase-rsgroup in the patch passed.
          +1 unit 7m 3s hbase-shell in the patch passed.
          +1 unit 1m 48s hbase-endpoint in the patch passed.
          +1 unit 0m 25s hbase-it in the patch passed.
          +1 unit 0m 45s hbase-examples in the patch passed.
          +1 unit 2m 58s hbase-rest in the patch passed.
          +1 unit 0m 20s hbase-external-blockcache in the patch passed.
          +1 unit 4m 37s hbase-spark in the patch passed.
          +1 unit 0m 23s hbase-spark-it in the patch passed.
          +1 unit 0m 23s hbase-assembly in the patch passed.
          +1 unit 0m 20s hbase-shaded in the patch passed.
          +1 unit 1m 33s hbase-archetypes in the patch passed.
          +1 unit 148m 36s root in the patch passed.
          +1 asflicense 12m 22s The patch does not generate ASF License warnings.
          475m 11s



          Subsystem Report/Notes
          Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:757bf37
          JIRA Issue HBASE-12349
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877806/HBASE-12349.v4.patch
          Optional Tests asflicense javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle
          uname Linux 33dff70fff75 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 56d00f5
          Default Java 1.8.0_131
          findbugs v3.1.0-RC3
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7699/artifact/patchprocess/branch-findbugs-hbase-protocol-shaded-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7699/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7699/artifact/patchprocess/branch-findbugs-hbase-rest-warnings.html
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7699/testReport/
          modules C: hbase-build-support hbase-build-support/hbase-error-prone hbase-build-configuration hbase-resource-bundle hbase-annotations hbase-common hbase-protocol-shaded hbase-metrics-api hbase-procedure hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-prefix-tree hbase-server hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7699/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 4m 11s master passed +1 compile 13m 0s master passed +1 checkstyle 3m 59s master passed +1 mvneclipse 8m 23s master passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . -1 findbugs 2m 26s hbase-protocol-shaded in master has 27 extant Findbugs warnings. -1 findbugs 3m 11s hbase-server in master has 9 extant Findbugs warnings. -1 findbugs 0m 39s hbase-rest in master has 3 extant Findbugs warnings. +1 javadoc 8m 31s master passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 13m 58s the patch passed +1 compile 11m 17s the patch passed +1 javac 11m 17s the patch passed +1 checkstyle 4m 11s the patch passed +1 mvneclipse 7m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 40s The patch has no ill-formed XML file. +1 hadoopcheck 31m 4s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-build-support hbase-build-configuration hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . +1 findbugs 18m 52s the patch passed +1 javadoc 9m 14s the patch passed +1 unit 0m 9s hbase-build-support in the patch passed. +1 unit 0m 9s hbase-error-prone in the patch passed. +1 unit 0m 6s hbase-build-configuration in the patch passed. +1 unit 0m 9s hbase-resource-bundle in the patch passed. +1 unit 0m 8s hbase-annotations in the patch passed. +1 unit 2m 28s hbase-common in the patch passed. +1 unit 0m 37s hbase-protocol-shaded in the patch passed. +1 unit 0m 15s hbase-metrics-api in the patch passed. +1 unit 3m 21s hbase-procedure in the patch passed. +1 unit 0m 25s hbase-hadoop-compat in the patch passed. +1 unit 0m 17s hbase-metrics in the patch passed. +1 unit 0m 31s hbase-hadoop2-compat in the patch passed. +1 unit 0m 22s hbase-protocol in the patch passed. +1 unit 3m 2s hbase-client in the patch passed. +1 unit 0m 32s hbase-prefix-tree in the patch passed. +1 unit 121m 50s hbase-server in the patch passed. +1 unit 0m 21s hbase-testing-util in the patch passed. +1 unit 1m 49s hbase-thrift in the patch passed. +1 unit 0m 29s hbase-rsgroup in the patch passed. +1 unit 7m 3s hbase-shell in the patch passed. +1 unit 1m 48s hbase-endpoint in the patch passed. +1 unit 0m 25s hbase-it in the patch passed. +1 unit 0m 45s hbase-examples in the patch passed. +1 unit 2m 58s hbase-rest in the patch passed. +1 unit 0m 20s hbase-external-blockcache in the patch passed. +1 unit 4m 37s hbase-spark in the patch passed. +1 unit 0m 23s hbase-spark-it in the patch passed. +1 unit 0m 23s hbase-assembly in the patch passed. +1 unit 0m 20s hbase-shaded in the patch passed. +1 unit 1m 33s hbase-archetypes in the patch passed. +1 unit 148m 36s root in the patch passed. +1 asflicense 12m 22s The patch does not generate ASF License warnings. 475m 11s Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:757bf37 JIRA Issue HBASE-12349 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877806/HBASE-12349.v4.patch Optional Tests asflicense javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle uname Linux 33dff70fff75 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 56d00f5 Default Java 1.8.0_131 findbugs v3.1.0-RC3 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7699/artifact/patchprocess/branch-findbugs-hbase-protocol-shaded-warnings.html findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7699/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7699/artifact/patchprocess/branch-findbugs-hbase-rest-warnings.html Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7699/testReport/ modules C: hbase-build-support hbase-build-support/hbase-error-prone hbase-build-configuration hbase-resource-bundle hbase-annotations hbase-common hbase-protocol-shaded hbase-metrics-api hbase-procedure hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-prefix-tree hbase-server hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7699/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          mdrob Mike Drob added a comment -
          Show
          mdrob Mike Drob added a comment - Andrew Purtell - WDYT?
          Hide
          mdrob Mike Drob added a comment -

          Bump.

          Show
          mdrob Mike Drob added a comment - Bump.
          Hide
          apurtell Andrew Purtell added a comment - - edited

          +1

          Skimmed the maven bits. Not a maven guru, I wouldn't know if they'd work unless I tried them, assuming it's been tested. However I do understand how it would work. (Please advise if untested.)

          I see the new 'errorProne' profile enables this, and it's off by default.

          Show
          apurtell Andrew Purtell added a comment - - edited +1 Skimmed the maven bits. Not a maven guru, I wouldn't know if they'd work unless I tried them, assuming it's been tested. However I do understand how it would work. (Please advise if untested.) I see the new 'errorProne' profile enables this, and it's off by default.
          Hide
          mdrob Mike Drob added a comment - - edited

          The 'errorProfile' profile existed before, I'm moving some stuff around for it though. I tested, everything still works with profile disabled. With profile enabled, compilation fails pretty early and we'll need follow on issues to work through the "new" errors.

          Also, it's completely possible that I missed some part of the build whose breakage will become apparent when somebody tries to do an uncommon thing (maybe release time? not sure) but I tried to be as thorough as possible.

          Show
          mdrob Mike Drob added a comment - - edited The 'errorProfile' profile existed before, I'm moving some stuff around for it though. I tested, everything still works with profile disabled. With profile enabled, compilation fails pretty early and we'll need follow on issues to work through the "new" errors. Also, it's completely possible that I missed some part of the build whose breakage will become apparent when somebody tries to do an uncommon thing (maybe release time? not sure) but I tried to be as thorough as possible.
          Hide
          stack stack added a comment -

          This looks interesting Mr Drob. What does a tarball have in it? The jars are hbase-.jar or hbase-build-support-.jar?

          Show
          stack stack added a comment - This looks interesting Mr Drob. What does a tarball have in it? The jars are hbase- .jar or hbase-build-support- .jar?
          Hide
          mdrob Mike Drob added a comment -

          v5: rebased on latest master

          Show
          mdrob Mike Drob added a comment - v5: rebased on latest master
          Hide
          mdrob Mike Drob added a comment -

          Missed your question earlier, stack. The bin tarball doesn't have any hbase-build-support jar in it, it has all the other same things it did before though. The src tarball has the new modules though, and I verified that by building a new assembly from the generated assembly as suggested in the release docs (https://hbase.apache.org/book.html#maven.release)

          Show
          mdrob Mike Drob added a comment - Missed your question earlier, stack . The bin tarball doesn't have any hbase-build-support jar in it, it has all the other same things it did before though. The src tarball has the new modules though, and I verified that by building a new assembly from the generated assembly as suggested in the release docs ( https://hbase.apache.org/book.html#maven.release )
          Hide
          stack stack added a comment -

          Marking as blocker. Almost done...

          Show
          stack stack added a comment - Marking as blocker. Almost done...
          Hide
          busbey Sean Busbey added a comment -

          generated source tarball with:

          $ git clean -xdfff
          $  mvn clean install -DskipTests assembly:single -Dassembly.file=hbase-assembly/src/main/assembly/src.xml -Prelease
          

          Looks like it's got some extra cruft:

          $ mkdir /tmp/hbase_cc0b245_src
          $ tar -C /tmp/hbase_cc0b245_src -xzf hbase-assembly/target/hbase-3.0.0-SNAPSHOT-src.tar.gz 
          $ diff -r . /tmp/hbase_cc0b245_src/hbase-3.0.0-SNAPSHOT/
          Only in .: .git
          Only in .: .gitattributes
          Only in .: .gitignore
          Only in .: .pylintrc
          Only in /tmp/hbase_cc0b245_src/hbase-3.0.0-SNAPSHOT/hbase-build-support/hbase-error-prone: target
          Only in .: hbase-native-client
          Only in /tmp/hbase_cc0b245_src/hbase-3.0.0-SNAPSHOT/hbase-protocol-shaded: dependency-reduced-pom.xml
          

          Some of those have been around awhile, some are new-to-me. I think only the target directory in the hbase-error-prone module is from this patch.

          Show
          busbey Sean Busbey added a comment - generated source tarball with: $ git clean -xdfff $ mvn clean install -DskipTests assembly:single -Dassembly.file=hbase-assembly/src/main/assembly/src.xml -Prelease Looks like it's got some extra cruft: $ mkdir /tmp/hbase_cc0b245_src $ tar -C /tmp/hbase_cc0b245_src -xzf hbase-assembly/target/hbase-3.0.0-SNAPSHOT-src.tar.gz $ diff -r . /tmp/hbase_cc0b245_src/hbase-3.0.0-SNAPSHOT/ Only in .: .git Only in .: .gitattributes Only in .: .gitignore Only in .: .pylintrc Only in /tmp/hbase_cc0b245_src/hbase-3.0.0-SNAPSHOT/hbase-build-support/hbase-error-prone: target Only in .: hbase- native -client Only in /tmp/hbase_cc0b245_src/hbase-3.0.0-SNAPSHOT/hbase-protocol-shaded: dependency-reduced-pom.xml Some of those have been around awhile, some are new-to-me. I think only the target directory in the hbase-error-prone module is from this patch.
          Hide
          busbey Sean Busbey added a comment -

          just a heads up, since I don't want to make this a blocker for the next alpha I may pull the addition of the hbase-build-configuration module into HBASE-17823 if it looks like that's going to land first.

          Show
          busbey Sean Busbey added a comment - just a heads up, since I don't want to make this a blocker for the next alpha I may pull the addition of the hbase-build-configuration module into HBASE-17823 if it looks like that's going to land first.
          Hide
          mdrob Mike Drob added a comment -

          v6.

          So... the reason that the hbase-error-prone/target shows up and something like hbase-shaded-client/target doesn't is because error-prone module is built before the assembly, while shaded-client is built after. Updated the exclude set to **/target/ to capture sub-directories.

          I don't know what is up with hbase-protocol-shaded/dependency-reduced-pom.xml

          Show
          mdrob Mike Drob added a comment - v6. So... the reason that the hbase-error-prone/target shows up and something like hbase-shaded-client/target doesn't is because error-prone module is built before the assembly, while shaded-client is built after. Updated the exclude set to **/target/ to capture sub-directories. I don't know what is up with hbase-protocol-shaded/dependency-reduced-pom.xml
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 18s Maven dependency ordering for branch
          +1 mvninstall 3m 53s master passed
          +1 compile 12m 2s master passed
          +1 checkstyle 3m 27s master passed
          +1 mvneclipse 7m 25s master passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes .
          +1 findbugs 14m 7s master passed
          +1 javadoc 8m 53s master passed
          0 mvndep 0m 21s Maven dependency ordering for patch
          +1 mvninstall 14m 49s the patch passed
          +1 compile 14m 9s the patch passed
          +1 javac 14m 9s the patch passed
          +1 checkstyle 4m 36s the patch passed
          +1 mvneclipse 10m 1s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 58s The patch has no ill-formed XML file.
          +1 hadoopcheck 39m 59s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-build-support hbase-build-configuration hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes .
          +1 findbugs 17m 21s the patch passed
          +1 javadoc 8m 41s the patch passed
          +1 unit 0m 9s hbase-build-support in the patch passed.
          +1 unit 0m 9s hbase-error-prone in the patch passed.
          +1 unit 0m 7s hbase-build-configuration in the patch passed.
          +1 unit 0m 7s hbase-resource-bundle in the patch passed.
          +1 unit 0m 9s hbase-annotations in the patch passed.
          +1 unit 2m 25s hbase-common in the patch passed.
          +1 unit 0m 29s hbase-protocol-shaded in the patch passed.
          +1 unit 0m 11s hbase-metrics-api in the patch passed.
          +1 unit 2m 56s hbase-procedure in the patch passed.
          +1 unit 0m 22s hbase-hadoop-compat in the patch passed.
          +1 unit 0m 16s hbase-metrics in the patch passed.
          +1 unit 0m 26s hbase-hadoop2-compat in the patch passed.
          +1 unit 0m 19s hbase-protocol in the patch passed.
          +1 unit 2m 41s hbase-client in the patch passed.
          +1 unit 0m 31s hbase-prefix-tree in the patch passed.
          -1 unit 116m 36s hbase-server in the patch failed.
          +1 unit 0m 20s hbase-testing-util in the patch passed.
          +1 unit 1m 48s hbase-thrift in the patch passed.
          +1 unit 0m 30s hbase-rsgroup in the patch passed.
          +1 unit 6m 57s hbase-shell in the patch passed.
          +1 unit 1m 48s hbase-endpoint in the patch passed.
          +1 unit 0m 26s hbase-it in the patch passed.
          +1 unit 0m 43s hbase-examples in the patch passed.
          +1 unit 2m 51s hbase-rest in the patch passed.
          +1 unit 0m 19s hbase-external-blockcache in the patch passed.
          +1 unit 3m 54s hbase-spark in the patch passed.
          +1 unit 0m 21s hbase-spark-it in the patch passed.
          +1 unit 0m 22s hbase-assembly in the patch passed.
          +1 unit 0m 20s hbase-shaded in the patch passed.
          +1 unit 1m 33s hbase-archetypes in the patch passed.
          -1 unit 134m 50s root in the patch failed.
          +1 asflicense 7m 16s The patch does not generate ASF License warnings.
          458m 10s



          Reason Tests
          Timed out junit tests org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2
            org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2



          Subsystem Report/Notes
          Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1
          JIRA Issue HBASE-12349
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882916/HBASE-12349.v6.patch
          Optional Tests asflicense javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle
          uname Linux 1da2e3cd06a5 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 70da554
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8200/artifact/patchprocess/patch-unit-hbase-server.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8200/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8200/testReport/
          modules C: hbase-build-support hbase-build-support/hbase-error-prone hbase-build-configuration hbase-resource-bundle hbase-annotations hbase-common hbase-protocol-shaded hbase-metrics-api hbase-procedure hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-prefix-tree hbase-server hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8200/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 3m 53s master passed +1 compile 12m 2s master passed +1 checkstyle 3m 27s master passed +1 mvneclipse 7m 25s master passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . +1 findbugs 14m 7s master passed +1 javadoc 8m 53s master passed 0 mvndep 0m 21s Maven dependency ordering for patch +1 mvninstall 14m 49s the patch passed +1 compile 14m 9s the patch passed +1 javac 14m 9s the patch passed +1 checkstyle 4m 36s the patch passed +1 mvneclipse 10m 1s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 58s The patch has no ill-formed XML file. +1 hadoopcheck 39m 59s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-build-support hbase-build-configuration hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . +1 findbugs 17m 21s the patch passed +1 javadoc 8m 41s the patch passed +1 unit 0m 9s hbase-build-support in the patch passed. +1 unit 0m 9s hbase-error-prone in the patch passed. +1 unit 0m 7s hbase-build-configuration in the patch passed. +1 unit 0m 7s hbase-resource-bundle in the patch passed. +1 unit 0m 9s hbase-annotations in the patch passed. +1 unit 2m 25s hbase-common in the patch passed. +1 unit 0m 29s hbase-protocol-shaded in the patch passed. +1 unit 0m 11s hbase-metrics-api in the patch passed. +1 unit 2m 56s hbase-procedure in the patch passed. +1 unit 0m 22s hbase-hadoop-compat in the patch passed. +1 unit 0m 16s hbase-metrics in the patch passed. +1 unit 0m 26s hbase-hadoop2-compat in the patch passed. +1 unit 0m 19s hbase-protocol in the patch passed. +1 unit 2m 41s hbase-client in the patch passed. +1 unit 0m 31s hbase-prefix-tree in the patch passed. -1 unit 116m 36s hbase-server in the patch failed. +1 unit 0m 20s hbase-testing-util in the patch passed. +1 unit 1m 48s hbase-thrift in the patch passed. +1 unit 0m 30s hbase-rsgroup in the patch passed. +1 unit 6m 57s hbase-shell in the patch passed. +1 unit 1m 48s hbase-endpoint in the patch passed. +1 unit 0m 26s hbase-it in the patch passed. +1 unit 0m 43s hbase-examples in the patch passed. +1 unit 2m 51s hbase-rest in the patch passed. +1 unit 0m 19s hbase-external-blockcache in the patch passed. +1 unit 3m 54s hbase-spark in the patch passed. +1 unit 0m 21s hbase-spark-it in the patch passed. +1 unit 0m 22s hbase-assembly in the patch passed. +1 unit 0m 20s hbase-shaded in the patch passed. +1 unit 1m 33s hbase-archetypes in the patch passed. -1 unit 134m 50s root in the patch failed. +1 asflicense 7m 16s The patch does not generate ASF License warnings. 458m 10s Reason Tests Timed out junit tests org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2   org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 JIRA Issue HBASE-12349 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882916/HBASE-12349.v6.patch Optional Tests asflicense javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle uname Linux 1da2e3cd06a5 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 70da554 Default Java 1.8.0_144 findbugs v3.1.0-RC3 unit https://builds.apache.org/job/PreCommit-HBASE-Build/8200/artifact/patchprocess/patch-unit-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8200/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8200/testReport/ modules C: hbase-build-support hbase-build-support/hbase-error-prone hbase-build-configuration hbase-resource-bundle hbase-annotations hbase-common hbase-protocol-shaded hbase-metrics-api hbase-procedure hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-prefix-tree hbase-server hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8200/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          mdrob Mike Drob added a comment -

          org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 fails locally for me without the patch as well.

          Show
          mdrob Mike Drob added a comment - org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 fails locally for me without the patch as well.
          Hide
          busbey Sean Busbey added a comment -

          mind doing a git bisect and making sure it's tracked?

          +1 on v6

          Show
          busbey Sean Busbey added a comment - mind doing a git bisect and making sure it's tracked? +1 on v6
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 18s Maven dependency ordering for branch
          +1 mvninstall 3m 53s master passed
          +1 compile 11m 38s master passed
          +1 checkstyle 3m 40s master passed
          +1 mvneclipse 7m 41s master passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes .
          +1 findbugs 15m 27s master passed
          +1 javadoc 7m 53s master passed
          0 mvndep 0m 20s Maven dependency ordering for patch
          +1 mvninstall 13m 35s the patch passed
          +1 compile 11m 45s the patch passed
          +1 javac 11m 45s the patch passed
          +1 checkstyle 4m 6s the patch passed
          +1 mvneclipse 8m 9s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 39s The patch has no ill-formed XML file.
          +1 hadoopcheck 33m 47s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-build-support hbase-build-configuration hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes .
          +1 findbugs 18m 6s the patch passed
          +1 javadoc 7m 58s the patch passed
          +1 unit 0m 7s hbase-build-support in the patch passed.
          +1 unit 0m 8s hbase-error-prone in the patch passed.
          +1 unit 0m 6s hbase-build-configuration in the patch passed.
          +1 unit 0m 7s hbase-resource-bundle in the patch passed.
          +1 unit 0m 7s hbase-annotations in the patch passed.
          +1 unit 2m 15s hbase-common in the patch passed.
          +1 unit 0m 27s hbase-protocol-shaded in the patch passed.
          +1 unit 0m 10s hbase-metrics-api in the patch passed.
          +1 unit 3m 0s hbase-procedure in the patch passed.
          +1 unit 0m 23s hbase-hadoop-compat in the patch passed.
          +1 unit 0m 17s hbase-metrics in the patch passed.
          +1 unit 0m 26s hbase-hadoop2-compat in the patch passed.
          +1 unit 0m 19s hbase-protocol in the patch passed.
          +1 unit 2m 30s hbase-client in the patch passed.
          +1 unit 0m 26s hbase-prefix-tree in the patch passed.
          -1 unit 113m 27s hbase-server in the patch failed.
          +1 unit 0m 21s hbase-testing-util in the patch passed.
          +1 unit 1m 53s hbase-thrift in the patch passed.
          +1 unit 0m 29s hbase-rsgroup in the patch passed.
          +1 unit 6m 54s hbase-shell in the patch passed.
          +1 unit 2m 0s hbase-endpoint in the patch passed.
          +1 unit 0m 26s hbase-it in the patch passed.
          +1 unit 0m 43s hbase-examples in the patch passed.
          +1 unit 3m 4s hbase-rest in the patch passed.
          +1 unit 0m 20s hbase-external-blockcache in the patch passed.
          +1 unit 4m 13s hbase-spark in the patch passed.
          +1 unit 0m 21s hbase-spark-it in the patch passed.
          +1 unit 0m 22s hbase-assembly in the patch passed.
          +1 unit 0m 20s hbase-shaded in the patch passed.
          +1 unit 1m 23s hbase-archetypes in the patch passed.
          -1 unit 136m 42s root in the patch failed.
          +1 asflicense 7m 27s The patch does not generate ASF License warnings.
          444m 56s



          Reason Tests
          Timed out junit tests org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2
            org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2



          Subsystem Report/Notes
          Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1
          JIRA Issue HBASE-12349
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882916/HBASE-12349.v6.patch
          Optional Tests asflicense javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle
          uname Linux f67aa20277e4 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 05f07f6
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8231/artifact/patchprocess/patch-unit-hbase-server.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8231/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8231/testReport/
          modules C: hbase-build-support hbase-build-support/hbase-error-prone hbase-build-configuration hbase-resource-bundle hbase-annotations hbase-common hbase-protocol-shaded hbase-metrics-api hbase-procedure hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-prefix-tree hbase-server hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8231/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 3m 53s master passed +1 compile 11m 38s master passed +1 checkstyle 3m 40s master passed +1 mvneclipse 7m 41s master passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . +1 findbugs 15m 27s master passed +1 javadoc 7m 53s master passed 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 13m 35s the patch passed +1 compile 11m 45s the patch passed +1 javac 11m 45s the patch passed +1 checkstyle 4m 6s the patch passed +1 mvneclipse 8m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 39s The patch has no ill-formed XML file. +1 hadoopcheck 33m 47s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. 0 findbugs 0m 0s Skipped patched modules with no Java source: hbase-build-support hbase-build-configuration hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . +1 findbugs 18m 6s the patch passed +1 javadoc 7m 58s the patch passed +1 unit 0m 7s hbase-build-support in the patch passed. +1 unit 0m 8s hbase-error-prone in the patch passed. +1 unit 0m 6s hbase-build-configuration in the patch passed. +1 unit 0m 7s hbase-resource-bundle in the patch passed. +1 unit 0m 7s hbase-annotations in the patch passed. +1 unit 2m 15s hbase-common in the patch passed. +1 unit 0m 27s hbase-protocol-shaded in the patch passed. +1 unit 0m 10s hbase-metrics-api in the patch passed. +1 unit 3m 0s hbase-procedure in the patch passed. +1 unit 0m 23s hbase-hadoop-compat in the patch passed. +1 unit 0m 17s hbase-metrics in the patch passed. +1 unit 0m 26s hbase-hadoop2-compat in the patch passed. +1 unit 0m 19s hbase-protocol in the patch passed. +1 unit 2m 30s hbase-client in the patch passed. +1 unit 0m 26s hbase-prefix-tree in the patch passed. -1 unit 113m 27s hbase-server in the patch failed. +1 unit 0m 21s hbase-testing-util in the patch passed. +1 unit 1m 53s hbase-thrift in the patch passed. +1 unit 0m 29s hbase-rsgroup in the patch passed. +1 unit 6m 54s hbase-shell in the patch passed. +1 unit 2m 0s hbase-endpoint in the patch passed. +1 unit 0m 26s hbase-it in the patch passed. +1 unit 0m 43s hbase-examples in the patch passed. +1 unit 3m 4s hbase-rest in the patch passed. +1 unit 0m 20s hbase-external-blockcache in the patch passed. +1 unit 4m 13s hbase-spark in the patch passed. +1 unit 0m 21s hbase-spark-it in the patch passed. +1 unit 0m 22s hbase-assembly in the patch passed. +1 unit 0m 20s hbase-shaded in the patch passed. +1 unit 1m 23s hbase-archetypes in the patch passed. -1 unit 136m 42s root in the patch failed. +1 asflicense 7m 27s The patch does not generate ASF License warnings. 444m 56s Reason Tests Timed out junit tests org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2   org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 JIRA Issue HBASE-12349 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882916/HBASE-12349.v6.patch Optional Tests asflicense javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle uname Linux f67aa20277e4 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 05f07f6 Default Java 1.8.0_144 findbugs v3.1.0-RC3 unit https://builds.apache.org/job/PreCommit-HBASE-Build/8231/artifact/patchprocess/patch-unit-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8231/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8231/testReport/ modules C: hbase-build-support hbase-build-support/hbase-error-prone hbase-build-configuration hbase-resource-bundle hbase-annotations hbase-common hbase-protocol-shaded hbase-metrics-api hbase-procedure hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-prefix-tree hbase-server hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8231/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          mdrob Mike Drob added a comment -
          Show
          mdrob Mike Drob added a comment - Sean Busbey - Filed HBASE-18655 .
          Hide
          mdrob Mike Drob added a comment -

          Pushed to master. I don't think we need this on the older branches since we'll probably end up backporting the individual fixes anyway.

          Show
          mdrob Mike Drob added a comment - Pushed to master. I don't think we need this on the older branches since we'll probably end up backporting the individual fixes anyway.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3580 (See https://builds.apache.org/job/HBase-Trunk_matrix/3580/)
          HBASE-12349 Add custom error-prone module (mdrob: rev 51d458872d703acdd853dd7b3149794d585ba285)

          • (edit) hbase-common/pom.xml
          • (add) hbase-build-support/hbase-error-prone/pom.xml
          • (edit) hbase-external-blockcache/pom.xml
          • (edit) hbase-resource-bundle/pom.xml
          • (edit) hbase-client/pom.xml
          • (edit) hbase-shaded/pom.xml
          • (edit) hbase-spark-it/pom.xml
          • (edit) hbase-testing-util/pom.xml
          • (add) hbase-build-support/pom.xml
          • (edit) hbase-rsgroup/pom.xml
          • (edit) hbase-rest/pom.xml
          • (edit) hbase-spark/pom.xml
          • (edit) hbase-examples/pom.xml
          • (edit) hbase-hadoop-compat/pom.xml
          • (edit) hbase-thrift/pom.xml
          • (edit) hbase-prefix-tree/pom.xml
          • (edit) hbase-endpoint/pom.xml
          • (edit) hbase-protocol-shaded/pom.xml
          • (edit) hbase-server/pom.xml
          • (edit) hbase-assembly/pom.xml
          • (edit) hbase-hadoop2-compat/pom.xml
          • (add) hbase-build-support/hbase-error-prone/src/main/java/org/apache/hadoop/hbase/errorprone/AlwaysPasses.java
          • (edit) hbase-protocol/pom.xml
          • (edit) hbase-shell/pom.xml
          • (edit) hbase-annotations/pom.xml
          • (edit) pom.xml
          • (edit) hbase-procedure/pom.xml
          • (add) hbase-build-configuration/pom.xml
          • (edit) hbase-it/pom.xml
          • (edit) hbase-metrics/pom.xml
          • (edit) hbase-assembly/src/main/assembly/src.xml
          • (edit) hbase-metrics-api/pom.xml
          • (edit) hbase-archetypes/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3580 (See https://builds.apache.org/job/HBase-Trunk_matrix/3580/ ) HBASE-12349 Add custom error-prone module (mdrob: rev 51d458872d703acdd853dd7b3149794d585ba285) (edit) hbase-common/pom.xml (add) hbase-build-support/hbase-error-prone/pom.xml (edit) hbase-external-blockcache/pom.xml (edit) hbase-resource-bundle/pom.xml (edit) hbase-client/pom.xml (edit) hbase-shaded/pom.xml (edit) hbase-spark-it/pom.xml (edit) hbase-testing-util/pom.xml (add) hbase-build-support/pom.xml (edit) hbase-rsgroup/pom.xml (edit) hbase-rest/pom.xml (edit) hbase-spark/pom.xml (edit) hbase-examples/pom.xml (edit) hbase-hadoop-compat/pom.xml (edit) hbase-thrift/pom.xml (edit) hbase-prefix-tree/pom.xml (edit) hbase-endpoint/pom.xml (edit) hbase-protocol-shaded/pom.xml (edit) hbase-server/pom.xml (edit) hbase-assembly/pom.xml (edit) hbase-hadoop2-compat/pom.xml (add) hbase-build-support/hbase-error-prone/src/main/java/org/apache/hadoop/hbase/errorprone/AlwaysPasses.java (edit) hbase-protocol/pom.xml (edit) hbase-shell/pom.xml (edit) hbase-annotations/pom.xml (edit) pom.xml (edit) hbase-procedure/pom.xml (add) hbase-build-configuration/pom.xml (edit) hbase-it/pom.xml (edit) hbase-metrics/pom.xml (edit) hbase-assembly/src/main/assembly/src.xml (edit) hbase-metrics-api/pom.xml (edit) hbase-archetypes/pom.xml

            People

            • Assignee:
              mdrob Mike Drob
              Reporter:
              apurtell Andrew Purtell
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development