[HBASE-11912] Catch some bad practices at compile time with error-prone

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Hadoop Flags: Reviewed
• Release Note: Errors from error-prone will fail the build in the compile phase. Warnings look like Javac warnings and are counted as such by test-patch etc
• Assignee: Andrew Purtell
• Reporter: Andrew Purtell
• Created: 08/Sep/14 17:24
• Updated: 27/Oct/14 20:29
• Resolved: 27/Oct/14 16:51

Description

Google's error-prone (https://code.google.com/p/error-prone/) wraps javac with some additional static analysis that will generate additional warnings or errors at compile time if certain bug patterns (https://code.google.com/p/error-prone/wiki/BugPatterns) are detected. What's nice about this approach, as opposed to findbugs, is the compile time detection and erroring out prevent the detected problems from getting into the codebase up front.

Issue Links

• is related to: HBASE-12187 Review in source the paper "Simple Testing Can Prevent Most Critical Failures"
• is related to: HBASE-12237 HBaseZeroCopyByteString#wrap() should not be called in hbase-client code