Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-10462 Recategorize some of the client facing Public / Private interfaces
  3. HBASE-11318

Classes in security subpackages missing @InterfaceAudience annotations.

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.99.0, 0.96.1.1, 0.98.3
    • 0.99.0, 0.98.5
    • security
    • None
    • Reviewed

    Description

      I was reading some of the security related code and noticed that many of the security related classes lack @InterfaceAudience markings.

      WIth the current api I believe all but Permission should be Private. With the introduction of cell level ACL's Permission must be public because it is now exposed in the Mutation setACL calls[1].

      There is an inconsistency with the Mutation ACL – the acl setters take Permission instances but the getter returns byte[]'s. As a follow on issue we could change the signature of Mutation.setACL so we don't have to expose the Permission class and convert it to be byte[], or change the getter to return an exposed Permission instance.

      [1] http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/Mutation.html#setACL(java.util.Map)

      Attachments

        1. HBASE-11318_v2.patch
          30 kB
          Andrew Kyle Purtell
        2. hbase-11318.patch
          25 kB
          Jonathan Hsieh

        Issue Links

          Activity

            People

              apurtell Andrew Kyle Purtell
              jmhsieh Jonathan Hsieh
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: