HBase
  1. HBase
  2. HBASE-10462 Recategorize some of the client facing Public / Private interfaces
  3. HBASE-10671

Add missing InterfaceAudience annotations for classes in hbase-common and hbase-client modules

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0, 0.99.2
    • Component/s: Client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In this jira, we'll add missing InterfaceAudience annotations to classes in the client visible modules (hbase-client and hbase-common).

      Parent jira is for deciding on whether some of the classes should be private or public.

      1. hbase-10671_v1.patch
        50 kB
        Enis Soztutar
      2. hbase-10671_v2.patch
        51 kB
        Enis Soztutar
      3. hbase-10671_v3.patch
        93 kB
        Enis Soztutar
      4. hbase-10671_v4.patch
        93 kB
        Enis Soztutar
      5. hbase-10671_v6.patch
        94 kB
        Enis Soztutar
      6. hbase-10671_v6-0.99.patch
        91 kB
        Enis Soztutar

        Issue Links

          Activity

          Hide
          Enis Soztutar added a comment -

          Here is a patch which adds missing annotations to a lot of classes.

          Overview is:

          • These classes are marked with @InterfaceAudience.Private
            public class DelegatingRetryingCallable<T, D extends RetryingCallable<T>> implements
               public static class ThrowableWithExtraContext {
               public RetriesExhaustedException(final int numTries,
             public class RpcRetryingCallerFactory {
             public class ServerRpcController implements RpcController {
             public class TimeLimitedRpcController implements RpcController {
             public final class ProtobufUtil {
             public class ReplicationFactory {
             public class ReplicationPeersZKImpl extends ReplicationStateZKBase implements ReplicationPeers {
             public class ReplicationQueueInfo {
             public interface ReplicationQueuesClient {
             public class ReplicationQueuesClientZKImpl extends ReplicationStateZKBase implements
             public class ReplicationQueuesZKImpl extends ReplicationStateZKBase implements ReplicationQueues {
             public abstract class ReplicationStateZKBase {
             public class ReplicationTrackerZKImpl extends ReplicationStateZKBase implements ReplicationTracker {
             public enum AuthMethod {
             public class HBaseSaslRpcClient {
             public enum SaslStatus {
             public class SaslUtil {
             public class SecureBulkLoadUtil {
             public class SecurityInfo {
             public class AuthenticationTokenIdentifier extends TokenIdentifier {
             public class AuthenticationTokenSelector
             public class BaseConfigurable implements Configurable {
               public enum OperationStatusCode {
               public static enum Modify {
             public @interface MetaMutationAnnotation {
             public final class LimitInputStream extends FilterInputStream {
             public class UserProvider extends BaseConfigurable {
             public class Base64 {
             public class ChecksumFactory {
             public enum ChecksumType {
             public class ConcatenatedLists<T> implements Collection<T> {
             public class ExceptionUtil {
             public class ChecksumUtil {
            
          • These classes are marked @InterfaceAudience.Public and @InterfaceStability.Evolving
            public class UnknownProtocolException extends org.apache.hadoop.hbase.DoNotRetryIOException {
             public class Permission extends VersionedWritable {
               public enum Action {
             public class TablePermission extends Permission {
             public class UserPermission extends TablePermission {
               public static class Builder {
               public static class Context extends org.apache.hadoop.hbase.io.crypto.Context {
            
          • These classes are marked @InterfaceAudience.Public and @InterfaceStability.Stable
             public class FailedSanityCheckException extends org.apache.hadoop.hbase.DoNotRetryIOException {
             public class LockTimeoutException extends DoNotRetryIOException {
               public static class Comparator extends WritableComparator {
             public class MurmurHash3 extends Hash {
            
          Show
          Enis Soztutar added a comment - Here is a patch which adds missing annotations to a lot of classes. Overview is: These classes are marked with @InterfaceAudience.Private public class DelegatingRetryingCallable<T, D extends RetryingCallable<T>> implements public static class ThrowableWithExtraContext { public RetriesExhaustedException( final int numTries, public class RpcRetryingCallerFactory { public class ServerRpcController implements RpcController { public class TimeLimitedRpcController implements RpcController { public final class ProtobufUtil { public class ReplicationFactory { public class ReplicationPeersZKImpl extends ReplicationStateZKBase implements ReplicationPeers { public class ReplicationQueueInfo { public interface ReplicationQueuesClient { public class ReplicationQueuesClientZKImpl extends ReplicationStateZKBase implements public class ReplicationQueuesZKImpl extends ReplicationStateZKBase implements ReplicationQueues { public abstract class ReplicationStateZKBase { public class ReplicationTrackerZKImpl extends ReplicationStateZKBase implements ReplicationTracker { public enum AuthMethod { public class HBaseSaslRpcClient { public enum SaslStatus { public class SaslUtil { public class SecureBulkLoadUtil { public class SecurityInfo { public class AuthenticationTokenIdentifier extends TokenIdentifier { public class AuthenticationTokenSelector public class BaseConfigurable implements Configurable { public enum OperationStatusCode { public static enum Modify { public @ interface MetaMutationAnnotation { public final class LimitInputStream extends FilterInputStream { public class UserProvider extends BaseConfigurable { public class Base64 { public class ChecksumFactory { public enum ChecksumType { public class ConcatenatedLists<T> implements Collection<T> { public class ExceptionUtil { public class ChecksumUtil { These classes are marked @InterfaceAudience.Public and @InterfaceStability.Evolving public class UnknownProtocolException extends org.apache.hadoop.hbase.DoNotRetryIOException { public class Permission extends VersionedWritable { public enum Action { public class TablePermission extends Permission { public class UserPermission extends TablePermission { public static class Builder { public static class Context extends org.apache.hadoop.hbase.io.crypto.Context { These classes are marked @InterfaceAudience.Public and @InterfaceStability.Stable public class FailedSanityCheckException extends org.apache.hadoop.hbase.DoNotRetryIOException { public class LockTimeoutException extends DoNotRetryIOException { public static class Comparator extends WritableComparator { public class MurmurHash3 extends Hash {
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12632571/hbase-10671_v1.patch
          against trunk revision .
          ATTACHMENT ID: 12632571

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8884//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632571/hbase-10671_v1.patch against trunk revision . ATTACHMENT ID: 12632571 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8884//console This message is automatically generated.
          Hide
          Enis Soztutar added a comment -

          rebased patch

          Show
          Enis Soztutar added a comment - rebased patch
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12632685/hbase-10671_v2.patch
          against trunk revision .
          ATTACHMENT ID: 12632685

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 hadoop1.0. The patch failed to compile against the hadoop 1.0 profile.
          Here is snippet of errors:

          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project hbase-common: Compilation failure: Compilation failure:
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:[51,15] sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:[1110,19] sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:[1116,21] sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:[1121,28] sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ExceptionUtil.java:[44,64] cannot find symbol
          --
          org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project hbase-common: Compilation failure
          	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
          	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
          	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
          	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
          	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
          --
          Caused by: org.apache.maven.plugin.CompilationFailureException: Compilation failure
          	at org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:729)
          	at org.apache.maven.plugin.CompilerMojo.execute(CompilerMojo.java:128)
          	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
          	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
          	... 19 more

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8885//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632685/hbase-10671_v2.patch against trunk revision . ATTACHMENT ID: 12632685 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 hadoop1.0 . The patch failed to compile against the hadoop 1.0 profile. Here is snippet of errors: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile ( default -compile) on project hbase-common: Compilation failure: Compilation failure: [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:[51,15] sun.misc.Unsafe is Sun proprietary API and may be removed in a future release [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:[1110,19] sun.misc.Unsafe is Sun proprietary API and may be removed in a future release [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:[1116,21] sun.misc.Unsafe is Sun proprietary API and may be removed in a future release [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:[1121,28] sun.misc.Unsafe is Sun proprietary API and may be removed in a future release [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ExceptionUtil.java:[44,64] cannot find symbol -- org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile ( default -compile) on project hbase-common: Compilation failure at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) -- Caused by: org.apache.maven.plugin.CompilationFailureException: Compilation failure at org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:729) at org.apache.maven.plugin.CompilerMojo.execute(CompilerMojo.java:128) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) ... 19 more Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8885//console This message is automatically generated.
          Hide
          Jonathan Hsieh added a comment -

          I think the a subset of the Replication related classes should be marked @IntefaceAudience.LimitedPrivate("Replication"). This would give at the least some easier to release note mechanism for external replication dependecies like lily.

          HBASE-11318 inadvertantly took a hunk the security related classes and assigned some suggested audience settings and opened a little discussion there. Would it be ok to commit the security related pieces there so one of the security experts can review it? Also similarly maybe we should break off the replication related pieces so Jean-Daniel Cryans can review?

          Show
          Jonathan Hsieh added a comment - I think the a subset of the Replication related classes should be marked @IntefaceAudience.LimitedPrivate("Replication"). This would give at the least some easier to release note mechanism for external replication dependecies like lily. HBASE-11318 inadvertantly took a hunk the security related classes and assigned some suggested audience settings and opened a little discussion there. Would it be ok to commit the security related pieces there so one of the security experts can review it? Also similarly maybe we should break off the replication related pieces so Jean-Daniel Cryans can review?
          Hide
          Enis Soztutar added a comment -

          I think the a subset of the Replication related classes should be marked @IntefaceAudience.LimitedPrivate("Replication")

          I am doing this in issue HBASE-10504. The patch there introduces this, but I am doing a major refactoring there as well. I'll upload the patch soon.

          Also similarly maybe we should break off the replication related pieces so Jean-Daniel Cryans can review?

          That would be good.

          Show
          Enis Soztutar added a comment - I think the a subset of the Replication related classes should be marked @IntefaceAudience.LimitedPrivate("Replication") I am doing this in issue HBASE-10504 . The patch there introduces this, but I am doing a major refactoring there as well. I'll upload the patch soon. Also similarly maybe we should break off the replication related pieces so Jean-Daniel Cryans can review? That would be good.
          Hide
          Sean Busbey added a comment -

          We don't have any InterfaceAudience annotation on hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java. It should probably be Public.

          HBaseAdmin in hadoop-client should probably be marked deprecated for branch-1 so that we can transition clients to just using Admin in 2.0.

          Show
          Sean Busbey added a comment - We don't have any InterfaceAudience annotation on hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java. It should probably be Public. HBaseAdmin in hadoop-client should probably be marked deprecated for branch-1 so that we can transition clients to just using Admin in 2.0.
          Hide
          Enis Soztutar added a comment -

          We don't have any InterfaceAudience annotation on hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java. It should probably be Public.

          Yes, public evolving.

          HBaseAdmin in hadoop-client should probably be marked deprecated for branch-1 so that we can transition clients to just using Admin in 2.0.

          Not sure about deprecating HBaseAdmin. The class itself is not going away. Just that it will be an internal private class. Not sure how to approach that cleanly. We have the same issue with HTable/Table, and I did deprecate the HTable constructors used by Client side so that construction of the object was deprecated (see HBASE-10602).

          Show
          Enis Soztutar added a comment - We don't have any InterfaceAudience annotation on hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java. It should probably be Public. Yes, public evolving. HBaseAdmin in hadoop-client should probably be marked deprecated for branch-1 so that we can transition clients to just using Admin in 2.0. Not sure about deprecating HBaseAdmin. The class itself is not going away. Just that it will be an internal private class. Not sure how to approach that cleanly. We have the same issue with HTable/Table, and I did deprecate the HTable constructors used by Client side so that construction of the object was deprecated (see HBASE-10602 ).
          Hide
          Sean Busbey added a comment -

          Right, but since the audience is going to change to private it is going away as far as downstream users are concerned. The deprecation note simply needs to state that it will change to private in the next major release and that users should rely on the Admin interface.

          Show
          Sean Busbey added a comment - Right, but since the audience is going to change to private it is going away as far as downstream users are concerned. The deprecation note simply needs to state that it will change to private in the next major release and that users should rely on the Admin interface.
          Hide
          stack added a comment -

          Sean Busbey Sounds good to me. Lets get it in.

          Show
          stack added a comment - Sean Busbey Sounds good to me. Lets get it in.
          Hide
          Enis Soztutar added a comment -

          Bringing this issue back to life. Attaching updated patch v3, which fixes recent cases as well.

          • Added a unit test which tests all classes in hbase-client (and all dependent submodules, hbase-protocol, hbase-common, etc) to have the annotation. Specifically, it ensures that all classes (except test, generated and non-public) MUST be annotated by InterfaceAudience and for InterfaceAudience.Public classes, it should also contain InterfaceStability.
          • Added hbase-annotations dependency to hbase-protocol
          • Moved some hadoop-annotated classes to hbase-annotated classes (import org.apache.hadoop.classification.InterfaceAudience vs import org.apache.hadoop.hbase.classification.InterfaceAudience)
          • Added some more annotations to missing classes.
          Show
          Enis Soztutar added a comment - Bringing this issue back to life. Attaching updated patch v3, which fixes recent cases as well. Added a unit test which tests all classes in hbase-client (and all dependent submodules, hbase-protocol, hbase-common, etc) to have the annotation. Specifically, it ensures that all classes (except test, generated and non-public) MUST be annotated by InterfaceAudience and for InterfaceAudience.Public classes, it should also contain InterfaceStability. Added hbase-annotations dependency to hbase-protocol Moved some hadoop-annotated classes to hbase-annotated classes (import org.apache.hadoop.classification.InterfaceAudience vs import org.apache.hadoop.hbase.classification.InterfaceAudience) Added some more annotations to missing classes.
          Hide
          Enis Soztutar added a comment -

          Put up the patch for review here: https://reviews.apache.org/r/28276/. Please review carefully.

          Show
          Enis Soztutar added a comment - Put up the patch for review here: https://reviews.apache.org/r/28276/ . Please review carefully.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12682572/hbase-10671_v3.patch
          against master branch at commit b6dd9b441fb279bbd7b6c48d809166b2b0235514.
          ATTACHMENT ID: 12682572

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12682572/hbase-10671_v3.patch against master branch at commit b6dd9b441fb279bbd7b6c48d809166b2b0235514. ATTACHMENT ID: 12682572 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 5 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11759//console This message is automatically generated.
          Hide
          stack added a comment -

          Looks great Enis Soztutar

          What is reasoning that has RetriesExhaustedException private yet RowTooBigException public? Ditto QuotaExceededException and ThrottlingException

          In PreemptiveFastFailException you add imports but do not mark the class?

          This is an interesting one on protobufutil...

          @InterfaceAudience.Private // TODO: some clients (Hive, etc) use this class

          We need to be able to evolve this class. I suppose we'll just have the conversation w/ the hive crew when the time comes. Agree keeping it private is the way to go.

          Base64 is private because? Its general utility? You thinking folks should go elsewhere for this kinda thing? Or you want to remove it (Do we use it anywhere other than in tooling?)

          Thats a fancy-pants test. Nice.

          +1

          Show
          stack added a comment - Looks great Enis Soztutar What is reasoning that has RetriesExhaustedException private yet RowTooBigException public? Ditto QuotaExceededException and ThrottlingException In PreemptiveFastFailException you add imports but do not mark the class? This is an interesting one on protobufutil... @InterfaceAudience.Private // TODO: some clients (Hive, etc) use this class We need to be able to evolve this class. I suppose we'll just have the conversation w/ the hive crew when the time comes. Agree keeping it private is the way to go. Base64 is private because? Its general utility? You thinking folks should go elsewhere for this kinda thing? Or you want to remove it (Do we use it anywhere other than in tooling?) Thats a fancy-pants test. Nice. +1
          Hide
          Enis Soztutar added a comment -

          What is reasoning that has RetriesExhaustedException private yet RowTooBigException public? Ditto QuotaExceededException and ThrottlingException

          Yeah exceptions are hard. I though some clients maybe catching those exceptions, so we cannot rename them for example. But I am not sure what exceptions should be catchable, and what others are not. let me make these Public, since it seems even the base HBaseIOException is Public.

          In PreemptiveFastFailException you add imports but do not mark the class?

          For PreemptiveFastFailException and some others, the annotation was there, but it was using the hadoop package, not the hbase package.

          Base64 is private because? Its general utility? You thinking folks should go elsewhere for this kinda thing? Or you want to remove it (Do we use it anywhere other than in tooling?)

          I though that it is only used internally. But if useful to clients, it should be ok to do Public. The new patch changes that.

          Show
          Enis Soztutar added a comment - What is reasoning that has RetriesExhaustedException private yet RowTooBigException public? Ditto QuotaExceededException and ThrottlingException Yeah exceptions are hard. I though some clients maybe catching those exceptions, so we cannot rename them for example. But I am not sure what exceptions should be catchable, and what others are not. let me make these Public, since it seems even the base HBaseIOException is Public. In PreemptiveFastFailException you add imports but do not mark the class? For PreemptiveFastFailException and some others, the annotation was there, but it was using the hadoop package, not the hbase package. Base64 is private because? Its general utility? You thinking folks should go elsewhere for this kinda thing? Or you want to remove it (Do we use it anywhere other than in tooling?) I though that it is only used internally. But if useful to clients, it should be ok to do Public. The new patch changes that.
          Hide
          Enis Soztutar added a comment -

          New patch addresses Stack's review. Will commit this one unless objection.

          Show
          Enis Soztutar added a comment - New patch addresses Stack's review. Will commit this one unless objection.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12682807/hbase-10671_v4.patch
          against master branch at commit c5690b1be3ae84efa52ee3c4589248c447e12f3f.
          ATTACHMENT ID: 12682807

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12682807/hbase-10671_v4.patch against master branch at commit c5690b1be3ae84efa52ee3c4589248c447e12f3f. ATTACHMENT ID: 12682807 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 5 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11769//console This message is automatically generated.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5809 (See https://builds.apache.org/job/HBase-TRUNK/5809/)
          HBASE-10671 Add missing InterfaceAudience annotations for classes in hbase-common and hbase-client modules (enis: rev 882324dbcc224072be6a43a74aa6102637e529f8)

          • hbase-common/src/main/java/org/apache/hadoop/hbase/NamespaceDescriptor.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/PreemptiveFastFailException.java
          • hbase-common/src/test/java/org/apache/hadoop/hbase/ClassFinder.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/ReadOnlyByteRangeException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableMultiplexer.java
          • hbase-annotations/src/main/java/org/apache/hadoop/hbase/classification/tools/IncludePublicAnnotationsStandardDoclet.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/BoundedCompletionService.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/UnknownProtocolException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ConnectionClosingException.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/SimpleByteRange.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/LockTimeoutException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClientZKImpl.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityControllerNotReadyException.java
          • hbase-protocol/pom.xml
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/IPCUtil.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/ExceptionUtil.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/Base64.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RowTooBigException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/InvalidQuotaSettingsException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/UserPermission.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/types/PBType.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueueInfo.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaExceededException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/Permission.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Batch.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesZKImpl.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/AbstractPositionedByteRange.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/ConcatenatedLists.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/KeepDeletedCells.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RegexStringComparator.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionAdminServiceCallable.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenIdentifier.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcControllerFactory.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTrackerZKImpl.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/TestInterfaceAudienceAnnotations.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/FailureInfo.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/ChecksumType.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/DelegatingRetryingCallable.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
          • hbase-annotations/src/main/java/org/apache/hadoop/hbase/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/TablePermission.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/FailedSanityCheckException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationFactory.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/ChecksumFactory.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcController.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/util/ByteStringer.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClient.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/AbstractByteRange.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/MetaMutationAnnotation.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/io/hadoopbackport/ThrottledInputStream.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/trace/HBaseHTraceConfiguration.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/MurmurHash3.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshotException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/ThrottlingException.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/DelegatingPayloadCarryingRpcController.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/BaseConfigurable.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5809 (See https://builds.apache.org/job/HBase-TRUNK/5809/ ) HBASE-10671 Add missing InterfaceAudience annotations for classes in hbase-common and hbase-client modules (enis: rev 882324dbcc224072be6a43a74aa6102637e529f8) hbase-common/src/main/java/org/apache/hadoop/hbase/NamespaceDescriptor.java hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/PreemptiveFastFailException.java hbase-common/src/test/java/org/apache/hadoop/hbase/ClassFinder.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/ReadOnlyByteRangeException.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableMultiplexer.java hbase-annotations/src/main/java/org/apache/hadoop/hbase/classification/tools/IncludePublicAnnotationsStandardDoclet.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/BoundedCompletionService.java hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/UnknownProtocolException.java hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ConnectionClosingException.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/SimpleByteRange.java hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/LockTimeoutException.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClientZKImpl.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityControllerNotReadyException.java hbase-protocol/pom.xml hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/IPCUtil.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/ExceptionUtil.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/Base64.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RowTooBigException.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/InvalidQuotaSettingsException.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/UserPermission.java hbase-common/src/main/java/org/apache/hadoop/hbase/types/PBType.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedException.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueueInfo.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java hbase-common/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaExceededException.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/Permission.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Batch.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesZKImpl.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/AbstractPositionedByteRange.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/ConcatenatedLists.java hbase-client/src/main/java/org/apache/hadoop/hbase/KeepDeletedCells.java hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RegexStringComparator.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionAdminServiceCallable.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenIdentifier.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcControllerFactory.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTrackerZKImpl.java hbase-client/src/test/java/org/apache/hadoop/hbase/TestInterfaceAudienceAnnotations.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/FailureInfo.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/ChecksumType.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/DelegatingRetryingCallable.java hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java hbase-annotations/src/main/java/org/apache/hadoop/hbase/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/TablePermission.java hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/FailedSanityCheckException.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationFactory.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/ChecksumFactory.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcController.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/util/ByteStringer.java hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClient.java hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/AbstractByteRange.java hbase-common/src/main/java/org/apache/hadoop/hbase/MetaMutationAnnotation.java hbase-common/src/main/java/org/apache/hadoop/hbase/io/hadoopbackport/ThrottledInputStream.java hbase-common/src/main/java/org/apache/hadoop/hbase/trace/HBaseHTraceConfiguration.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/MurmurHash3.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationException.java hbase-client/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshotException.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/ThrottlingException.java hbase-common/src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/DelegatingPayloadCarryingRpcController.java hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java hbase-common/src/main/java/org/apache/hadoop/hbase/BaseConfigurable.java
          Hide
          Enis Soztutar added a comment -

          Attaching the committed versions of the patches.

          Show
          Enis Soztutar added a comment - Attaching the committed versions of the patches.
          Hide
          Enis Soztutar added a comment -

          Pushed this to 0.99+. Thanks for review Stack.

          Show
          Enis Soztutar added a comment - Pushed this to 0.99+. Thanks for review Stack.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-1.0 #492 (See https://builds.apache.org/job/HBase-1.0/492/)
          HBASE-10671 Add missing InterfaceAudience annotations for classes in hbase-common and hbase-client modules (enis: rev aa343ebcfe169732d2868006f235c231f1af2e5d)

          • hbase-common/src/main/java/org/apache/hadoop/hbase/io/hadoopbackport/ThrottledInputStream.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/ConcatenatedLists.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/DelegatingRetryingCallable.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/MetaMutationAnnotation.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/LockTimeoutException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ConnectionClosingException.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/ChecksumType.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcController.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/types/PBType.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionServerCoprocessorRpcChannel.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenIdentifier.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/AbstractPositionedByteRange.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RowTooBigException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/TablePermission.java
          • hbase-annotations/src/main/java/org/apache/hadoop/hbase/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/FailureInfo.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClient.java
          • hbase-common/src/test/java/org/apache/hadoop/hbase/ClassFinder.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/ChecksumFactory.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Batch.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/NamespaceDescriptor.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTrackerZKImpl.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/Base64.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/UnknownProtocolException.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/SimpleByteRange.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/KeepDeletedCells.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RegexStringComparator.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueueInfo.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableMultiplexer.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshotException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/UserPermission.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/MurmurHash3.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/trace/HBaseHTraceConfiguration.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesZKImpl.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/util/ByteStringer.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcControllerFactory.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java
          • hbase-protocol/pom.xml
          • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationFactory.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/BoundedCompletionService.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/AbstractByteRange.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/DelegatingPayloadCarryingRpcController.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/ExceptionUtil.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityControllerNotReadyException.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/TestInterfaceAudienceAnnotations.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtilsForTests.java
          • hbase-annotations/src/main/java/org/apache/hadoop/hbase/classification/tools/IncludePublicAnnotationsStandardDoclet.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/PreemptiveFastFailException.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClientZKImpl.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/BaseConfigurable.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/util/ReadOnlyByteRangeException.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/Permission.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/IPCUtil.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/FailedSanityCheckException.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-1.0 #492 (See https://builds.apache.org/job/HBase-1.0/492/ ) HBASE-10671 Add missing InterfaceAudience annotations for classes in hbase-common and hbase-client modules (enis: rev aa343ebcfe169732d2868006f235c231f1af2e5d) hbase-common/src/main/java/org/apache/hadoop/hbase/io/hadoopbackport/ThrottledInputStream.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/ConcatenatedLists.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/DelegatingRetryingCallable.java hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java hbase-common/src/main/java/org/apache/hadoop/hbase/MetaMutationAnnotation.java hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/LockTimeoutException.java hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ConnectionClosingException.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/ChecksumType.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationException.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcController.java hbase-common/src/main/java/org/apache/hadoop/hbase/types/PBType.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionServerCoprocessorRpcChannel.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenIdentifier.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/AbstractPositionedByteRange.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RowTooBigException.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/TablePermission.java hbase-annotations/src/main/java/org/apache/hadoop/hbase/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/FailureInfo.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClient.java hbase-common/src/test/java/org/apache/hadoop/hbase/ClassFinder.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/ChecksumFactory.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Batch.java hbase-common/src/main/java/org/apache/hadoop/hbase/NamespaceDescriptor.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTrackerZKImpl.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/Base64.java hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/UnknownProtocolException.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/SimpleByteRange.java hbase-client/src/main/java/org/apache/hadoop/hbase/KeepDeletedCells.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RegexStringComparator.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueueInfo.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableMultiplexer.java hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java hbase-client/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshotException.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedException.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/UserPermission.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/MurmurHash3.java hbase-common/src/main/java/org/apache/hadoop/hbase/trace/HBaseHTraceConfiguration.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesZKImpl.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/util/ByteStringer.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcControllerFactory.java hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java hbase-common/src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java hbase-protocol/pom.xml hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationFactory.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/BoundedCompletionService.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/AbstractByteRange.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/DelegatingPayloadCarryingRpcController.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/ExceptionUtil.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityControllerNotReadyException.java hbase-client/src/test/java/org/apache/hadoop/hbase/TestInterfaceAudienceAnnotations.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtilsForTests.java hbase-annotations/src/main/java/org/apache/hadoop/hbase/classification/tools/IncludePublicAnnotationsStandardDoclet.java hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/PreemptiveFastFailException.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClientZKImpl.java hbase-common/src/main/java/org/apache/hadoop/hbase/BaseConfigurable.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/ReadOnlyByteRangeException.java hbase-common/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/Permission.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/IPCUtil.java hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/FailedSanityCheckException.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java
          Hide
          Enis Soztutar added a comment -

          Closing this issue after 0.99.2 release.

          Show
          Enis Soztutar added a comment - Closing this issue after 0.99.2 release.

            People

            • Assignee:
              Enis Soztutar
              Reporter:
              Enis Soztutar
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development