[HBASE-11318] Classes in security subpackages missing @InterfaceAudience annotations.

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.99.0, 0.96.1.1, 0.98.3
• Fix Version/s: 0.99.0, 0.98.5
• Component/s: security
• Hadoop Flags: Reviewed
• Assignee: Andrew Kyle Purtell
• Reporter: Jonathan Hsieh
• Created: 10/Jun/14 16:08
• Updated: 06/Apr/18 17:51
• Resolved: 04/Aug/14 18:20

Description

I was reading some of the security related code and noticed that many of the security related classes lack @InterfaceAudience markings.

WIth the current api I believe all but Permission should be Private. With the introduction of cell level ACL's Permission must be public because it is now exposed in the Mutation setACL calls[1].

There is an inconsistency with the Mutation ACL – the acl setters take Permission instances but the getter returns byte[]'s. As a follow on issue we could change the signature of Mutation.setACL so we don't have to expose the Permission class and convert it to be byte[], or change the getter to return an exposed Permission instance.

[1] http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/Mutation.html#setACL(java.util.Map)

Issue Links

• duplicates: HBASE-10671 Add missing InterfaceAudience annotations for classes in hbase-common and hbase-client modules