Hadoop Common
  1. Hadoop Common
  2. HADOOP-7343

backport HADOOP-7008 and HADOOP-7042 to branch-0.20-security

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.204.0
    • Fix Version/s: 0.20.205.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      backport HADOOP-7008 and HADOOP-7042 to branch-0.20-security so that we can enable test-patch.sh to have a configured number of acceptable findbugs and javadoc warnings

      1. HADOOP-7343-20security.patch
        17 kB
        Thomas Graves
      2. HADOOP-7343-20security.patch
        17 kB
        Thomas Graves

        Activity

        Thomas Graves created issue -
        Thomas Graves made changes -
        Field Original Value New Value
        Attachment HADOOP-7343-20security.patch [ 12481359 ]
        Thomas Graves made changes -
        Attachment HADOOP-7343-20security.patch [ 12481360 ]
        Hide
        Thomas Graves added a comment -

        tested manually by having it not quit if svn update finds code checked out since otherwise it would fail and run the old test-patch.sh.

        [exec]
        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
        [exec]

        Show
        Thomas Graves added a comment - tested manually by having it not quit if svn update finds code checked out since otherwise it would fail and run the old test-patch.sh. [exec] [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec]
        Thomas Graves made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481360/HADOOP-7343-20security.patch
        against trunk revision 1130833.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 17 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/567//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481360/HADOOP-7343-20security.patch against trunk revision 1130833. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 17 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/567//console This message is automatically generated.
        Hide
        Chris Douglas added a comment -

        +1

        I committed this. Thanks, Tom!

        Show
        Chris Douglas added a comment - +1 I committed this. Thanks, Tom!
        Chris Douglas made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.20.206.0 [ 12316501 ]
        Resolution Fixed [ 1 ]
        Hide
        Matt Foley added a comment -

        Please note that the Subversion Commit message is missing from this jira because the commit message had a typo: it used "MAPREDUCE-7343" instead of the correct "HADOOP-7343". The robot that puts commit messages in Jiras is just driven by grep, and if the jira number is wrong, it doesn't know where to put the message.

        Nevertheless, it was committed, as:
        ------------------------------------------------------------------------
        r1132794 | cdouglas | 2011-06-06 14:50:31 -0700 (Mon, 06 Jun 2011)

        MAPREDUCE-7343. Make the number of warnings accepted by test-patch
        configurable to limit false positives. Contributed by Thomas Graves
        ------------------------------------------------------------------------

        I'll correct the CHANGES.txt entry (which also used "MAPREDUCE-7343") in the next day or two.

        Show
        Matt Foley added a comment - Please note that the Subversion Commit message is missing from this jira because the commit message had a typo: it used "MAPREDUCE-7343" instead of the correct " HADOOP-7343 ". The robot that puts commit messages in Jiras is just driven by grep, and if the jira number is wrong, it doesn't know where to put the message. Nevertheless, it was committed, as: ------------------------------------------------------------------------ r1132794 | cdouglas | 2011-06-06 14:50:31 -0700 (Mon, 06 Jun 2011) MAPREDUCE-7343. Make the number of warnings accepted by test-patch configurable to limit false positives. Contributed by Thomas Graves ------------------------------------------------------------------------ I'll correct the CHANGES.txt entry (which also used "MAPREDUCE-7343") in the next day or two.
        Matt Foley made changes -
        Fix Version/s 0.20.205.0 [ 12316390 ]
        Fix Version/s 0.20.206.0 [ 12316501 ]
        Hide
        Matt Foley added a comment -

        Closed upon release of 0.20.205.0

        Show
        Matt Foley added a comment - Closed upon release of 0.20.205.0
        Matt Foley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Thomas Graves
            Reporter:
            Thomas Graves
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development