Hadoop Common
  1. Hadoop Common
  2. HADOOP-7008

Enable test-patch.sh to have a configured number of acceptable findbugs and javadoc warnings

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: test
    • Labels:
      None

      Description

      test-patch.sh should be able to accept a properties file containing an acceptable number of findbugs and javadoc warnings.

      1. HADOOP-7008.patch
        8 kB
        Nigel Daley
      2. HADOOP-7008-V1.patch
        14 kB
        Giridharan Kesavan
      3. HADOOP-7008-V2.patch
        14 kB
        Nigel Daley

        Activity

        Hide
        Nigel Daley added a comment -

        Attaching a patch for review. Giri, hoping you can review this. It hasn't been well tested yet.

        Show
        Nigel Daley added a comment - Attaching a patch for review. Giri, hoping you can review this. It hasn't been well tested yet.
        Hide
        Giridharan Kesavan added a comment -

        comments:

        1) we should add OK_RELEASEAUDIT_WARNINGS to the properties file..

        2) Every project should define these numbers even if the project has zero warnings for findbugs/releaseaudit/javadoc. Thatway we dont have to pre-build the trunk to determine the numbers.

        3) HADOOP-7008.patch patch seem to run findbug on trunk if the OK_FINDBUGS_WARNINGS is not defined or the warnings not equal to zero.
        Is there any reason why we are running findbugs if its already defined?

        I think all the projects should just define the values for these 3 properties. test-patch.sh should directly apply the patch and determine the warnings and do a +1 or -1 (if the numbers are greater than the numbers defined in the properties file.)

        Show
        Giridharan Kesavan added a comment - comments: 1) we should add OK_RELEASEAUDIT_WARNINGS to the properties file.. 2) Every project should define these numbers even if the project has zero warnings for findbugs/releaseaudit/javadoc. Thatway we dont have to pre-build the trunk to determine the numbers. 3) HADOOP-7008 .patch patch seem to run findbug on trunk if the OK_FINDBUGS_WARNINGS is not defined or the warnings not equal to zero. Is there any reason why we are running findbugs if its already defined? I think all the projects should just define the values for these 3 properties. test-patch.sh should directly apply the patch and determine the warnings and do a +1 or -1 (if the numbers are greater than the numbers defined in the properties file.)
        Hide
        Giridharan Kesavan added a comment -

        V1 patch address the comments.

        Show
        Giridharan Kesavan added a comment - V1 patch address the comments.
        Hide
        Giridharan Kesavan added a comment -

        Nigel, Could you pls review this patch?

        Show
        Giridharan Kesavan added a comment - Nigel, Could you pls review this patch?
        Hide
        Nigel Daley added a comment -

        A couple minor comment changes

        Show
        Nigel Daley added a comment - A couple minor comment changes
        Hide
        Nigel Daley added a comment -

        Patch looks good. I'm going to commit it. One issue I see however is that if Findbugs warnings are allowed to increase from 0 for trunk, then the findbugs html report output by this patch won't make it clear which warnings pre-existed on trunk and which ones are new.

        Show
        Nigel Daley added a comment - Patch looks good. I'm going to commit it. One issue I see however is that if Findbugs warnings are allowed to increase from 0 for trunk, then the findbugs html report output by this patch won't make it clear which warnings pre-existed on trunk and which ones are new.
        Hide
        Nigel Daley added a comment -

        I just committed this.

        Show
        Nigel Daley added a comment - I just committed this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #410 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/410/)
        HADOOP-7008. Enable test-patch.sh to have a configured number of acceptable findbugs and javadoc warnings. Contributed by nigel and gkesavan.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #410 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/410/ ) HADOOP-7008 . Enable test-patch.sh to have a configured number of acceptable findbugs and javadoc warnings. Contributed by nigel and gkesavan.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #422 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/422/)
        HADOOP-7008. Enable test-patch.sh to have a configured number of acceptable findbugs and javadoc warnings. Contributed by nigel and gkesavan.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #422 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/422/ ) HADOOP-7008 . Enable test-patch.sh to have a configured number of acceptable findbugs and javadoc warnings. Contributed by nigel and gkesavan.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #500 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/500/)
        HADOOP-7008. Enable test-patch.sh to have a configured number of acceptable findbugs and javadoc warnings. Contributed by nigel and gkesavan.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #500 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/500/ ) HADOOP-7008 . Enable test-patch.sh to have a configured number of acceptable findbugs and javadoc warnings. Contributed by nigel and gkesavan.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #527 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/527/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #527 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/527/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #413 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/413/)
        HADOOP-7008. Fix bug and missing license header in test-patch files. (nigel)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #413 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/413/ ) HADOOP-7008 . Fix bug and missing license header in test-patch files. (nigel)
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #423 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/423/)
        HADOOP-7008. Fix bug and missing license header in test-patch files. (nigel)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #423 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/423/ ) HADOOP-7008 . Fix bug and missing license header in test-patch files. (nigel)
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #503 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/503/)
        HADOOP-7008. Fix bug and missing license header in test-patch files. (nigel)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #503 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/503/ ) HADOOP-7008 . Fix bug and missing license header in test-patch files. (nigel)
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #530 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/530/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #530 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/530/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )

          People

          • Assignee:
            Giridharan Kesavan
            Reporter:
            Nigel Daley
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development