Hadoop Common
  1. Hadoop Common
  2. HADOOP-7042

Update test-patch.sh to include failed test names and move test-patch.properties

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None

      Description

      As Jakob suggested, it would be helpful if the Jira messages left by Hudson included the list of failed tests.

      Also, test-patch.properties must be moved out of the src/test/bin dir because it is project specific and the entire bin dir is svn included into other projects (hdfs and mapreduce)

      1. HADOOP-7042.patch
        3 kB
        Nigel Daley
      2. HADOOP-7042.patch
        5 kB
        Nigel Daley
      3. HADOOP-7042.patch
        5 kB
        Nigel Daley
      4. HADOOP-7042.patch
        5 kB
        Nigel Daley

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #554 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/554/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #554 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/554/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #520 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/520/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #520 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/520/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #434 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/434/)
        HADOOP-7042. Updates to test-patch.sh to include failed test names and improve other messaging. Contributed by nigel.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #434 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/434/ ) HADOOP-7042 . Updates to test-patch.sh to include failed test names and improve other messaging. Contributed by nigel.
        Hide
        Eli Collins added a comment -

        Other's agree with these numbers?

        Seems accurate. I looked at the rat warnings a while back, iirc they didn't seem problematic, but we should get these to zero in case real issues are hiding.

        Show
        Eli Collins added a comment - Other's agree with these numbers? Seems accurate. I looked at the rat warnings a while back, iirc they didn't seem problematic, but we should get these to zero in case real issues are hiding.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #432 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/432/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #432 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/432/ )
        Hide
        Nigel Daley added a comment -

        I'll fix this tonight. I needed to find out what the current number for these on trunk are. This is what I'm seeing:
        HDFS Findbugs warnings on trunk: 0
        HDFS Javadoc warnings on trunk: 0
        HDFS Release Audit warnings on trunk: 98 (seriously?!?)

        Other's agree with these numbers?

        Show
        Nigel Daley added a comment - I'll fix this tonight. I needed to find out what the current number for these on trunk are. This is what I'm seeing: HDFS Findbugs warnings on trunk: 0 HDFS Javadoc warnings on trunk: 0 HDFS Release Audit warnings on trunk: 98 (seriously?!?) Other's agree with these numbers?
        Hide
        Konstantin Boudnik added a comment -

        Two things:

        • property file is missing for HDFS and MR (and it is expected to be in '..' relative to test-patch.sh location)
        • test-patch.sh isn't any more an external imported from common (which seems to be a good thing and will allow to use this feature on git without any additional hassle).
        Show
        Konstantin Boudnik added a comment - Two things: property file is missing for HDFS and MR (and it is expected to be in '..' relative to test-patch.sh location) test-patch.sh isn't any more an external imported from common (which seems to be a good thing and will allow to use this feature on git without any additional hassle).
        Hide
        Todd Lipcon added a comment -

        [oops, sorry, accidentally clicked the link button on the wrong jira!]

        Show
        Todd Lipcon added a comment - [oops, sorry, accidentally clicked the link button on the wrong jira!]
        Hide
        Todd Lipcon added a comment -

        Hm, is there an HDFS JIRA that adds the required properties file? test-patch on hdfs is failing now:
        [exec] Patch file /data/1/scratch/patchqueue/patch-worker-2127/patch_11/undertest.patch copied to /data/1/scratch/patchqueue/patch-worker-2127/patch_11/scratch
        [exec] Please define the following properties in test-patch.properties file
        [exec] OK_FINDBUGS_WARNINGS
        [exec] OK_RELEASEAUDIT_WARNINGS
        [exec] OK_JAVAFINDBUGS_WARNINGS

        Show
        Todd Lipcon added a comment - Hm, is there an HDFS JIRA that adds the required properties file? test-patch on hdfs is failing now: [exec] Patch file /data/1/scratch/patchqueue/patch-worker-2127/patch_11/undertest.patch copied to /data/1/scratch/patchqueue/patch-worker-2127/patch_11/scratch [exec] Please define the following properties in test-patch.properties file [exec] OK_FINDBUGS_WARNINGS [exec] OK_RELEASEAUDIT_WARNINGS [exec] OK_JAVAFINDBUGS_WARNINGS
        Hide
        Nigel Daley added a comment -

        Just committed this.

        Show
        Nigel Daley added a comment - Just committed this.
        Hide
        Nigel Daley added a comment -

        fix a bug in the patch

        Show
        Nigel Daley added a comment - fix a bug in the patch
        Hide
        Nigel Daley added a comment -

        Updated patch that increases OK_FINDBUGS_WARNINGS to 1 after upgrading build machine findbugs to 1.3.9 (will file a new issue to get that back to zero). Also added the findbugs version in the jira comment message.

        Show
        Nigel Daley added a comment - Updated patch that increases OK_FINDBUGS_WARNINGS to 1 after upgrading build machine findbugs to 1.3.9 (will file a new issue to get that back to zero). Also added the findbugs version in the jira comment message.

          People

          • Assignee:
            Nigel Daley
            Reporter:
            Nigel Daley
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development