Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14380

Make the Guava version Hadoop which builds with configurable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha4
    • Fix Version/s: 3.0.0-alpha4
    • Component/s: build
    • Labels:
      None

      Description

      Make the choice of guava version Hadoop builds with configurable, so people building Hadoop 3 alphas can build with an older version and so cause less unhappiness downstream

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment - - edited

          FWIW, the min version hadoop-common builds against is 19.0, because of the move from Objects to MoreObjects forced by the java 8 migration. Hadoop trunk is java 8+, so 19.0+ it is. unless someone moves the toString() calls in MetricsRegistry off Guava. Which isn't hard, and keeps guava brittleness down

          [INFO] Finished at: 2017-05-04T14:24:17+01:00
          [INFO] Final Memory: 106M/874M
          [INFO] ------------------------------------------------------------------------
          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project hadoop-common: Compilation failure: Compilation failure:
          [ERROR] /Users/stevel/Projects/hadoop-trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java:[25,30] cannot find symbol
          [ERROR] symbol:   class MoreObjects
          [ERROR] location: package com.google.common.base
          [ERROR] /Users/stevel/Projects/hadoop-trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/MetricsTag.java:[21,30] cannot find symbol
          
          Show
          stevel@apache.org Steve Loughran added a comment - - edited FWIW, the min version hadoop-common builds against is 19.0, because of the move from Objects to MoreObjects forced by the java 8 migration. Hadoop trunk is java 8+, so 19.0+ it is. unless someone moves the toString() calls in MetricsRegistry off Guava. Which isn't hard, and keeps guava brittleness down [INFO] Finished at: 2017-05-04T14:24:17+01:00 [INFO] Final Memory: 106M/874M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile ( default -compile) on project hadoop-common: Compilation failure: Compilation failure: [ERROR] /Users/stevel/Projects/hadoop-trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java:[25,30] cannot find symbol [ERROR] symbol: class MoreObjects [ERROR] location: package com.google.common.base [ERROR] /Users/stevel/Projects/hadoop-trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/MetricsTag.java:[21,30] cannot find symbol
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Patch 001; guava.version is now a property.

          the min version you can actually build with is 0.19, but at least now you get some option to experiment.

          Show
          stevel@apache.org Steve Loughran added a comment - Patch 001; guava.version is now a property. the min version you can actually build with is 0.19, but at least now you get some option to experiment.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks, Steve! +1 lgtm pending Jenkins.

          Show
          jlowe Jason Lowe added a comment - Thanks, Steve! +1 lgtm pending Jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 13m 54s trunk passed
          +1 compile 0m 9s trunk passed
          +1 mvnsite 0m 12s trunk passed
          +1 mvneclipse 0m 10s trunk passed
          +1 javadoc 0m 10s trunk passed
          +1 mvninstall 0m 8s the patch passed
          +1 compile 0m 6s the patch passed
          +1 javac 0m 6s the patch passed
          +1 mvnsite 0m 8s the patch passed
          +1 mvneclipse 0m 7s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 javadoc 0m 7s the patch passed
          +1 unit 0m 6s hadoop-project in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          16m 43s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14380
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866404/HADOOP-14380-001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 8ffce6e89f64 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 81092b1
          Default Java 1.8.0_131
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12237/testReport/
          modules C: hadoop-project U: hadoop-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12237/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 54s trunk passed +1 compile 0m 9s trunk passed +1 mvnsite 0m 12s trunk passed +1 mvneclipse 0m 10s trunk passed +1 javadoc 0m 10s trunk passed +1 mvninstall 0m 8s the patch passed +1 compile 0m 6s the patch passed +1 javac 0m 6s the patch passed +1 mvnsite 0m 8s the patch passed +1 mvneclipse 0m 7s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 javadoc 0m 7s the patch passed +1 unit 0m 6s hadoop-project in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 16m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14380 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866404/HADOOP-14380-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 8ffce6e89f64 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 81092b1 Default Java 1.8.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12237/testReport/ modules C: hadoop-project U: hadoop-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12237/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          +1 from me too, I did the toStringHelper conversions over on HADOOP-14382. I'd like to stick with the old Guava until we can get the shading resolved.

          Show
          andrew.wang Andrew Wang added a comment - +1 from me too, I did the toStringHelper conversions over on HADOOP-14382 . I'd like to stick with the old Guava until we can get the shading resolved.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks to Steve for the contribution and to Andrew for additional review! I committed this to trunk.

          Show
          jlowe Jason Lowe added a comment - Thanks to Steve for the contribution and to Andrew for additional review! I committed this to trunk.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11685 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11685/)
          HADOOP-14380. Make the Guava version Hadoop which builds with (jlowe: rev 61858a5c378da75aff9cde84d418af46d718d08b)

          • (edit) hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11685 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11685/ ) HADOOP-14380 . Make the Guava version Hadoop which builds with (jlowe: rev 61858a5c378da75aff9cde84d418af46d718d08b) (edit) hadoop-project/pom.xml

            People

            • Assignee:
              stevel@apache.org Steve Loughran
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development