Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14382

Remove usages of MoreObjects.toStringHelper

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha2
    • Fix Version/s: 3.0.0-alpha4
    • Component/s: metrics
    • Labels:
      None

      Description

      MoreObjects.toStringHelper is a source of incompatibility across Guava versions. Let's move off of this to a native Java 8 API.

        Issue Links

          Activity

          Hide
          andrew.wang Andrew Wang added a comment -

          Mechanical patch attached.

          Show
          andrew.wang Andrew Wang added a comment - Mechanical patch attached.
          Hide
          andrew.wang Andrew Wang added a comment -

          Steve Loughran / Tsuyoshi Ozawa could you take a look? Hoping this improves cross-guava compatibility.

          Show
          andrew.wang Andrew Wang added a comment - Steve Loughran / Tsuyoshi Ozawa could you take a look? Hoping this improves cross-guava compatibility.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 1m 36s Maven dependency ordering for branch
          +1 mvninstall 14m 52s trunk passed
          +1 compile 18m 32s trunk passed
          +1 checkstyle 2m 8s trunk passed
          +1 mvnsite 1m 40s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          -1 findbugs 1m 45s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 1m 11s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 0m 59s the patch passed
          +1 compile 14m 38s the patch passed
          +1 javac 14m 38s the patch passed
          +1 checkstyle 1m 56s the patch passed
          +1 mvnsite 1m 30s the patch passed
          +1 mvneclipse 0m 47s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 22s the patch passed
          +1 javadoc 1m 15s the patch passed
          +1 unit 9m 26s hadoop-common in the patch passed.
          +1 unit 0m 26s hadoop-kafka in the patch passed.
          +1 asflicense 0m 39s The patch does not generate ASF License warnings.
          101m 49s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14382
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866479/HADOOP-14382.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4cd2d65e9ed4 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 25f5d9a
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12240/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12240/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-kafka U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12240/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 36s Maven dependency ordering for branch +1 mvninstall 14m 52s trunk passed +1 compile 18m 32s trunk passed +1 checkstyle 2m 8s trunk passed +1 mvnsite 1m 40s trunk passed +1 mvneclipse 0m 42s trunk passed -1 findbugs 1m 45s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 11s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 0m 59s the patch passed +1 compile 14m 38s the patch passed +1 javac 14m 38s the patch passed +1 checkstyle 1m 56s the patch passed +1 mvnsite 1m 30s the patch passed +1 mvneclipse 0m 47s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 22s the patch passed +1 javadoc 1m 15s the patch passed +1 unit 9m 26s hadoop-common in the patch passed. +1 unit 0m 26s hadoop-kafka in the patch passed. +1 asflicense 0m 39s The patch does not generate ASF License warnings. 101m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14382 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866479/HADOOP-14382.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4cd2d65e9ed4 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 25f5d9a Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12240/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12240/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-kafka U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12240/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          LGTM

          +1

          Show
          stevel@apache.org Steve Loughran added a comment - LGTM +1
          Hide
          stevel@apache.org Steve Loughran added a comment -

          commited to trunk. Thanks!

          Show
          stevel@apache.org Steve Loughran added a comment - commited to trunk. Thanks!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11690 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11690/)
          HADOOP-14382 Remove usages of MoreObjects.toStringHelper. Contributed by (stevel: rev 4e6bbd049dead7008942bda09dfd54542c407f48)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/AbstractMetric.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/util/MetricsCache.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MsInfo.java
          • (edit) hadoop-tools/hadoop-kafka/src/test/java/org/apache/hadoop/metrics2/impl/TestKafkaMetrics.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/MetricsTag.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsInfoImpl.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetricsInfo.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/AbstractMetricsRecord.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11690 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11690/ ) HADOOP-14382 Remove usages of MoreObjects.toStringHelper. Contributed by (stevel: rev 4e6bbd049dead7008942bda09dfd54542c407f48) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/AbstractMetric.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/util/MetricsCache.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MsInfo.java (edit) hadoop-tools/hadoop-kafka/src/test/java/org/apache/hadoop/metrics2/impl/TestKafkaMetrics.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/MetricsTag.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsInfoImpl.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetricsInfo.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/AbstractMetricsRecord.java

            People

            • Assignee:
              andrew.wang Andrew Wang
              Reporter:
              andrew.wang Andrew Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development