Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13579

Fix source-level compatibility after HADOOP-11252

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.7.3, 2.6.4
    • Fix Version/s: 2.6.5, 2.7.4
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Reported by Chiwan Park

      Since 2.7.3 release, Client.get/setPingInterval is changed from public to package-private.

      Giraph is one of broken examples for this changes. (https://github.com/apache/giraph/blob/release-1.0/giraph-core/src/main/java/org/apache/giraph/job/GiraphJob.java#L202)

      1. HADOOP-13579-branch-2.6.001.patch
        9 kB
        Tsuyoshi Ozawa
      2. HADOOP-13579-branch-2.6.002.patch
        1 kB
        Tsuyoshi Ozawa
      3. HADOOP-13579-branch-2.6.003.patch
        1 kB
        Tsuyoshi Ozawa
      4. HADOOP-13579-branch-2.7.001.patch
        9 kB
        Tsuyoshi Ozawa
      5. HADOOP-13579-branch-2.7.002.patch
        1 kB
        Tsuyoshi Ozawa
      6. HADOOP-13579-branch-2.7.003.patch
        1 kB
        Tsuyoshi Ozawa

        Issue Links

          Activity

          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          As commented on HADOOP-11252, I will revert it from branch-2.7 if there are no opposition until tomorrow(without patch).

          Show
          ozawa Tsuyoshi Ozawa added a comment - As commented on HADOOP-11252 , I will revert it from branch-2.7 if there are no opposition until tomorrow(without patch).
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          (reply to Akira's comment)
          OK, I'll create patch to fix.

          Show
          ozawa Tsuyoshi Ozawa added a comment - (reply to Akira's comment ) OK, I'll create patch to fix.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          This also affects 2.6.4 release.

          Show
          ozawa Tsuyoshi Ozawa added a comment - This also affects 2.6.4 release.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          HADOOP-11252 is not just a bug fix, so I think we shouldn't include this to point release. The point-release upgrading of cluster causes the change of default behaviour of RPC; this seems to be too drastic to backport HADOOP-11252 to branch-2.6 and branch-2.7's point release.

          Show
          ozawa Tsuyoshi Ozawa added a comment - HADOOP-11252 is not just a bug fix, so I think we shouldn't include this to point release. The point-release upgrading of cluster causes the change of default behaviour of RPC; this seems to be too drastic to backport HADOOP-11252 to branch-2.6 and branch-2.7's point release.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          The point-release upgrading of cluster causes the change of default behaviour of RPC

          The default behaviour is retained unless newly introduced ipc.client.rpc-timeout.ms is set to >0 explicitly. Since making setPingInterval/getPingInterval package private is not crucial for the fix, you can just make them public again.

          Show
          iwasakims Masatake Iwasaki added a comment - The point-release upgrading of cluster causes the change of default behaviour of RPC The default behaviour is retained unless newly introduced ipc.client.rpc-timeout.ms is set to >0 explicitly. Since making setPingInterval/getPingInterval package private is not crucial for the fix, you can just make them public again.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Tsuyoshi Ozawa I agree with you that point-release should contain minimum change but it is worth adding way-out for the major issue such as taking >15 minutes to failover RM (YARN-2578) if the fix can retain default behaviour.

          Show
          iwasakims Masatake Iwasaki added a comment - Tsuyoshi Ozawa I agree with you that point-release should contain minimum change but it is worth adding way-out for the major issue such as taking >15 minutes to failover RM ( YARN-2578 ) if the fix can retain default behaviour.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Masatake Iwasaki thanks for your explanation! Make sense to preserve the changes on these branches.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Masatake Iwasaki thanks for your explanation! Make sense to preserve the changes on these branches.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Masatake Iwasaki could you review the v2 patches? (the patches of branch-2.6 and branch-2.7 are actually same; it's just for clarification)

          Show
          ozawa Tsuyoshi Ozawa added a comment - Masatake Iwasaki could you review the v2 patches? (the patches of branch-2.6 and branch-2.7 are actually same; it's just for clarification)
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 11m 30s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 29s Maven dependency ordering for branch
          +1 mvninstall 5m 50s branch-2.7 passed
          +1 compile 5m 17s branch-2.7 passed with JDK v1.8.0_101
          +1 compile 6m 10s branch-2.7 passed with JDK v1.7.0_111
          +1 checkstyle 1m 21s branch-2.7 passed
          +1 mvnsite 1m 45s branch-2.7 passed
          +1 mvneclipse 0m 29s branch-2.7 passed
          -1 findbugs 1m 34s hadoop-common-project/hadoop-common in branch-2.7 has 3 extant Findbugs warnings.
          +1 javadoc 1m 39s branch-2.7 passed with JDK v1.8.0_101
          +1 javadoc 2m 30s branch-2.7 passed with JDK v1.7.0_111
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 1m 31s the patch passed
          +1 compile 5m 13s the patch passed with JDK v1.8.0_101
          +1 javac 5m 13s the patch passed
          +1 compile 6m 11s the patch passed with JDK v1.7.0_111
          +1 javac 6m 11s the patch passed
          -0 checkstyle 1m 22s root: The patch generated 4 new + 368 unchanged - 0 fixed = 372 total (was 368)
          +1 mvnsite 1m 45s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          -1 whitespace 0m 0s The patch has 2768 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 1m 35s The patch 124 line(s) with tabs.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 56s the patch passed
          +1 javadoc 1m 38s the patch passed with JDK v1.8.0_101
          +1 javadoc 2m 36s the patch passed with JDK v1.7.0_111
          -1 unit 19m 56s hadoop-common in the patch failed with JDK v1.7.0_111.
          -1 unit 50m 35s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
          -1 asflicense 0m 23s The patch generated 3 ASF License warnings.
          219m 7s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.util.bloom.TestBloomFilters
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.web.TestWebHdfsTokens
            hadoop.hdfs.TestParallelUnixDomainRead
            hadoop.hdfs.server.balancer.TestBalancer
          JDK v1.8.0_101 Timed out junit tests org.apache.hadoop.conf.TestConfiguration
            org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          JDK v1.7.0_111 Failed junit tests hadoop.util.bloom.TestBloomFilters
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            hadoop.hdfs.server.balancer.TestBalancer
          JDK v1.7.0_111 Timed out junit tests org.apache.hadoop.conf.TestConfiguration



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Issue HADOOP-13579
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827133/HADOOP-13579-branch-2.7.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 557ef7fa9f61 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 67204f2
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 11m 30s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 29s Maven dependency ordering for branch +1 mvninstall 5m 50s branch-2.7 passed +1 compile 5m 17s branch-2.7 passed with JDK v1.8.0_101 +1 compile 6m 10s branch-2.7 passed with JDK v1.7.0_111 +1 checkstyle 1m 21s branch-2.7 passed +1 mvnsite 1m 45s branch-2.7 passed +1 mvneclipse 0m 29s branch-2.7 passed -1 findbugs 1m 34s hadoop-common-project/hadoop-common in branch-2.7 has 3 extant Findbugs warnings. +1 javadoc 1m 39s branch-2.7 passed with JDK v1.8.0_101 +1 javadoc 2m 30s branch-2.7 passed with JDK v1.7.0_111 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 31s the patch passed +1 compile 5m 13s the patch passed with JDK v1.8.0_101 +1 javac 5m 13s the patch passed +1 compile 6m 11s the patch passed with JDK v1.7.0_111 +1 javac 6m 11s the patch passed -0 checkstyle 1m 22s root: The patch generated 4 new + 368 unchanged - 0 fixed = 372 total (was 368) +1 mvnsite 1m 45s the patch passed +1 mvneclipse 0m 29s the patch passed -1 whitespace 0m 0s The patch has 2768 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 1m 35s The patch 124 line(s) with tabs. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 56s the patch passed +1 javadoc 1m 38s the patch passed with JDK v1.8.0_101 +1 javadoc 2m 36s the patch passed with JDK v1.7.0_111 -1 unit 19m 56s hadoop-common in the patch failed with JDK v1.7.0_111. -1 unit 50m 35s hadoop-hdfs in the patch failed with JDK v1.7.0_111. -1 asflicense 0m 23s The patch generated 3 ASF License warnings. 219m 7s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.util.bloom.TestBloomFilters   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.web.TestWebHdfsTokens   hadoop.hdfs.TestParallelUnixDomainRead   hadoop.hdfs.server.balancer.TestBalancer JDK v1.8.0_101 Timed out junit tests org.apache.hadoop.conf.TestConfiguration   org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots JDK v1.7.0_111 Failed junit tests hadoop.util.bloom.TestBloomFilters   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.balancer.TestBalancer JDK v1.7.0_111 Timed out junit tests org.apache.hadoop.conf.TestConfiguration Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HADOOP-13579 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827133/HADOOP-13579-branch-2.7.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 557ef7fa9f61 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 67204f2 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10446/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 43s branch-2.7 passed
          +1 compile 6m 27s branch-2.7 passed with JDK v1.8.0_101
          +1 compile 6m 37s branch-2.7 passed with JDK v1.7.0_111
          +1 checkstyle 0m 23s branch-2.7 passed
          +1 mvnsite 0m 50s branch-2.7 passed
          +1 mvneclipse 0m 16s branch-2.7 passed
          -1 findbugs 1m 40s hadoop-common-project/hadoop-common in branch-2.7 has 3 extant Findbugs warnings.
          +1 javadoc 0m 59s branch-2.7 passed with JDK v1.8.0_101
          +1 javadoc 1m 1s branch-2.7 passed with JDK v1.7.0_111
          +1 mvninstall 0m 44s the patch passed
          +1 compile 7m 44s the patch passed with JDK v1.8.0_101
          +1 javac 7m 44s the patch passed
          +1 compile 6m 53s the patch passed with JDK v1.7.0_111
          +1 javac 6m 53s the patch passed
          -0 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 2 new + 108 unchanged - 0 fixed = 110 total (was 108)
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          -1 whitespace 0m 0s The patch has 2413 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 1m 1s The patch 70 line(s) with tabs.
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 0m 44s the patch passed with JDK v1.8.0_101
          +1 javadoc 0m 55s the patch passed with JDK v1.7.0_111
          -1 unit 21m 40s hadoop-common in the patch failed with JDK v1.7.0_111.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          90m 5s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.util.bloom.TestBloomFilters
          JDK v1.8.0_101 Timed out junit tests org.apache.hadoop.conf.TestConfiguration
          JDK v1.7.0_111 Failed junit tests hadoop.ipc.TestDecayRpcScheduler
            hadoop.util.bloom.TestBloomFilters
          JDK v1.7.0_111 Timed out junit tests org.apache.hadoop.conf.TestConfiguration



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Issue HADOOP-13579
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827149/HADOOP-13579-branch-2.7.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3ed6d75f8450 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 67204f2
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10448/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10448/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10448/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10448/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10448/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10448/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10448/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 43s branch-2.7 passed +1 compile 6m 27s branch-2.7 passed with JDK v1.8.0_101 +1 compile 6m 37s branch-2.7 passed with JDK v1.7.0_111 +1 checkstyle 0m 23s branch-2.7 passed +1 mvnsite 0m 50s branch-2.7 passed +1 mvneclipse 0m 16s branch-2.7 passed -1 findbugs 1m 40s hadoop-common-project/hadoop-common in branch-2.7 has 3 extant Findbugs warnings. +1 javadoc 0m 59s branch-2.7 passed with JDK v1.8.0_101 +1 javadoc 1m 1s branch-2.7 passed with JDK v1.7.0_111 +1 mvninstall 0m 44s the patch passed +1 compile 7m 44s the patch passed with JDK v1.8.0_101 +1 javac 7m 44s the patch passed +1 compile 6m 53s the patch passed with JDK v1.7.0_111 +1 javac 6m 53s the patch passed -0 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 2 new + 108 unchanged - 0 fixed = 110 total (was 108) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 15s the patch passed -1 whitespace 0m 0s The patch has 2413 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 1m 1s The patch 70 line(s) with tabs. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 44s the patch passed with JDK v1.8.0_101 +1 javadoc 0m 55s the patch passed with JDK v1.7.0_111 -1 unit 21m 40s hadoop-common in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 90m 5s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.util.bloom.TestBloomFilters JDK v1.8.0_101 Timed out junit tests org.apache.hadoop.conf.TestConfiguration JDK v1.7.0_111 Failed junit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.util.bloom.TestBloomFilters JDK v1.7.0_111 Timed out junit tests org.apache.hadoop.conf.TestConfiguration Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HADOOP-13579 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827149/HADOOP-13579-branch-2.7.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3ed6d75f8450 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 67204f2 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10448/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10448/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10448/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10448/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10448/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10448/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10448/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          iwasakims Masatake Iwasaki added a comment -
          ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:215:  final public static void setPingInterval(Configuration conf, int pingInterval) {:9: 'public' modifier out of order with the JLS suggestions.
          ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:226:  final public static int getPingInterval(Configuration conf) {:9: 'public' modifier out of order with the JLS suggestions.
          

          checkstyle suggests public static final rather than final public static.

          There seems to be deadlock in TestConfiguration.testConcurrentAccesses even without the patch. It should be addressed in another jira.

          I'm +1 on 002 if the checkstyle issues are addressed.

          Show
          iwasakims Masatake Iwasaki added a comment - ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:215: final public static void setPingInterval(Configuration conf, int pingInterval) {:9: 'public' modifier out of order with the JLS suggestions. ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:226: final public static int getPingInterval(Configuration conf) {:9: 'public' modifier out of order with the JLS suggestions. checkstyle suggests public static final rather than final public static . There seems to be deadlock in TestConfiguration.testConcurrentAccesses even without the patch. It should be addressed in another jira. I'm +1 on 002 if the checkstyle issues are addressed.
          Hide
          ozawa Tsuyoshi Ozawa added a comment - - edited

          Masatake Iwasaki thanks for your review!

          checkstyle suggests public static final rather than final public static.

          I'm okay to fix checkstyle, but I fixed so because the coding style in the file is so, based on Hadoop Coding Style.

          changes to existing code: maintains existing style

          Can we go with v2 patch? Or, should we fix checkstyle?

          Show
          ozawa Tsuyoshi Ozawa added a comment - - edited Masatake Iwasaki thanks for your review! checkstyle suggests public static final rather than final public static. I'm okay to fix checkstyle, but I fixed so because the coding style in the file is so , based on Hadoop Coding Style . changes to existing code: maintains existing style Can we go with v2 patch? Or, should we fix checkstyle?
          Hide
          iwasakims Masatake Iwasaki added a comment -

          changes to existing code: maintains existing style

          I think we should address checkstyle warnings about coding style here. If the Client.java is consistent in coding style, we should keep it based on the above statement but it is not. Client.java has both final public static and public static final. Majority of the declarations keeps modifier order recommended by JLS.

          Show
          iwasakims Masatake Iwasaki added a comment - changes to existing code: maintains existing style I think we should address checkstyle warnings about coding style here. If the Client.java is consistent in coding style, we should keep it based on the above statement but it is not. Client.java has both final public static and public static final . Majority of the declarations keeps modifier order recommended by JLS.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          I do not think we should fix all checksytle issues in Client.java here. We should fix only relevant lines (215 and 226).

          Show
          iwasakims Masatake Iwasaki added a comment - I do not think we should fix all checksytle issues in Client.java here. We should fix only relevant lines (215 and 226).
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 36s branch-2.6 passed
          -1 compile 1m 42s root in branch-2.6 failed with JDK v1.8.0_101.
          -1 compile 1m 49s root in branch-2.6 failed with JDK v1.7.0_111.
          +1 checkstyle 0m 25s branch-2.6 passed
          +1 mvnsite 0m 45s branch-2.6 passed
          +1 mvneclipse 0m 16s branch-2.6 passed
          -1 findbugs 1m 36s hadoop-common-project/hadoop-common in branch-2.6 has 66 extant Findbugs warnings.
          +1 javadoc 0m 51s branch-2.6 passed with JDK v1.8.0_101
          +1 javadoc 1m 0s branch-2.6 passed with JDK v1.7.0_111
          +1 mvninstall 0m 39s the patch passed
          -1 compile 1m 35s root in the patch failed with JDK v1.8.0_101.
          -1 javac 1m 35s root in the patch failed with JDK v1.8.0_101.
          -1 compile 1m 46s root in the patch failed with JDK v1.7.0_111.
          -1 javac 1m 46s root in the patch failed with JDK v1.7.0_111.
          +1 checkstyle 0m 19s the patch passed
          +1 mvnsite 0m 43s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          -1 whitespace 0m 0s The patch has 2351 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 55s The patch 70 line(s) with tabs.
          +1 findbugs 1m 39s the patch passed
          +1 javadoc 0m 47s the patch passed with JDK v1.8.0_101
          +1 javadoc 0m 58s the patch passed with JDK v1.7.0_111
          -1 unit 6m 1s hadoop-common in the patch failed with JDK v1.7.0_111.
          -1 asflicense 0m 34s The patch generated 128 ASF License warnings.
          39m 49s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.ipc.TestDecayRpcScheduler
            hadoop.http.TestSSLHttpServer
            hadoop.security.ssl.TestSSLFactory
            hadoop.security.ssl.TestReloadingX509TrustManager
            hadoop.io.TestUTF8
            hadoop.http.TestHttpCookieFlag
          JDK v1.7.0_111 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:44eef0e
          JIRA Issue HADOOP-13579
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827489/HADOOP-13579-branch-2.6.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e69121de7ad7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.6 / 3f87efc
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/branch-compile-root-jdk1.8.0_101.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/branch-compile-root-jdk1.7.0_111.txt
          findbugs v1.3.9
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/patch-compile-root-jdk1.8.0_101.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/patch-compile-root-jdk1.8.0_101.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/patch-compile-root-jdk1.7.0_111.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/patch-compile-root-jdk1.7.0_111.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 36s branch-2.6 passed -1 compile 1m 42s root in branch-2.6 failed with JDK v1.8.0_101. -1 compile 1m 49s root in branch-2.6 failed with JDK v1.7.0_111. +1 checkstyle 0m 25s branch-2.6 passed +1 mvnsite 0m 45s branch-2.6 passed +1 mvneclipse 0m 16s branch-2.6 passed -1 findbugs 1m 36s hadoop-common-project/hadoop-common in branch-2.6 has 66 extant Findbugs warnings. +1 javadoc 0m 51s branch-2.6 passed with JDK v1.8.0_101 +1 javadoc 1m 0s branch-2.6 passed with JDK v1.7.0_111 +1 mvninstall 0m 39s the patch passed -1 compile 1m 35s root in the patch failed with JDK v1.8.0_101. -1 javac 1m 35s root in the patch failed with JDK v1.8.0_101. -1 compile 1m 46s root in the patch failed with JDK v1.7.0_111. -1 javac 1m 46s root in the patch failed with JDK v1.7.0_111. +1 checkstyle 0m 19s the patch passed +1 mvnsite 0m 43s the patch passed +1 mvneclipse 0m 12s the patch passed -1 whitespace 0m 0s The patch has 2351 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 55s The patch 70 line(s) with tabs. +1 findbugs 1m 39s the patch passed +1 javadoc 0m 47s the patch passed with JDK v1.8.0_101 +1 javadoc 0m 58s the patch passed with JDK v1.7.0_111 -1 unit 6m 1s hadoop-common in the patch failed with JDK v1.7.0_111. -1 asflicense 0m 34s The patch generated 128 ASF License warnings. 39m 49s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.http.TestSSLHttpServer   hadoop.security.ssl.TestSSLFactory   hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.io.TestUTF8   hadoop.http.TestHttpCookieFlag JDK v1.7.0_111 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:44eef0e JIRA Issue HADOOP-13579 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827489/HADOOP-13579-branch-2.6.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e69121de7ad7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6 / 3f87efc Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/branch-compile-root-jdk1.8.0_101.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/branch-compile-root-jdk1.7.0_111.txt findbugs v1.3.9 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/patch-compile-root-jdk1.8.0_101.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/patch-compile-root-jdk1.8.0_101.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/patch-compile-root-jdk1.7.0_111.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/patch-compile-root-jdk1.7.0_111.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10460/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1. Thanks Tsuyoshi Ozawa and Masatake Iwasaki.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1. Thanks Tsuyoshi Ozawa and Masatake Iwasaki .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to branch-2.7 and branch-2.6. Thanks Tsuyoshi Ozawa, Masatake Iwasaki, and Chiwan Park!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to branch-2.7 and branch-2.6. Thanks Tsuyoshi Ozawa , Masatake Iwasaki , and Chiwan Park !
          Hide
          djp Junping Du added a comment - - edited

          Hi Tsuyoshi Ozawa and Akira Ajisaka, I think this patch need to be backport to 2.8 and branch-2. Isn't it? Do we have special reason not to do so?

          Show
          djp Junping Du added a comment - - edited Hi Tsuyoshi Ozawa and Akira Ajisaka , I think this patch need to be backport to 2.8 and branch-2. Isn't it? Do we have special reason not to do so?

            People

            • Assignee:
              ozawa Tsuyoshi Ozawa
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development