Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11252

RPC client does not time out by default

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 2.5.0
    • 2.8.0, 2.7.3, 2.6.4, 3.0.0-alpha1
    • ipc
    • None
    • Incompatible change, Reviewed
    • Hide
      This fix includes public method interface change.
      A follow-up JIRA issue for this incompatibility for branch-2.7 is HADOOP-13579.
      Show
      This fix includes public method interface change. A follow-up JIRA issue for this incompatibility for branch-2.7 is HADOOP-13579 .

    Description

      The RPC client has a default timeout set to 0 when no timeout is passed in. This means that the network connection created will not timeout when used to write data. The issue has shown in YARN-2578 and HDFS-4858. Timeouts for writes then fall back to the tcp level retry (configured via tcp_retries2) and timeouts between the 15-30 minutes. Which is too long for a default behaviour.

      Using 0 as the default value for timeout is incorrect. We should use a sane value for the timeout and the "ipc.ping.interval" configuration value is a logical choice for it. The default behaviour should be changed from 0 to the value read for the ping interval from the Configuration.

      Fixing it in common makes more sense than finding and changing all other points in the code that do not pass in a timeout.

      Offending code lines:
      https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java#L488
      and
      https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java#L350

      Attachments

        1. HADOOP-11252.patch
          5 kB
          wilfreds#1
        2. HADOOP-11252.002.patch
          10 kB
          Masatake Iwasaki
        3. HADOOP-11252.003.patch
          9 kB
          Masatake Iwasaki
        4. HADOOP-11252.004.patch
          9 kB
          Masatake Iwasaki

        Issue Links

          Activity

            People

              iwasakims Masatake Iwasaki
              wilfreds Wilfred Spiegelenburg
              Votes:
              2 Vote for this issue
              Watchers:
              34 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: