Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12843

Fix findbugs warnings in hadoop-common (branch-2)

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0
    • Component/s: None
    • Labels:
    • Target Version/s:

      Description

      There are 5 findbugs warnings in branch-2.

      1. findbugsHtml.html
        9 kB
        Akira Ajisaka
      2. HADOOP-12843.branch-2.01.patch
        5 kB
        Akira Ajisaka
      3. HADOOP-12843.branch-2.02.patch
        8 kB
        Akira Ajisaka

        Issue Links

          Activity

          Hide
          ajisakaa Akira Ajisaka added a comment -

          1 warning was fixed in trunk by HADOOP-8818. I'll pull this to branch-2, 2.8, and 2.7.

          Show
          ajisakaa Akira Ajisaka added a comment - 1 warning was fixed in trunk by HADOOP-8818 . I'll pull this to branch-2, 2.8, and 2.7.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Backported HADOOP-8818 to branch-2, 2.8, and 2.7. Now there are 4 findbugs warnings.

          Show
          ajisakaa Akira Ajisaka added a comment - Backported HADOOP-8818 to branch-2, 2.8, and 2.7. Now there are 4 findbugs warnings.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Also, 1 warning was fixed in trunk by HADOOP-9121. I'll pull this as well.

          Show
          ajisakaa Akira Ajisaka added a comment - Also, 1 warning was fixed in trunk by HADOOP-9121 . I'll pull this as well.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Backported HADOOP-9121 to branch-2, 2.8, and 2.7. Now there are 3 warnings.

          Show
          ajisakaa Akira Ajisaka added a comment - Backported HADOOP-9121 to branch-2, 2.8, and 2.7. Now there are 3 warnings.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 10m 51s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 43s branch-2 passed
          +1 compile 5m 19s branch-2 passed with JDK v1.8.0_72
          +1 compile 6m 21s branch-2 passed with JDK v1.7.0_95
          +1 checkstyle 0m 23s branch-2 passed
          +1 mvnsite 0m 49s branch-2 passed
          +1 mvneclipse 0m 17s branch-2 passed
          -1 findbugs 1m 46s hadoop-common-project/hadoop-common in branch-2 has 3 extant Findbugs warnings.
          +1 javadoc 0m 54s branch-2 passed with JDK v1.8.0_72
          +1 javadoc 1m 4s branch-2 passed with JDK v1.7.0_95
          +1 mvninstall 0m 41s the patch passed
          +1 compile 5m 28s the patch passed with JDK v1.8.0_72
          +1 javac 5m 28s the patch passed
          +1 compile 6m 21s the patch passed with JDK v1.7.0_95
          +1 javac 6m 21s the patch passed
          -1 checkstyle 0m 21s hadoop-common-project/hadoop-common: patch generated 2 new + 69 unchanged - 2 fixed = 71 total (was 71)
          +1 mvnsite 0m 45s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 0s The patch has 61 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 1m 53s hadoop-common-project/hadoop-common generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3)
          +1 javadoc 0m 55s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95
          +1 unit 6m 43s hadoop-common in the patch passed with JDK v1.8.0_72.
          +1 unit 7m 3s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          69m 31s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:babe025
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790397/HADOOP-12843.branch-2.01.patch
          JIRA Issue HADOOP-12843
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1e28983045c4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 2a1bb6c
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8740/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8740/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8740/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8740/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8740/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 51s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 43s branch-2 passed +1 compile 5m 19s branch-2 passed with JDK v1.8.0_72 +1 compile 6m 21s branch-2 passed with JDK v1.7.0_95 +1 checkstyle 0m 23s branch-2 passed +1 mvnsite 0m 49s branch-2 passed +1 mvneclipse 0m 17s branch-2 passed -1 findbugs 1m 46s hadoop-common-project/hadoop-common in branch-2 has 3 extant Findbugs warnings. +1 javadoc 0m 54s branch-2 passed with JDK v1.8.0_72 +1 javadoc 1m 4s branch-2 passed with JDK v1.7.0_95 +1 mvninstall 0m 41s the patch passed +1 compile 5m 28s the patch passed with JDK v1.8.0_72 +1 javac 5m 28s the patch passed +1 compile 6m 21s the patch passed with JDK v1.7.0_95 +1 javac 6m 21s the patch passed -1 checkstyle 0m 21s hadoop-common-project/hadoop-common: patch generated 2 new + 69 unchanged - 2 fixed = 71 total (was 71) +1 mvnsite 0m 45s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 61 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 1m 53s hadoop-common-project/hadoop-common generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3) +1 javadoc 0m 55s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95 +1 unit 6m 43s hadoop-common in the patch passed with JDK v1.8.0_72. +1 unit 7m 3s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 69m 31s Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790397/HADOOP-12843.branch-2.01.patch JIRA Issue HADOOP-12843 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1e28983045c4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 2a1bb6c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8740/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8740/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8740/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8740/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8740/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -
          1. checkstyle warnings are method len; spurious.
          2. why two nested try-with-resources, instead of one with multiple stream openings in the try() clause?
          Show
          stevel@apache.org Steve Loughran added a comment - checkstyle warnings are method len; spurious. why two nested try-with-resources, instead of one with multiple stream openings in the try() clause?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          why two nested try-with-resources, instead of one with multiple stream openings in the try() clause?

          Nice catch. Simply I forgot to merge two try-with-resources.

          Show
          ajisakaa Akira Ajisaka added a comment - why two nested try-with-resources, instead of one with multiple stream openings in the try() clause? Nice catch. Simply I forgot to merge two try-with-resources.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Updated the patch.

          Show
          ajisakaa Akira Ajisaka added a comment - Updated the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 59s branch-2 passed
          +1 compile 6m 3s branch-2 passed with JDK v1.8.0_72
          +1 compile 6m 49s branch-2 passed with JDK v1.7.0_95
          +1 checkstyle 0m 23s branch-2 passed
          +1 mvnsite 0m 50s branch-2 passed
          +1 mvneclipse 0m 14s branch-2 passed
          -1 findbugs 1m 42s hadoop-common-project/hadoop-common in branch-2 has 3 extant Findbugs warnings.
          +1 javadoc 0m 57s branch-2 passed with JDK v1.8.0_72
          +1 javadoc 1m 7s branch-2 passed with JDK v1.7.0_95
          +1 mvninstall 0m 43s the patch passed
          +1 compile 5m 57s the patch passed with JDK v1.8.0_72
          -1 javac 10m 39s root-jdk1.8.0_72 with JDK v1.8.0_72 generated 3 new + 786 unchanged - 3 fixed = 789 total (was 789)
          +1 javac 5m 57s the patch passed
          +1 compile 6m 42s the patch passed with JDK v1.7.0_95
          -1 javac 17m 21s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 3 new + 869 unchanged - 3 fixed = 872 total (was 872)
          +1 javac 6m 42s the patch passed
          -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 8 new + 63 unchanged - 8 fixed = 71 total (was 71)
          +1 mvnsite 0m 50s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 0s The patch has 61 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 1m 58s hadoop-common-project/hadoop-common generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3)
          +1 javadoc 0m 57s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 10s the patch passed with JDK v1.7.0_95
          +1 unit 8m 16s hadoop-common in the patch passed with JDK v1.8.0_72.
          +1 unit 8m 23s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          62m 23s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:babe025
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790484/HADOOP-12843.branch-2.02.patch
          JIRA Issue HADOOP-12843
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6d5f9fd491cb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 531a081
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8743/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          javac root-jdk1.8.0_72: https://builds.apache.org/job/PreCommit-HADOOP-Build/8743/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_72.txt
          javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8743/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8743/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8743/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8743/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8743/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 59s branch-2 passed +1 compile 6m 3s branch-2 passed with JDK v1.8.0_72 +1 compile 6m 49s branch-2 passed with JDK v1.7.0_95 +1 checkstyle 0m 23s branch-2 passed +1 mvnsite 0m 50s branch-2 passed +1 mvneclipse 0m 14s branch-2 passed -1 findbugs 1m 42s hadoop-common-project/hadoop-common in branch-2 has 3 extant Findbugs warnings. +1 javadoc 0m 57s branch-2 passed with JDK v1.8.0_72 +1 javadoc 1m 7s branch-2 passed with JDK v1.7.0_95 +1 mvninstall 0m 43s the patch passed +1 compile 5m 57s the patch passed with JDK v1.8.0_72 -1 javac 10m 39s root-jdk1.8.0_72 with JDK v1.8.0_72 generated 3 new + 786 unchanged - 3 fixed = 789 total (was 789) +1 javac 5m 57s the patch passed +1 compile 6m 42s the patch passed with JDK v1.7.0_95 -1 javac 17m 21s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 3 new + 869 unchanged - 3 fixed = 872 total (was 872) +1 javac 6m 42s the patch passed -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 8 new + 63 unchanged - 8 fixed = 71 total (was 71) +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 61 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 1m 58s hadoop-common-project/hadoop-common generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3) +1 javadoc 0m 57s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 10s the patch passed with JDK v1.7.0_95 +1 unit 8m 16s hadoop-common in the patch passed with JDK v1.8.0_72. +1 unit 8m 23s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 62m 23s Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790484/HADOOP-12843.branch-2.02.patch JIRA Issue HADOOP-12843 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6d5f9fd491cb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 531a081 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8743/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html javac root-jdk1.8.0_72: https://builds.apache.org/job/PreCommit-HADOOP-Build/8743/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_72.txt javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8743/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8743/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8743/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8743/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8743/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          LGTM
          +1

          Show
          stevel@apache.org Steve Loughran added a comment - LGTM +1
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to branch-2 and branch-2.8. Thanks Steve Loughran for your review!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to branch-2 and branch-2.8. Thanks Steve Loughran for your review!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9401 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9401/)
          Add HADOOP-12843 to 2.8.0 in CHANGES.txt. (aajisaka: rev 44d9bac1f58ae64b8a62a197df790e63ec912a72)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9401 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9401/ ) Add HADOOP-12843 to 2.8.0 in CHANGES.txt. (aajisaka: rev 44d9bac1f58ae64b8a62a197df790e63ec912a72) hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              ajisakaa Akira Ajisaka
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development