Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8818

Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
    • Component/s: fs, io
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper.

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12545319/HADOOP-8818.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1474//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/1474//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1474//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12545319/HADOOP-8818.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1474//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/1474//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1474//console This message is automatically generated.
          Hide
          sureshms Suresh Srinivas added a comment - - edited

          +1 for the patch. Created HADOOP-8821 to track the findbugs issue.

          Show
          sureshms Suresh Srinivas added a comment - - edited +1 for the patch. Created HADOOP-8821 to track the findbugs issue.
          Hide
          sureshms Suresh Srinivas added a comment -

          I committed the patch to trunk. Thank you Brandon.

          Show
          sureshms Suresh Srinivas added a comment - I committed the patch to trunk. Thank you Brandon.
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2734 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2734/)
          HADOOP-8818. Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. (Revision 1385374)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385374
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2734 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2734/ ) HADOOP-8818 . Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. (Revision 1385374) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385374 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2797 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2797/)
          HADOOP-8818. Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. (Revision 1385374)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385374
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2797 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2797/ ) HADOOP-8818 . Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. (Revision 1385374) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385374 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2758 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2758/)
          HADOOP-8818. Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. (Revision 1385374)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385374
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2758 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2758/ ) HADOOP-8818 . Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. (Revision 1385374) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385374 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1168 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1168/)
          HADOOP-8818. Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. (Revision 1385374)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385374
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1168 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1168/ ) HADOOP-8818 . Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. (Revision 1385374) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385374 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1199 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1199/)
          HADOOP-8818. Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. (Revision 1385374)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385374
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1199 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1199/ ) HADOOP-8818 . Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. (Revision 1385374) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385374 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Backporting this issue to branch-2, 2.8, 2.7 to fix HADOOP-12843.

          Show
          ajisakaa Akira Ajisaka added a comment - Backporting this issue to branch-2, 2.8, 2.7 to fix HADOOP-12843 .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Backported this to branch-2, branch-2.8, and branch-2.7.

          Show
          ajisakaa Akira Ajisaka added a comment - Backported this to branch-2, branch-2.8, and branch-2.7.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9373 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9373/)
          Moved HADOOP-8818 from 3.0.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev f0de733ca04332aed7b455b34e8c954588600a24)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9373 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9373/ ) Moved HADOOP-8818 from 3.0.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev f0de733ca04332aed7b455b34e8c954588600a24) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

            People

            • Assignee:
              brandonli Brandon Li
              Reporter:
              brandonli Brandon Li
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development