Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9121

InodeTree.java has redundant check for vName while throwing exception

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      337	    if (!gotMountTableEntry) {
      338	      throw new IOException(
      339	          "ViewFs: Cannot initialize: Empty Mount table in config for " + 
      340	             vName == null ? "viewfs:///" : ("viewfs://" + vName + "/"));
      341	    }
      

      The vName is always non-null due to checks/assignments done prior to this code segment.

      1. HDFS-4280_trunk_1.patch
        1 kB
        Arup Malakar
      2. HDFS-4280_trunk.patch
        0.9 kB
        Arup Malakar

        Issue Links

          Activity

          Hide
          sureshms Suresh Srinivas added a comment -

          +1 for the change. Since you are in that part of the code, can you also do the following:

          • resolveInternal should not throw FileNotFoundException
          Show
          sureshms Suresh Srinivas added a comment - +1 for the change. Since you are in that part of the code, can you also do the following: resolveInternal should not throw FileNotFoundException
          Hide
          amalakar Arup Malakar added a comment -

          Sure, removed the unnecessary throw statement.

          Show
          amalakar Arup Malakar added a comment - Sure, removed the unnecessary throw statement.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12556179/HDFS-4280_trunk_1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3606//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3606//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12556179/HDFS-4280_trunk_1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3606//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3606//console This message is automatically generated.
          Hide
          sureshms Suresh Srinivas added a comment -

          +1. I committed the patch to trunk. Thank you Arup.

          Show
          sureshms Suresh Srinivas added a comment - +1. I committed the patch to trunk. Thank you Arup.
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #3092 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3092/)
          HADOOP-9121. InodeTree.java has redundant check for vName while throwing exception. Contributed by Arup Malakar. (Revision 1418005)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418005
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-trunk-Commit #3092 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3092/ ) HADOOP-9121 . InodeTree.java has redundant check for vName while throwing exception. Contributed by Arup Malakar. (Revision 1418005) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418005 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #58 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/58/)
          HADOOP-9121. InodeTree.java has redundant check for vName while throwing exception. Contributed by Arup Malakar. (Revision 1418005)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418005
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Yarn-trunk #58 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/58/ ) HADOOP-9121 . InodeTree.java has redundant check for vName while throwing exception. Contributed by Arup Malakar. (Revision 1418005) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418005 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1247 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1247/)
          HADOOP-9121. InodeTree.java has redundant check for vName while throwing exception. Contributed by Arup Malakar. (Revision 1418005)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418005
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1247 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1247/ ) HADOOP-9121 . InodeTree.java has redundant check for vName while throwing exception. Contributed by Arup Malakar. (Revision 1418005) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418005 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1278 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1278/)
          HADOOP-9121. InodeTree.java has redundant check for vName while throwing exception. Contributed by Arup Malakar. (Revision 1418005)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418005
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1278 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1278/ ) HADOOP-9121 . InodeTree.java has redundant check for vName while throwing exception. Contributed by Arup Malakar. (Revision 1418005) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418005 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Cherry-picked this to branch-2, branch-2.8, and branch-2.7 to fix HADOOP-12843.

          Show
          ajisakaa Akira Ajisaka added a comment - Cherry-picked this to branch-2, branch-2.8, and branch-2.7 to fix HADOOP-12843 .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9389 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9389/)
          Move HADOOP-9121 from 3.0.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev e3ac231f7267d8e352d2c4f39f8c5c0199e47c0c)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9389 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9389/ ) Move HADOOP-9121 from 3.0.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev e3ac231f7267d8e352d2c4f39f8c5c0199e47c0c) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

            People

            • Assignee:
              amalakar Arup Malakar
              Reporter:
              amalakar Arup Malakar
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development