Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12818

Deprecate RPC#waitForProxy and cleanup

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Copied comment from HADOOP-12579:

      RPC#waitForProxy method family may also be deprecated, considering:
      We probably never need to wait, giving current available engines. The proxy can be created and returned on demand shortly. No network connection is incurred.
      In the real implementation codes of waitForProtocolProxy, it uses a while loop to try and try until a passed timeout value is consumed. I guess the logic and codes were from early days of the project? Because no connection is made during the proxy creating and initializing. The real network connection is only made when the invoker is invoked and a RPC call is called.
      Most places call RPC#getProxy already.
      Not sure to remove these, considering codes out of Hadoop might call them. But deprecate them should be fine and change the implementation removing the while loop and timeout stuffs.

      As Steve Loughran commented, considering there may be downstream applications that call the APIs, better just to deprecate them even they're obsolete now.

        Attachments

        1. HADOOP-12818-v1.patch
          13 kB
          Kai Zheng

          Issue Links

            Activity

              People

              • Assignee:
                drankye Kai Zheng
                Reporter:
                drankye Kai Zheng
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: