Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12818

Deprecate RPC#waitForProxy and cleanup

Add voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Patch Available
    • Major
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      Copied comment from HADOOP-12579:

      RPC#waitForProxy method family may also be deprecated, considering:
      We probably never need to wait, giving current available engines. The proxy can be created and returned on demand shortly. No network connection is incurred.
      In the real implementation codes of waitForProtocolProxy, it uses a while loop to try and try until a passed timeout value is consumed. I guess the logic and codes were from early days of the project? Because no connection is made during the proxy creating and initializing. The real network connection is only made when the invoker is invoked and a RPC call is called.
      Most places call RPC#getProxy already.
      Not sure to remove these, considering codes out of Hadoop might call them. But deprecate them should be fine and change the implementation removing the while loop and timeout stuffs.

      As Steve Loughran commented, considering there may be downstream applications that call the APIs, better just to deprecate them even they're obsolete now.

      Attachments

        1. HADOOP-12818-v1.patch
          13 kB
          Kai Zheng

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            drankye Kai Zheng
            drankye Kai Zheng

            Dates

              Created:
              Updated:

              Slack

                Issue deployment