Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None

      Description

      The WriteableRPCEninge depends on Java's serialization mechanisms for RPC requests. Without proper checks, it has be shown that it can lead to security vulnerabilities such as remote code execution (e.g., COLLECTIONS-580, HADOOP-12577).

      The current implementation has migrated from WriteableRPCEngine to ProtobufRPCEngine now. This jira proposes to deprecate WriteableRPCEngine in branch-2 and to remove it in trunk.

      1. HADOOP-12579-v1.patch
        61 kB
        Kai Zheng
      2. HADOOP-12579-v10.patch
        103 kB
        Kai Zheng
      3. HADOOP-12579-v11.patch
        103 kB
        Kai Zheng
      4. HADOOP-12579-v12.patch
        1 kB
        Wei Zhou
      5. HADOOP-12579-v3.patch
        86 kB
        Kai Zheng
      6. HADOOP-12579-v4.patch
        65 kB
        Kai Zheng
      7. HADOOP-12579-v5.patch
        99 kB
        Kai Zheng
      8. HADOOP-12579-v6.patch
        101 kB
        Kai Zheng
      9. HADOOP-12579-v7.patch
        101 kB
        Kai Zheng
      10. HADOOP-12579-v8.patch
        103 kB
        Kai Zheng
      11. HADOOP-12579-v9.patch
        103 kB
        Kai Zheng

        Issue Links

          Activity

          Hide
          cnauroth Chris Nauroth added a comment -

          +1 for the proposal.

          WritableRpcEngine can be a source of confusion for new development too if you're creating a new RPC service. The current code assumes WritableRpcEngine as the default. If you don't explicitly bind your new service to ProtobufRpcEngine, then the resulting error messages are unclear.

          Show
          cnauroth Chris Nauroth added a comment - +1 for the proposal. WritableRpcEngine can be a source of confusion for new development too if you're creating a new RPC service. The current code assumes WritableRpcEngine as the default. If you don't explicitly bind your new service to ProtobufRpcEngine , then the resulting error messages are unclear.
          Hide
          cmccabe Colin P. McCabe added a comment -

          +1 for the proposal.

          It would also be nice if we could get rid of the "wrapper objects" that we manually create, and just use the protocol buffers objects directly. HBase did this and observed a performance improvement based on reduced garbage being generated.

          Show
          cmccabe Colin P. McCabe added a comment - +1 for the proposal. It would also be nice if we could get rid of the "wrapper objects" that we manually create, and just use the protocol buffers objects directly. HBase did this and observed a performance improvement based on reduced garbage being generated.
          Hide
          drankye Kai Zheng added a comment -

          get rid of the "wrapper objects" that we manually create ...

          Did you mean the protocol buffer service translator stuffs like ClientDatanodeProtocolServerSideTranslatorPB and the related? If so, I guess the incurred overhead would be the added layer and additional call. For types involved in the RPC calling request and response, we still need convert back and forth between normal Java types and protocol buffer types for convenience, like even in HBase, because sometimes protocol buffer types would look intrusive to pass down and use. Sorry if I misunderstood your point.

          If just removes the old RPC engine, my quick trying looks like the involved change isn't big and the risk looks acceptable. Sure servers won't accept requests using the old RPC version from old clients.

          Show
          drankye Kai Zheng added a comment - get rid of the "wrapper objects" that we manually create ... Did you mean the protocol buffer service translator stuffs like ClientDatanodeProtocolServerSideTranslatorPB and the related? If so, I guess the incurred overhead would be the added layer and additional call. For types involved in the RPC calling request and response, we still need convert back and forth between normal Java types and protocol buffer types for convenience, like even in HBase, because sometimes protocol buffer types would look intrusive to pass down and use. Sorry if I misunderstood your point. If just removes the old RPC engine, my quick trying looks like the involved change isn't big and the risk looks acceptable. Sure servers won't accept requests using the old RPC version from old clients.
          Hide
          cmccabe Colin P. McCabe added a comment -

          If just removes the old RPC engine, my quick trying looks like the involved change isn't big and the risk looks acceptable. Sure servers won't accept requests using the old RPC version from old clients.

          Sure. We should probably remove the PB wrappers in a follow-on change rather than dealing with it here.

          Did you mean the protocol buffer service translator stuffs like ClientDatanodeProtocolServerSideTranslatorPB and the related? If so, I guess the incurred overhead would be the added layer and additional call. For types involved in the RPC calling request and response, we still need convert back and forth between normal Java types and protocol buffer types for convenience, like even in HBase, because sometimes protocol buffer types would look intrusive to pass down and use. Sorry if I misunderstood your point.

          While it may be desirable sometimes to translate protobuf types into something else, there are many more times when it's simpler and less error-prone just to use the types directly. The translation code is very verbose, which makes it inconvenient to add or change anything, and has been a source of bugs in the past when someone forgets to manually copy a field.

          Show
          cmccabe Colin P. McCabe added a comment - If just removes the old RPC engine, my quick trying looks like the involved change isn't big and the risk looks acceptable. Sure servers won't accept requests using the old RPC version from old clients. Sure. We should probably remove the PB wrappers in a follow-on change rather than dealing with it here. Did you mean the protocol buffer service translator stuffs like ClientDatanodeProtocolServerSideTranslatorPB and the related? If so, I guess the incurred overhead would be the added layer and additional call. For types involved in the RPC calling request and response, we still need convert back and forth between normal Java types and protocol buffer types for convenience, like even in HBase, because sometimes protocol buffer types would look intrusive to pass down and use. Sorry if I misunderstood your point. While it may be desirable sometimes to translate protobuf types into something else, there are many more times when it's simpler and less error-prone just to use the types directly. The translation code is very verbose, which makes it inconvenient to add or change anything, and has been a source of bugs in the past when someone forgets to manually copy a field.
          Hide
          drankye Kai Zheng added a comment -

          Sure. We should probably remove the PB wrappers in a follow-on change rather than dealing with it here.

          Thanks for the confirm. I'd like to sort my quick trying out and provide a patch for some comments.

          there are many more times when it's simpler and less error-prone just to use the types directly. The translation code is very verbose, which makes it inconvenient to add or change anything, and has been a source of bugs in the past when someone forgets to manually copy a field.

          I agree. The manual copy particularly for complex and deep structures is error-prone with no mechanisms like tests to guard. Would explore some bit in this direction, and probably find a small place for the initial prototype to see the effect, considering the change and impact is overall large.

          Show
          drankye Kai Zheng added a comment - Sure. We should probably remove the PB wrappers in a follow-on change rather than dealing with it here. Thanks for the confirm. I'd like to sort my quick trying out and provide a patch for some comments. there are many more times when it's simpler and less error-prone just to use the types directly. The translation code is very verbose, which makes it inconvenient to add or change anything, and has been a source of bugs in the past when someone forgets to manually copy a field. I agree. The manual copy particularly for complex and deep structures is error-prone with no mechanisms like tests to guard. Would explore some bit in this direction, and probably find a small place for the initial prototype to see the effect, considering the change and impact is overall large.
          Hide
          drankye Kai Zheng added a comment -

          Uploaded the initial patch according to above discussions:

          • Removed WritableRpcEngine from production codes to test, considering there are still many valuable tests using it.
          • As Chris Nauroth said, made the default RPC engine as ProtobufRpcEngine instead of WritableRpcEngine. The effect might be what we really want to achieve here. So now to use WritableRpcEngine (now only possible in tests), it must explicitly call RPC#setProtocolEngine first.
          • Updated the tests explicitly using WritableRpcEngine, to keep the original test behaviour. Some of these tests are still valuable because they test some other IPC aspects, and for such, we may port them to use protocol buffer as follow on tasks; some of them may be abandoned.

          Would suggest we still keep the engine in test scope and the related test codes, anyhow, we still keep the RPC_BUILTIN kind.

          Very probably missed some places to clean up, please kindly point out. Have run all the IPC tests locally.

          Not sure how to deprecate it for 2.6 branch yet, in addition to annotating the class with deprecated.

          Show
          drankye Kai Zheng added a comment - Uploaded the initial patch according to above discussions: Removed WritableRpcEngine from production codes to test, considering there are still many valuable tests using it. As Chris Nauroth said, made the default RPC engine as ProtobufRpcEngine instead of WritableRpcEngine. The effect might be what we really want to achieve here. So now to use WritableRpcEngine (now only possible in tests), it must explicitly call RPC#setProtocolEngine first. Updated the tests explicitly using WritableRpcEngine, to keep the original test behaviour. Some of these tests are still valuable because they test some other IPC aspects, and for such, we may port them to use protocol buffer as follow on tasks; some of them may be abandoned. Would suggest we still keep the engine in test scope and the related test codes, anyhow, we still keep the RPC_BUILTIN kind. Very probably missed some places to clean up, please kindly point out. Have run all the IPC tests locally. Not sure how to deprecate it for 2.6 branch yet, in addition to annotating the class with deprecated .
          Hide
          wheat9 Haohui Mai added a comment -

          I consider WritableRPCEngine is dead code. I suggest cleaning up the tests instead of putting a major functionality (WirtableRPCEngine in the tests.

          Show
          wheat9 Haohui Mai added a comment - I consider WritableRPCEngine is dead code. I suggest cleaning up the tests instead of putting a major functionality ( WirtableRPCEngine in the tests.
          Hide
          drankye Kai Zheng added a comment -

          Sure Haohui Mai I can do that, porting the test codes that are still valuable to the protocol buffer engine and getting away those useless. Thanks!

          Show
          drankye Kai Zheng added a comment - Sure Haohui Mai I can do that, porting the test codes that are still valuable to the protocol buffer engine and getting away those useless. Thanks!
          Hide
          drankye Kai Zheng added a comment -

          Ping Daryn Sharp in case I missed more points.

          Show
          drankye Kai Zheng added a comment - Ping Daryn Sharp in case I missed more points.
          Hide
          drankye Kai Zheng added a comment -

          While working on this, getting rid of the engine completely, I found the RPC#waitForProxy method family may also be deprecated, considering:

          • We probably never need to wait, giving current available engines. The proxy can be created and returned on demand shortly. No network connection is incurred.
          • In the real implementation codes of waitForProtocolProxy, it uses a while loop to try and try until a passed timeout value is consumed. I guess the logic and codes were from early days of the project? Because no connection is made during the proxy creating and initializing. The real network connection is only made when the invoker is invoked and a RPC call is called.
          • Most places call RPC#getProxy already.
          • Not sure to remove these, considering codes out of Hadoop might call them. But deprecate them should be fine and change the implementation removing the while loop and timeout stuffs.

          Please help confirm, if sounds good I'll handle it here or separately. Thanks.

          Show
          drankye Kai Zheng added a comment - While working on this, getting rid of the engine completely, I found the RPC#waitForProxy method family may also be deprecated, considering: We probably never need to wait, giving current available engines. The proxy can be created and returned on demand shortly. No network connection is incurred. In the real implementation codes of waitForProtocolProxy, it uses a while loop to try and try until a passed timeout value is consumed. I guess the logic and codes were from early days of the project? Because no connection is made during the proxy creating and initializing. The real network connection is only made when the invoker is invoked and a RPC call is called. Most places call RPC#getProxy already. Not sure to remove these, considering codes out of Hadoop might call them. But deprecate them should be fine and change the implementation removing the while loop and timeout stuffs. Please help confirm, if sounds good I'll handle it here or separately. Thanks.
          Hide
          drankye Kai Zheng added a comment -

          Steve Loughran, do you agree RPC#waitForProxy can be retired as well as commented above? Thanks!

          Show
          drankye Kai Zheng added a comment - Steve Loughran , do you agree RPC#waitForProxy can be retired as well as commented above? Thanks!
          Hide
          stevel@apache.org Steve Loughran added a comment -

          I'm always worried about cutting things, generally you need to have half the hadoop codebase in your IDE to find out where stuff gets picked up. Or comment it out and do a full stack test run, but that leads to upset people downstream.

          Sounds like tagging as deprecated is the strategy for now

          Show
          stevel@apache.org Steve Loughran added a comment - I'm always worried about cutting things, generally you need to have half the hadoop codebase in your IDE to find out where stuff gets picked up. Or comment it out and do a full stack test run, but that leads to upset people downstream. Sounds like tagging as deprecated is the strategy for now
          Hide
          drankye Kai Zheng added a comment -

          Thanks Steve for the thoughts!

          Sounds like tagging as deprecated is the strategy for now

          OK, I'll just do it for now here, and do not clean up the large block of obsolete codes in RPC#waitForProxy even nothing needs to wait in fact.

          Show
          drankye Kai Zheng added a comment - Thanks Steve for the thoughts! Sounds like tagging as deprecated is the strategy for now OK, I'll just do it for now here, and do not clean up the large block of obsolete codes in RPC#waitForProxy even nothing needs to wait in fact.
          Hide
          drankye Kai Zheng added a comment -

          I'm migrating the RPC tests that bases on the WriteableRPCEngine to base them on the protocol buffer one. There are quite a few of tests to do. I have get TestRPC done and the resultant patch looks rather large (100k+). Other tests like TestSaslRPC, TestRPCCompatibility and etc. are under the way. Will break this down and file separate issues to submit the test work first. When all the still valuable tests are rebased on the protocol buffer engine, then it will be simply easy to get rid of the obsolete engine.

          Show
          drankye Kai Zheng added a comment - I'm migrating the RPC tests that bases on the WriteableRPCEngine to base them on the protocol buffer one. There are quite a few of tests to do. I have get TestRPC done and the resultant patch looks rather large (100k+). Other tests like TestSaslRPC , TestRPCCompatibility and etc. are under the way. Will break this down and file separate issues to submit the test work first. When all the still valuable tests are rebased on the protocol buffer engine, then it will be simply easy to get rid of the obsolete engine.
          Hide
          drankye Kai Zheng added a comment -

          Patch for HADOOP-12813 (migrating TestRPC and related codes to rebase on ProtobufRpcEngine) was ready. Would anyone help do a review? Following on tasks are relying on it. Thanks a lot.

          Show
          drankye Kai Zheng added a comment - Patch for HADOOP-12813 (migrating TestRPC and related codes to rebase on ProtobufRpcEngine) was ready. Would anyone help do a review? Following on tasks are relying on it. Thanks a lot.
          Hide
          drankye Kai Zheng added a comment -

          Note HADOOP-12819 is ready for review. When it's in, I thought all the left test migrating work plus the removal of the old engine can be done here in a patch in reasonable size.

          Show
          drankye Kai Zheng added a comment - Note HADOOP-12819 is ready for review. When it's in, I thought all the left test migrating work plus the removal of the old engine can be done here in a patch in reasonable size.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch.

          I don't migrate most of the tests in TestMultipleProtocolServer and TestRPCCompatibility because I don't see much value of the re-implementing them using protocol buffer engine. Please kindly review and give your opinions. Thanks.

          Show
          drankye Kai Zheng added a comment - Updated the patch. I don't migrate most of the tests in TestMultipleProtocolServer and TestRPCCompatibility because I don't see much value of the re-implementing them using protocol buffer engine. Please kindly review and give your opinions. Thanks.
          Hide
          drankye Kai Zheng added a comment -

          Oops, I forgot to submit the patch, it's why no Jenkins was triggered.

          Show
          drankye Kai Zheng added a comment - Oops, I forgot to submit the patch, it's why no Jenkins was triggered.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch, rebased and clean up.

          Show
          drankye Kai Zheng added a comment - Updated the patch, rebased and clean up.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 36s trunk passed
          +1 compile 5m 57s trunk passed with JDK v1.8.0_77
          +1 compile 6m 44s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 9s trunk passed
          +1 mvnsite 2m 13s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 4m 2s trunk passed
          +1 javadoc 2m 14s trunk passed with JDK v1.8.0_77
          +1 javadoc 3m 8s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 45s the patch passed
          +1 compile 5m 50s the patch passed with JDK v1.8.0_77
          +1 javac 5m 50s the patch passed
          +1 compile 6m 41s the patch passed with JDK v1.7.0_95
          +1 javac 6m 41s the patch passed
          -1 checkstyle 1m 10s root: patch generated 3 new + 479 unchanged - 28 fixed = 482 total (was 507)
          +1 mvnsite 2m 9s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 39s the patch passed
          +1 javadoc 2m 8s the patch passed with JDK v1.8.0_77
          +1 javadoc 3m 7s the patch passed with JDK v1.7.0_95
          -1 unit 7m 7s hadoop-common in the patch failed with JDK v1.8.0_77.
          -1 unit 70m 3s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
          +1 unit 5m 38s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_77.
          -1 unit 8m 4s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 unit 68m 13s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 unit 5m 48s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          228m 20s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.ipc.TestRPCCallBenchmark
            hadoop.security.TestDoAsEffectiveUser
            hadoop.hdfs.TestReadStripedFileWithMissingBlocks
            hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
            hadoop.hdfs.security.TestClientProtocolWithDelegationToken
            hadoop.hdfs.TestHFlush
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
          JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile
            org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding
          JDK v1.7.0_95 Failed junit tests hadoop.ipc.TestRPCCallBenchmark
            hadoop.security.TestDoAsEffectiveUser
            hadoop.hdfs.TestParallelShortCircuitReadUnCached
            hadoop.hdfs.TestReadStripedFileWithMissingBlocks
            hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
            hadoop.hdfs.server.datanode.TestFsDatasetCacheRevocation
            hadoop.hdfs.security.TestClientProtocolWithDelegationToken
            hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
            hadoop.hdfs.TestHFlush
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile
            org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798920/HADOOP-12579-v4.patch
          JIRA Issue HADOOP-12579
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ba7cde98ec58 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6e6b6dd
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 36s trunk passed +1 compile 5m 57s trunk passed with JDK v1.8.0_77 +1 compile 6m 44s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 9s trunk passed +1 mvnsite 2m 13s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 4m 2s trunk passed +1 javadoc 2m 14s trunk passed with JDK v1.8.0_77 +1 javadoc 3m 8s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 45s the patch passed +1 compile 5m 50s the patch passed with JDK v1.8.0_77 +1 javac 5m 50s the patch passed +1 compile 6m 41s the patch passed with JDK v1.7.0_95 +1 javac 6m 41s the patch passed -1 checkstyle 1m 10s root: patch generated 3 new + 479 unchanged - 28 fixed = 482 total (was 507) +1 mvnsite 2m 9s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 39s the patch passed +1 javadoc 2m 8s the patch passed with JDK v1.8.0_77 +1 javadoc 3m 7s the patch passed with JDK v1.7.0_95 -1 unit 7m 7s hadoop-common in the patch failed with JDK v1.8.0_77. -1 unit 70m 3s hadoop-hdfs in the patch failed with JDK v1.8.0_77. +1 unit 5m 38s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_77. -1 unit 8m 4s hadoop-common in the patch failed with JDK v1.7.0_95. -1 unit 68m 13s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 unit 5m 48s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 228m 20s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.ipc.TestRPCCallBenchmark   hadoop.security.TestDoAsEffectiveUser   hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.security.TestClientProtocolWithDelegationToken   hadoop.hdfs.TestHFlush   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile   org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding JDK v1.7.0_95 Failed junit tests hadoop.ipc.TestRPCCallBenchmark   hadoop.security.TestDoAsEffectiveUser   hadoop.hdfs.TestParallelShortCircuitReadUnCached   hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.server.datanode.TestFsDatasetCacheRevocation   hadoop.hdfs.security.TestClientProtocolWithDelegationToken   hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade   hadoop.hdfs.TestHFlush   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile   org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798920/HADOOP-12579-v4.patch JIRA Issue HADOOP-12579 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ba7cde98ec58 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6e6b6dd Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9101/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch:

          • Fixed TestRPCCallBenchmark;
          • Fixed TestDoAsEffectiveUser;
          • Got rid of TestClientProtocolWithDelegationToken as it's hard to transform it and the test can be better done (in fact has already been done) using MiniDFSCluster.
          • Checked the check styles but they're not relevant or suitable to fixup;
          • More clean up.
          Show
          drankye Kai Zheng added a comment - Updated the patch: Fixed TestRPCCallBenchmark; Fixed TestDoAsEffectiveUser; Got rid of TestClientProtocolWithDelegationToken as it's hard to transform it and the test can be better done (in fact has already been done) using MiniDFSCluster. Checked the check styles but they're not relevant or suitable to fixup; More clean up.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 11 new or modified test files.
          0 mvndep 4m 12s Maven dependency ordering for branch
          +1 mvninstall 6m 26s trunk passed
          +1 compile 5m 34s trunk passed with JDK v1.8.0_77
          +1 compile 6m 33s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 11s trunk passed
          +1 mvnsite 2m 9s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 4m 3s trunk passed
          +1 javadoc 2m 9s trunk passed with JDK v1.8.0_77
          +1 javadoc 3m 3s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          -1 mvninstall 0m 33s hadoop-common in the patch failed.
          -1 compile 0m 45s root in the patch failed with JDK v1.8.0_77.
          -1 cc 0m 45s root in the patch failed with JDK v1.8.0_77.
          -1 javac 0m 45s root in the patch failed with JDK v1.8.0_77.
          -1 compile 0m 53s root in the patch failed with JDK v1.7.0_95.
          -1 cc 0m 53s root in the patch failed with JDK v1.7.0_95.
          -1 javac 0m 53s root in the patch failed with JDK v1.7.0_95.
          -1 checkstyle 1m 9s root: patch generated 3 new + 579 unchanged - 28 fixed = 582 total (was 607)
          -1 mvnsite 0m 36s hadoop-common in the patch failed.
          +1 mvneclipse 0m 34s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 0m 24s hadoop-common in the patch failed.
          +1 javadoc 2m 5s the patch passed with JDK v1.8.0_77
          +1 javadoc 2m 59s the patch passed with JDK v1.7.0_95
          -1 unit 0m 34s hadoop-common in the patch failed with JDK v1.8.0_77.
          -1 unit 55m 10s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
          +1 unit 5m 31s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_77.
          -1 unit 0m 43s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 unit 54m 55s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 unit 5m 53s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          175m 52s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.hdfs.TestHFlush
            hadoop.hdfs.TestDFSShell
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.TestDFSShell



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800405/HADOOP-12579-v5.patch
          JIRA Issue HADOOP-12579
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux fdd33d6174a0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6fcde2e
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-compile-root-jdk1.8.0_77.txt
          cc https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-compile-root-jdk1.8.0_77.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-compile-root-jdk1.8.0_77.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt
          cc https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/diff-checkstyle-root.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 11 new or modified test files. 0 mvndep 4m 12s Maven dependency ordering for branch +1 mvninstall 6m 26s trunk passed +1 compile 5m 34s trunk passed with JDK v1.8.0_77 +1 compile 6m 33s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 11s trunk passed +1 mvnsite 2m 9s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 4m 3s trunk passed +1 javadoc 2m 9s trunk passed with JDK v1.8.0_77 +1 javadoc 3m 3s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch -1 mvninstall 0m 33s hadoop-common in the patch failed. -1 compile 0m 45s root in the patch failed with JDK v1.8.0_77. -1 cc 0m 45s root in the patch failed with JDK v1.8.0_77. -1 javac 0m 45s root in the patch failed with JDK v1.8.0_77. -1 compile 0m 53s root in the patch failed with JDK v1.7.0_95. -1 cc 0m 53s root in the patch failed with JDK v1.7.0_95. -1 javac 0m 53s root in the patch failed with JDK v1.7.0_95. -1 checkstyle 1m 9s root: patch generated 3 new + 579 unchanged - 28 fixed = 582 total (was 607) -1 mvnsite 0m 36s hadoop-common in the patch failed. +1 mvneclipse 0m 34s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 0m 24s hadoop-common in the patch failed. +1 javadoc 2m 5s the patch passed with JDK v1.8.0_77 +1 javadoc 2m 59s the patch passed with JDK v1.7.0_95 -1 unit 0m 34s hadoop-common in the patch failed with JDK v1.8.0_77. -1 unit 55m 10s hadoop-hdfs in the patch failed with JDK v1.8.0_77. +1 unit 5m 31s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_77. -1 unit 0m 43s hadoop-common in the patch failed with JDK v1.7.0_95. -1 unit 54m 55s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 unit 5m 53s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 175m 52s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.TestDFSShell JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.TestDFSShell Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800405/HADOOP-12579-v5.patch JIRA Issue HADOOP-12579 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux fdd33d6174a0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6fcde2e Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-compile-root-jdk1.8.0_77.txt cc https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-compile-root-jdk1.8.0_77.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-compile-root-jdk1.8.0_77.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt cc https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/diff-checkstyle-root.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9164/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch, fixing a missed place.

          Show
          drankye Kai Zheng added a comment - Updated the patch, fixing a missed place.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
          0 mvndep 1m 10s Maven dependency ordering for branch
          +1 mvninstall 6m 27s trunk passed
          +1 compile 5m 39s trunk passed with JDK v1.8.0_77
          +1 compile 6m 32s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 11s trunk passed
          +1 mvnsite 2m 12s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 3m 58s trunk passed
          +1 javadoc 2m 9s trunk passed with JDK v1.8.0_77
          +1 javadoc 3m 5s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 44s the patch passed
          +1 compile 5m 34s the patch passed with JDK v1.8.0_77
          +1 cc 5m 34s the patch passed
          +1 javac 5m 34s the patch passed
          +1 compile 6m 33s the patch passed with JDK v1.7.0_95
          +1 cc 6m 33s the patch passed
          +1 javac 6m 33s the patch passed
          -1 checkstyle 1m 10s root: patch generated 3 new + 579 unchanged - 28 fixed = 582 total (was 607)
          +1 mvnsite 2m 8s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 39s the patch passed
          +1 javadoc 2m 11s the patch passed with JDK v1.8.0_77
          +1 javadoc 3m 5s the patch passed with JDK v1.7.0_95
          -1 unit 7m 19s hadoop-common in the patch failed with JDK v1.8.0_77.
          -1 unit 55m 34s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
          +1 unit 5m 31s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_77.
          -1 unit 7m 33s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 unit 52m 0s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 unit 5m 56s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          197m 1s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.ipc.TestSaslRPC
            hadoop.security.TestDoAsEffectiveUser
            hadoop.hdfs.TestDFSShell
            hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
          JDK v1.7.0_95 Failed junit tests hadoop.ipc.TestSaslRPC
            hadoop.security.TestDoAsEffectiveUser
            hadoop.hdfs.TestDFSShell
            hadoop.hdfs.TestHFlush



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800435/HADOOP-12579-v6.patch
          JIRA Issue HADOOP-12579
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux b68c0d526943 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6fcde2e
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 1m 10s Maven dependency ordering for branch +1 mvninstall 6m 27s trunk passed +1 compile 5m 39s trunk passed with JDK v1.8.0_77 +1 compile 6m 32s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 11s trunk passed +1 mvnsite 2m 12s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 3m 58s trunk passed +1 javadoc 2m 9s trunk passed with JDK v1.8.0_77 +1 javadoc 3m 5s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 44s the patch passed +1 compile 5m 34s the patch passed with JDK v1.8.0_77 +1 cc 5m 34s the patch passed +1 javac 5m 34s the patch passed +1 compile 6m 33s the patch passed with JDK v1.7.0_95 +1 cc 6m 33s the patch passed +1 javac 6m 33s the patch passed -1 checkstyle 1m 10s root: patch generated 3 new + 579 unchanged - 28 fixed = 582 total (was 607) +1 mvnsite 2m 8s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 39s the patch passed +1 javadoc 2m 11s the patch passed with JDK v1.8.0_77 +1 javadoc 3m 5s the patch passed with JDK v1.7.0_95 -1 unit 7m 19s hadoop-common in the patch failed with JDK v1.8.0_77. -1 unit 55m 34s hadoop-hdfs in the patch failed with JDK v1.8.0_77. +1 unit 5m 31s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_77. -1 unit 7m 33s hadoop-common in the patch failed with JDK v1.7.0_95. -1 unit 52m 0s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 unit 5m 56s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 197m 1s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.ipc.TestSaslRPC   hadoop.security.TestDoAsEffectiveUser   hadoop.hdfs.TestDFSShell   hadoop.hdfs.TestHFlush   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.shortcircuit.TestShortCircuitCache JDK v1.7.0_95 Failed junit tests hadoop.ipc.TestSaslRPC   hadoop.security.TestDoAsEffectiveUser   hadoop.hdfs.TestDFSShell   hadoop.hdfs.TestHFlush Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800435/HADOOP-12579-v6.patch JIRA Issue HADOOP-12579 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux b68c0d526943 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6fcde2e Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9166/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Fixed some failures.

          Show
          drankye Kai Zheng added a comment - Fixed some failures.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
          0 mvndep 0m 13s Maven dependency ordering for branch
          +1 mvninstall 6m 29s trunk passed
          +1 compile 5m 49s trunk passed with JDK v1.8.0_77
          +1 compile 6m 42s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 11s trunk passed
          +1 mvnsite 2m 9s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 4m 7s trunk passed
          +1 javadoc 2m 10s trunk passed with JDK v1.8.0_77
          +1 javadoc 3m 5s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 2m 6s the patch passed
          +1 compile 7m 16s the patch passed with JDK v1.8.0_77
          +1 cc 7m 16s the patch passed
          +1 javac 7m 16s the patch passed
          +1 compile 7m 24s the patch passed with JDK v1.7.0_95
          +1 cc 7m 24s the patch passed
          +1 javac 7m 24s the patch passed
          -1 checkstyle 1m 16s root: patch generated 3 new + 579 unchanged - 28 fixed = 582 total (was 607)
          +1 mvnsite 2m 17s the patch passed
          +1 mvneclipse 0m 43s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 57s the patch passed
          +1 javadoc 2m 21s the patch passed with JDK v1.8.0_77
          +1 javadoc 3m 17s the patch passed with JDK v1.7.0_95
          -1 unit 8m 33s hadoop-common in the patch failed with JDK v1.8.0_77.
          -1 unit 61m 3s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
          +1 unit 5m 34s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_77.
          +1 unit 8m 2s hadoop-common in the patch passed with JDK v1.7.0_95.
          -1 unit 54m 19s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 unit 5m 57s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          210m 5s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.hdfs.TestDFSShell
            hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.datanode.TestDataNodeUUID
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSShell
            hadoop.hdfs.TestHFlush



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800458/HADOOP-12579-v7.patch
          JIRA Issue HADOOP-12579
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 6dfe6aa12beb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6fcde2e
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 6m 29s trunk passed +1 compile 5m 49s trunk passed with JDK v1.8.0_77 +1 compile 6m 42s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 11s trunk passed +1 mvnsite 2m 9s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 4m 7s trunk passed +1 javadoc 2m 10s trunk passed with JDK v1.8.0_77 +1 javadoc 3m 5s trunk passed with JDK v1.7.0_95 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 2m 6s the patch passed +1 compile 7m 16s the patch passed with JDK v1.8.0_77 +1 cc 7m 16s the patch passed +1 javac 7m 16s the patch passed +1 compile 7m 24s the patch passed with JDK v1.7.0_95 +1 cc 7m 24s the patch passed +1 javac 7m 24s the patch passed -1 checkstyle 1m 16s root: patch generated 3 new + 579 unchanged - 28 fixed = 582 total (was 607) +1 mvnsite 2m 17s the patch passed +1 mvneclipse 0m 43s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 57s the patch passed +1 javadoc 2m 21s the patch passed with JDK v1.8.0_77 +1 javadoc 3m 17s the patch passed with JDK v1.7.0_95 -1 unit 8m 33s hadoop-common in the patch failed with JDK v1.8.0_77. -1 unit 61m 3s hadoop-hdfs in the patch failed with JDK v1.8.0_77. +1 unit 5m 34s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_77. +1 unit 8m 2s hadoop-common in the patch passed with JDK v1.7.0_95. -1 unit 54m 19s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 unit 5m 57s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 210m 5s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.hdfs.TestDFSShell   hadoop.hdfs.TestHFlush   hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSShell   hadoop.hdfs.TestHFlush Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800458/HADOOP-12579-v7.patch JIRA Issue HADOOP-12579 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 6dfe6aa12beb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6fcde2e Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9167/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          The failed tests are not relevant. The remained check styles are not suitable to be fixed.
          The patch is ready for review.

          Show
          drankye Kai Zheng added a comment - The failed tests are not relevant. The remained check styles are not suitable to be fixed. The patch is ready for review.
          Hide
          wheat9 Haohui Mai added a comment -
             RPC_WRITABLE ((short) 2),        // Use WritableRpcEngine,
          

          Is it possible to get rid of this? +1 once addressed.

          Show
          wheat9 Haohui Mai added a comment - RPC_WRITABLE (( short ) 2), // Use WritableRpcEngine, Is it possible to get rid of this? +1 once addressed.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch according to review comment.

          Show
          drankye Kai Zheng added a comment - Updated the patch according to review comment.
          Hide
          drankye Kai Zheng added a comment -

          Thanks Haohui Mai for the review! I thought it can be removed. In RpcHeader.proto, I made the simple change:

          /**
           * RpcKind determine the rpcEngine and the serialization of the rpc request
           */
          enum RpcKindProto {
            RPC_BUILTIN          = 0;  // Used for built in calls by tests
          -  RPC_WRITABLE         = 1;  // Use WritableRpcEngine 
          +  RPC_WRITABLE         = 1;  // Use WritableRpcEngine, the actual usage removed
            RPC_PROTOCOL_BUFFER  = 2;  // Use ProtobufRpcEngine
          }
          
          Show
          drankye Kai Zheng added a comment - Thanks Haohui Mai for the review! I thought it can be removed. In RpcHeader.proto , I made the simple change: /** * RpcKind determine the rpcEngine and the serialization of the rpc request */ enum RpcKindProto { RPC_BUILTIN = 0; // Used for built in calls by tests - RPC_WRITABLE = 1; // Use WritableRpcEngine + RPC_WRITABLE = 1; // Use WritableRpcEngine, the actual usage removed RPC_PROTOCOL_BUFFER = 2; // Use ProtobufRpcEngine }
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
          0 mvndep 6m 36s Maven dependency ordering for branch
          +1 mvninstall 7m 49s trunk passed
          +1 compile 5m 54s trunk passed with JDK v1.8.0_92
          +1 compile 6m 48s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 17s trunk passed
          +1 mvnsite 2m 19s trunk passed
          +1 mvneclipse 0m 47s trunk passed
          +1 findbugs 4m 14s trunk passed
          +1 javadoc 2m 17s trunk passed with JDK v1.8.0_92
          +1 javadoc 3m 7s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 46s the patch passed
          +1 compile 5m 52s the patch passed with JDK v1.8.0_92
          +1 cc 5m 52s the patch passed
          +1 javac 5m 52s the patch passed
          +1 compile 7m 2s the patch passed with JDK v1.7.0_95
          +1 cc 7m 2s the patch passed
          +1 javac 7m 2s the patch passed
          -1 checkstyle 1m 19s root: The patch generated 3 new + 590 unchanged - 28 fixed = 593 total (was 618)
          +1 mvnsite 2m 12s the patch passed
          +1 mvneclipse 0m 42s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 47s the patch passed
          +1 javadoc 2m 13s the patch passed with JDK v1.8.0_92
          +1 javadoc 3m 8s the patch passed with JDK v1.7.0_95
          -1 unit 16m 57s hadoop-common in the patch failed with JDK v1.8.0_92.
          -1 unit 59m 11s hadoop-hdfs in the patch failed with JDK v1.8.0_92.
          +1 unit 5m 36s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_92.
          +1 unit 8m 28s hadoop-common in the patch passed with JDK v1.7.0_95.
          -1 unit 55m 1s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 unit 5m 54s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          223m 44s



          Reason Tests
          JDK v1.8.0_92 Failed junit tests hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
          JDK v1.8.0_92 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800736/HADOOP-12579-v8.patch
          JIRA Issue HADOOP-12579
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux eeda0a28fa18 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a5fed8b
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 6m 36s Maven dependency ordering for branch +1 mvninstall 7m 49s trunk passed +1 compile 5m 54s trunk passed with JDK v1.8.0_92 +1 compile 6m 48s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 17s trunk passed +1 mvnsite 2m 19s trunk passed +1 mvneclipse 0m 47s trunk passed +1 findbugs 4m 14s trunk passed +1 javadoc 2m 17s trunk passed with JDK v1.8.0_92 +1 javadoc 3m 7s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 46s the patch passed +1 compile 5m 52s the patch passed with JDK v1.8.0_92 +1 cc 5m 52s the patch passed +1 javac 5m 52s the patch passed +1 compile 7m 2s the patch passed with JDK v1.7.0_95 +1 cc 7m 2s the patch passed +1 javac 7m 2s the patch passed -1 checkstyle 1m 19s root: The patch generated 3 new + 590 unchanged - 28 fixed = 593 total (was 618) +1 mvnsite 2m 12s the patch passed +1 mvneclipse 0m 42s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 47s the patch passed +1 javadoc 2m 13s the patch passed with JDK v1.8.0_92 +1 javadoc 3m 8s the patch passed with JDK v1.7.0_95 -1 unit 16m 57s hadoop-common in the patch failed with JDK v1.8.0_92. -1 unit 59m 11s hadoop-hdfs in the patch failed with JDK v1.8.0_92. +1 unit 5m 36s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_92. +1 unit 8m 28s hadoop-common in the patch passed with JDK v1.7.0_95. -1 unit 55m 1s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 unit 5m 54s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 223m 44s Reason Tests JDK v1.8.0_92 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl JDK v1.8.0_92 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800736/HADOOP-12579-v8.patch JIRA Issue HADOOP-12579 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux eeda0a28fa18 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a5fed8b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9182/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -
          enum RpcKindProto {
            RPC_BUILTIN          = 0;  // Used for built in calls by tests
          -  RPC_WRITABLE         = 1;  // Use WritableRpcEngine 
          +  RPC_WRITABLE         = 1;  // Use WritableRpcEngine, the actual usage removed
            RPC_PROTOCOL_BUFFER  = 2;  // Use ProtobufRpcEngine
          }
          

          Should be able to get rid of RPC_WRITABLE here as well?

          Show
          wheat9 Haohui Mai added a comment - enum RpcKindProto { RPC_BUILTIN = 0; // Used for built in calls by tests - RPC_WRITABLE = 1; // Use WritableRpcEngine + RPC_WRITABLE = 1; // Use WritableRpcEngine, the actual usage removed RPC_PROTOCOL_BUFFER = 2; // Use ProtobufRpcEngine } Should be able to get rid of RPC_WRITABLE here as well?
          Hide
          drankye Kai Zheng added a comment -

          Ok, I agree, since we remain the enum values for other entries, just removing the obsolete entry. Will update it.

          Show
          drankye Kai Zheng added a comment - Ok, I agree, since we remain the enum values for other entries, just removing the obsolete entry. Will update it.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch to remove the entry for the old engine in the protocol as follows.

           /**
            * RpcKind determine the rpcEngine and the serialization of the rpc request
          + * Note: 1 for RPC_WRITABLE, WritableRpcEngine, obsolete and removed
            */
           enum RpcKindProto {
             RPC_BUILTIN          = 0;  // Used for built in calls by tests
          -  RPC_WRITABLE         = 1;  // Use WritableRpcEngine, the actual usage removed
             RPC_PROTOCOL_BUFFER  = 2;  // Use ProtobufRpcEngine
           }
          
          Show
          drankye Kai Zheng added a comment - Updated the patch to remove the entry for the old engine in the protocol as follows. /** * RpcKind determine the rpcEngine and the serialization of the rpc request + * Note: 1 for RPC_WRITABLE, WritableRpcEngine, obsolete and removed */ enum RpcKindProto { RPC_BUILTIN = 0; // Used for built in calls by tests - RPC_WRITABLE = 1; // Use WritableRpcEngine, the actual usage removed RPC_PROTOCOL_BUFFER = 2; // Use ProtobufRpcEngine }
          Hide
          wheat9 Haohui Mai added a comment -

          +1. Thanks Kai Zheng!

          Show
          wheat9 Haohui Mai added a comment - +1. Thanks Kai Zheng !
          Hide
          drankye Kai Zheng added a comment -

          Rebased the patch.

          Show
          drankye Kai Zheng added a comment - Rebased the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
          0 mvndep 0m 35s Maven dependency ordering for branch
          +1 mvninstall 6m 12s trunk passed
          +1 compile 6m 12s trunk passed
          +1 checkstyle 1m 31s trunk passed
          +1 mvnsite 2m 4s trunk passed
          +1 mvneclipse 0m 37s trunk passed
          +1 findbugs 3m 20s trunk passed
          +1 javadoc 2m 9s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 40s the patch passed
          +1 compile 6m 38s the patch passed
          +1 cc 6m 38s the patch passed
          +1 javac 6m 38s the patch passed
          -1 checkstyle 1m 31s root: The patch generated 7 new + 846 unchanged - 71 fixed = 853 total (was 917)
          +1 mvnsite 2m 35s the patch passed
          +1 mvneclipse 0m 38s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 14s the patch passed
          +1 javadoc 2m 27s the patch passed
          -1 unit 8m 48s hadoop-common in the patch failed.
          -1 unit 68m 47s hadoop-hdfs in the patch failed.
          +1 unit 6m 56s hadoop-mapreduce-client-hs in the patch passed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          128m 51s



          Reason Tests
          Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.hdfs.TestCrcCorruption
            hadoop.hdfs.server.datanode.TestDataNodeLifeline
          Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806052/HADOOP-12579-v10.patch
          JIRA Issue HADOOP-12579
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 3de0d642cef2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ae353ea
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9575/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9575/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9575/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9575/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9575/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9575/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9575/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 0m 35s Maven dependency ordering for branch +1 mvninstall 6m 12s trunk passed +1 compile 6m 12s trunk passed +1 checkstyle 1m 31s trunk passed +1 mvnsite 2m 4s trunk passed +1 mvneclipse 0m 37s trunk passed +1 findbugs 3m 20s trunk passed +1 javadoc 2m 9s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 40s the patch passed +1 compile 6m 38s the patch passed +1 cc 6m 38s the patch passed +1 javac 6m 38s the patch passed -1 checkstyle 1m 31s root: The patch generated 7 new + 846 unchanged - 71 fixed = 853 total (was 917) +1 mvnsite 2m 35s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 14s the patch passed +1 javadoc 2m 27s the patch passed -1 unit 8m 48s hadoop-common in the patch failed. -1 unit 68m 47s hadoop-hdfs in the patch failed. +1 unit 6m 56s hadoop-mapreduce-client-hs in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 128m 51s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.server.datanode.TestDataNodeLifeline Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806052/HADOOP-12579-v10.patch JIRA Issue HADOOP-12579 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 3de0d642cef2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ae353ea Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9575/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9575/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9575/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9575/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9575/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9575/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9575/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Fixed some check styles of removing unused imports.

          Show
          drankye Kai Zheng added a comment - Fixed some check styles of removing unused imports.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
          0 mvndep 0m 12s Maven dependency ordering for branch
          +1 mvninstall 6m 4s trunk passed
          +1 compile 6m 11s trunk passed
          +1 checkstyle 1m 30s trunk passed
          +1 mvnsite 2m 3s trunk passed
          +1 mvneclipse 0m 35s trunk passed
          +1 findbugs 3m 18s trunk passed
          +1 javadoc 2m 8s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 39s the patch passed
          +1 compile 6m 4s the patch passed
          +1 cc 6m 4s the patch passed
          +1 javac 6m 4s the patch passed
          -1 checkstyle 1m 29s root: The patch generated 3 new + 845 unchanged - 71 fixed = 848 total (was 916)
          +1 mvnsite 2m 26s the patch passed
          +1 mvneclipse 0m 36s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 48s the patch passed
          +1 javadoc 2m 11s the patch passed
          +1 unit 7m 35s hadoop-common in the patch passed.
          +1 unit 55m 46s hadoop-hdfs in the patch passed.
          +1 unit 6m 5s hadoop-mapreduce-client-hs in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          111m 23s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806077/HADOOP-12579-v11.patch
          JIRA Issue HADOOP-12579
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 81b933118329 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 28bd63e
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9579/artifact/patchprocess/diff-checkstyle-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9579/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9579/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 0m 12s Maven dependency ordering for branch +1 mvninstall 6m 4s trunk passed +1 compile 6m 11s trunk passed +1 checkstyle 1m 30s trunk passed +1 mvnsite 2m 3s trunk passed +1 mvneclipse 0m 35s trunk passed +1 findbugs 3m 18s trunk passed +1 javadoc 2m 8s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 39s the patch passed +1 compile 6m 4s the patch passed +1 cc 6m 4s the patch passed +1 javac 6m 4s the patch passed -1 checkstyle 1m 29s root: The patch generated 3 new + 845 unchanged - 71 fixed = 848 total (was 916) +1 mvnsite 2m 26s the patch passed +1 mvneclipse 0m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 48s the patch passed +1 javadoc 2m 11s the patch passed +1 unit 7m 35s hadoop-common in the patch passed. +1 unit 55m 46s hadoop-hdfs in the patch passed. +1 unit 6m 5s hadoop-mapreduce-client-hs in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 111m 23s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806077/HADOOP-12579-v11.patch JIRA Issue HADOOP-12579 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 81b933118329 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 28bd63e Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9579/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9579/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9579/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Haohui Mai has given this a +1. The updates since then are rebase and minor check styles removing unused imports.

          So if there isn't concern I will commit it to trunk tomorrow.

          Show
          drankye Kai Zheng added a comment - Haohui Mai has given this a +1. The updates since then are rebase and minor check styles removing unused imports. So if there isn't concern I will commit it to trunk tomorrow.
          Hide
          drankye Kai Zheng added a comment -

          Committed to trunk. Thanks Haohui for the issue and reviewing. Thanks Colin, Chris and Steve for the discussion.

          Show
          drankye Kai Zheng added a comment - Committed to trunk. Thanks Haohui for the issue and reviewing. Thanks Colin, Chris and Steve for the discussion.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9860 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9860/)
          HADOOP-12579. Deprecate and remove WriteableRPCEngine. Contributed by (kai.zheng: rev a6c79f92d503c664f2d109355b719124f29a30e5)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          • hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestClientProtocolWithDelegationToken.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/RPCCallBenchmark.java
          • hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRpcBase.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCallBenchmark.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/server/HSAdminServer.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java
          • hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9860 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9860/ ) HADOOP-12579 . Deprecate and remove WriteableRPCEngine. Contributed by (kai.zheng: rev a6c79f92d503c664f2d109355b719124f29a30e5) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java hadoop-common-project/hadoop-common/src/test/proto/test.proto hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestClientProtocolWithDelegationToken.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/RPCCallBenchmark.java hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRpcBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCallBenchmark.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/server/HSAdminServer.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
          Hide
          asuresh Arun Suresh added a comment -

          Kai Zheng, Haohui Mai, Am seeing a bunch of test failures in trunk builds since this was committed. For YARN, I had raised YARN-5163 to track the specific failures. I notice that once I revert HADOOP-12579 locally, TestClientToAMTokens does indeed pass.

          Furthermore, a lot of MR tests that use MiniYarnCluster seem to fail with the following error message in its Map tasks :

          2016-05-29 19:35:08,358 WARN [main] org.apache.hadoop.mapred.YarnChild: Exception running child : java.lang.reflect.UndeclaredThrowableException
            at com.sun.proxy.$Proxy10.getTask(Unknown Source)
            at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:136)
          Caused by: com.google.protobuf.ServiceException: Too many or few parameters for request. Method: [getTask], Expected: 2, Actual: 1
            at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:206)
            ... 2 more
          
          2016-05-29 19:35:08,359 INFO [main] org.apache.hadoop.metrics2.impl.MetricsSystemImpl: Stopping MapTask metrics system...
          

          Again, after reverting this locally, they pass..

          Kindly do take a look

          Show
          asuresh Arun Suresh added a comment - Kai Zheng , Haohui Mai , Am seeing a bunch of test failures in trunk builds since this was committed. For YARN, I had raised YARN-5163 to track the specific failures. I notice that once I revert HADOOP-12579 locally, TestClientToAMTokens does indeed pass. Furthermore, a lot of MR tests that use MiniYarnCluster seem to fail with the following error message in its Map tasks : 2016-05-29 19:35:08,358 WARN [main] org.apache.hadoop.mapred.YarnChild: Exception running child : java.lang.reflect.UndeclaredThrowableException at com.sun.proxy.$Proxy10.getTask(Unknown Source) at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:136) Caused by: com.google.protobuf.ServiceException: Too many or few parameters for request. Method: [getTask], Expected: 2, Actual: 1 at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:206) ... 2 more 2016-05-29 19:35:08,359 INFO [main] org.apache.hadoop.metrics2.impl.MetricsSystemImpl: Stopping MapTask metrics system... Again, after reverting this locally, they pass.. Kindly do take a look
          Hide
          drankye Kai Zheng added a comment -

          Thanks Arun Suresh for raising these!! Yes I will look at and fix them ASAP.

          Show
          drankye Kai Zheng added a comment - Thanks Arun Suresh for raising these!! Yes I will look at and fix them ASAP.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Same reason for MAPREDUCE-6705 failure too

          Show
          bibinchundatt Bibin A Chundatt added a comment - Same reason for MAPREDUCE-6705 failure too
          Hide
          drankye Kai Zheng added a comment -

          Yes I will fix it too. Thanks Bibin A Chundatt!

          Show
          drankye Kai Zheng added a comment - Yes I will fix it too. Thanks Bibin A Chundatt !
          Hide
          drankye Kai Zheng added a comment -

          In MAPREDUCE-6705, it was found YarnChild uses TaskUmbilicalProtocol which still relies on WritableRpcEngine. This must be handled before removing the engine. It involves major development work rather than just a bug fix, so I guess we have to revert this change. Any comment? If no concern I will revert it tomorrow to resolve the blocker.

          Show
          drankye Kai Zheng added a comment - In MAPREDUCE-6705 , it was found YarnChild uses TaskUmbilicalProtocol which still relies on WritableRpcEngine. This must be handled before removing the engine. It involves major development work rather than just a bug fix, so I guess we have to revert this change. Any comment? If no concern I will revert it tomorrow to resolve the blocker.
          Hide
          asuresh Arun Suresh added a comment - - edited

          +1 to reverting this. Looks like around 56 tests are failing on the Mapreduce side, which I suspect is due to this.
          I have opened MAPREDUCE-6706 to track changes to be made to TaskUmbilicalProtocol. Let me know if you need help with the fixes required to get this in.

          Also.. thanks for looking into this Kai Zheng

          Show
          asuresh Arun Suresh added a comment - - edited +1 to reverting this. Looks like around 56 tests are failing on the Mapreduce side, which I suspect is due to this. I have opened MAPREDUCE-6706 to track changes to be made to TaskUmbilicalProtocol. Let me know if you need help with the fixes required to get this in. Also.. thanks for looking into this Kai Zheng
          Hide
          drankye Kai Zheng added a comment -

          Thanks Arun Suresh for looking at this! I will revert this shortly and split out all the test related codes of this work as separate patch to be attached in HADOOP-13218 for easier maintaining.

          Show
          drankye Kai Zheng added a comment - Thanks Arun Suresh for looking at this! I will revert this shortly and split out all the test related codes of this work as separate patch to be attached in HADOOP-13218 for easier maintaining.
          Hide
          drankye Kai Zheng added a comment -

          The work is reverted and reopening this.

          Show
          drankye Kai Zheng added a comment - The work is reverted and reopening this.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9887 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9887/)
          Revert "HADOOP-12579. Deprecate and remove WriteableRPCEngine. (kai.zheng: rev 93d8a7f2a2d72a1719d02b1ed90678397900b6ed)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/server/HSAdminServer.java
          • hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestClientProtocolWithDelegationToken.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/RPCCallBenchmark.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRpcBase.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCallBenchmark.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java
          • hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9887 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9887/ ) Revert " HADOOP-12579 . Deprecate and remove WriteableRPCEngine. (kai.zheng: rev 93d8a7f2a2d72a1719d02b1ed90678397900b6ed) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/server/HSAdminServer.java hadoop-common-project/hadoop-common/src/test/proto/test.proto hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestClientProtocolWithDelegationToken.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/RPCCallBenchmark.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRpcBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ProtoUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCallBenchmark.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto
          Hide
          andrew.wang Andrew Wang added a comment -

          I removed the fix version since this was reverted and re-opened. Thanks all.

          Show
          andrew.wang Andrew Wang added a comment - I removed the fix version since this was reverted and re-opened. Thanks all.
          Hide
          drankye Kai Zheng added a comment -

          In MAPREDUCE-6706 Junping Du had a comment that the old RPC engine WriteableRPCEngine might be still used by other projects like Tez. Considering this I'd re-target this as only deprecate rather than removal of the engine. Please correct if you'd think otherwise. Thanks.

          Show
          drankye Kai Zheng added a comment - In MAPREDUCE-6706 Junping Du had a comment that the old RPC engine WriteableRPCEngine might be still used by other projects like Tez. Considering this I'd re-target this as only deprecate rather than removal of the engine. Please correct if you'd think otherwise. Thanks.
          Hide
          zhouwei Wei Zhou added a comment -

          As discussed above, this patch only deprecate this engine rather than removal it. Thanks!

          Show
          zhouwei Wei Zhou added a comment - As discussed above, this patch only deprecate this engine rather than removal it. Thanks!
          Hide
          zhouwei Wei Zhou added a comment -

          Reupload the patch due to naming issue. Thanks!

          Show
          zhouwei Wei Zhou added a comment - Reupload the patch due to naming issue. Thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 41s trunk passed
          +1 compile 6m 47s trunk passed
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 55s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 18s trunk passed
          +1 javadoc 0m 43s trunk passed
          +1 mvninstall 0m 35s the patch passed
          +1 compile 6m 40s the patch passed
          -1 javac 6m 40s root generated 1 new + 707 unchanged - 0 fixed = 708 total (was 707)
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 0m 53s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 25s the patch passed
          +1 javadoc 0m 41s the patch passed
          +1 unit 8m 7s hadoop-common in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          37m 57s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-12579
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832327/HADOOP-12579-v12.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux df3fd6b8e40a 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4d10621
          Default Java 1.8.0_101
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10715/artifact/patchprocess/diff-compile-javac-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10715/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10715/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 41s trunk passed +1 compile 6m 47s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 43s trunk passed +1 mvninstall 0m 35s the patch passed +1 compile 6m 40s the patch passed -1 javac 6m 40s root generated 1 new + 707 unchanged - 0 fixed = 708 total (was 707) +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 41s the patch passed +1 unit 8m 7s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 37m 57s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-12579 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832327/HADOOP-12579-v12.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux df3fd6b8e40a 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4d10621 Default Java 1.8.0_101 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10715/artifact/patchprocess/diff-compile-javac-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10715/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10715/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          The latest patch LGTM and +1, deprecating the WriteableRPCEngine.

          Show
          drankye Kai Zheng added a comment - The latest patch LGTM and +1, deprecating the WriteableRPCEngine.
          Hide
          drankye Kai Zheng added a comment -

          Committed to trunk. Thanks all!

          Show
          drankye Kai Zheng added a comment - Committed to trunk. Thanks all!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10574 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10574/)
          HADOOP-12579. Deprecate WriteableRPCEngine. Contributed by Wei Zhou (kai.zheng: rev ec0b70716c8e6509654a3975d3ca139a0144cc8e)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10574 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10574/ ) HADOOP-12579 . Deprecate WriteableRPCEngine. Contributed by Wei Zhou (kai.zheng: rev ec0b70716c8e6509654a3975d3ca139a0144cc8e) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java

            People

            • Assignee:
              zhouwei Wei Zhou
              Reporter:
              wheat9 Haohui Mai
            • Votes:
              0 Vote for this issue
              Watchers:
              18 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development