Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12579 Deprecate WriteableRPCEngine
  3. HADOOP-13218

Migrate other Hadoop side tests to prepare for removing WritableRPCEngine

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change, Reviewed

      Description

      Patch for HADOOP-12579 contains lots of work to migrate the left Hadoop side tests basing on the new RPC engine and nice cleanups. HADOOP-12579 will be reverted to allow some time for YARN/Mapreduce side related changes, open this to recommit most of the test related work in HADOOP-12579 for easier tracking and maintain, as other sub-tasks did.

      1. HADOOP-13218-v03.patch
        77 kB
        Wei Zhou
      2. HADOOP-13218-v02.patch
        77 kB
        Wei Zhou
      3. HADOOP-13218-v01.patch
        78 kB
        Kai Zheng

        Issue Links

          Activity

          Hide
          drankye Kai Zheng added a comment -

          Uploaded the patch as described, separated from HADOOP-12579.

          Show
          drankye Kai Zheng added a comment - Uploaded the patch as described, separated from HADOOP-12579 .
          Hide
          drankye Kai Zheng added a comment -

          Arun Suresh, would you take a look at this? The work is from HADOOP-12579 and would be re-committed here. This is also a sub task to prepare for removing the engine, to make HADOOP-12579 much easier.

          Show
          drankye Kai Zheng added a comment - Arun Suresh , would you take a look at this? The work is from HADOOP-12579 and would be re-committed here. This is also a sub task to prepare for removing the engine, to make HADOOP-12579 much easier.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 38s trunk passed
          +1 compile 6m 51s trunk passed
          +1 checkstyle 1m 36s trunk passed
          +1 mvnsite 2m 8s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 3m 32s trunk passed
          +1 javadoc 2m 1s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 50s the patch passed
          +1 compile 6m 49s the patch passed
          +1 cc 6m 49s the patch passed
          +1 javac 6m 49s the patch passed
          -0 checkstyle 1m 37s root: The patch generated 2 new + 833 unchanged - 46 fixed = 835 total (was 879)
          +1 mvnsite 2m 16s the patch passed
          +1 mvneclipse 0m 50s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 9s the patch passed
          +1 javadoc 2m 9s the patch passed
          -1 unit 7m 54s hadoop-common in the patch failed.
          +1 unit 57m 58s hadoop-hdfs in the patch passed.
          +1 unit 7m 1s hadoop-mapreduce-client-hs in the patch passed.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          141m 7s



          Reason Tests
          Failed junit tests hadoop.ipc.TestRPCWaitForProxy



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13218
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807019/HADOOP-13218-v01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux fc8cead37ae4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6f4b0d3
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10435/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10435/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10435/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10435/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 38s trunk passed +1 compile 6m 51s trunk passed +1 checkstyle 1m 36s trunk passed +1 mvnsite 2m 8s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 3m 32s trunk passed +1 javadoc 2m 1s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 50s the patch passed +1 compile 6m 49s the patch passed +1 cc 6m 49s the patch passed +1 javac 6m 49s the patch passed -0 checkstyle 1m 37s root: The patch generated 2 new + 833 unchanged - 46 fixed = 835 total (was 879) +1 mvnsite 2m 16s the patch passed +1 mvneclipse 0m 50s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 9s the patch passed +1 javadoc 2m 9s the patch passed -1 unit 7m 54s hadoop-common in the patch failed. +1 unit 57m 58s hadoop-hdfs in the patch passed. +1 unit 7m 1s hadoop-mapreduce-client-hs in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 141m 7s Reason Tests Failed junit tests hadoop.ipc.TestRPCWaitForProxy Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13218 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807019/HADOOP-13218-v01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux fc8cead37ae4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6f4b0d3 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10435/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10435/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10435/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10435/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          zhouwei Wei Zhou added a comment -

          Update the patch and fix issues reported by Jenkins, thanks!

          Show
          zhouwei Wei Zhou added a comment - Update the patch and fix issues reported by Jenkins, thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
          0 mvndep 1m 29s Maven dependency ordering for branch
          +1 mvninstall 7m 5s trunk passed
          +1 compile 7m 14s trunk passed
          +1 checkstyle 1m 34s trunk passed
          +1 mvnsite 2m 14s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 3m 38s trunk passed
          +1 javadoc 1m 57s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 47s the patch passed
          +1 compile 6m 56s the patch passed
          +1 cc 6m 56s the patch passed
          +1 javac 6m 56s the patch passed
          -0 checkstyle 1m 38s root: The patch generated 2 new + 835 unchanged - 46 fixed = 837 total (was 881)
          +1 mvnsite 2m 16s the patch passed
          +1 mvneclipse 0m 48s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 10s the patch passed
          +1 javadoc 2m 9s the patch passed
          +1 unit 8m 25s hadoop-common in the patch passed.
          -1 unit 59m 48s hadoop-hdfs in the patch failed.
          +1 unit 6m 48s hadoop-mapreduce-client-hs in the patch passed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          145m 8s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDecommissionWithStriped



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13218
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826779/HADOOP-13218-v02.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux ddb6cb3c699c 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0690f09
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10442/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10442/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10442/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10442/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 1m 29s Maven dependency ordering for branch +1 mvninstall 7m 5s trunk passed +1 compile 7m 14s trunk passed +1 checkstyle 1m 34s trunk passed +1 mvnsite 2m 14s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 3m 38s trunk passed +1 javadoc 1m 57s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 47s the patch passed +1 compile 6m 56s the patch passed +1 cc 6m 56s the patch passed +1 javac 6m 56s the patch passed -0 checkstyle 1m 38s root: The patch generated 2 new + 835 unchanged - 46 fixed = 837 total (was 881) +1 mvnsite 2m 16s the patch passed +1 mvneclipse 0m 48s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 10s the patch passed +1 javadoc 2m 9s the patch passed +1 unit 8m 25s hadoop-common in the patch passed. -1 unit 59m 48s hadoop-hdfs in the patch failed. +1 unit 6m 48s hadoop-mapreduce-client-hs in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 145m 8s Reason Tests Failed junit tests hadoop.hdfs.TestDecommissionWithStriped Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13218 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826779/HADOOP-13218-v02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux ddb6cb3c699c 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0690f09 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10442/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10442/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10442/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10442/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Thanks Wei Zhou for the update. Will commit it by tomorrow.

          Show
          drankye Kai Zheng added a comment - Thanks Wei Zhou for the update. Will commit it by tomorrow.
          Hide
          drankye Kai Zheng added a comment -

          +1 on the latest patch (as part of HADOOP-12579 which was already hit +1). Have committed it to trunk branch.

          Show
          drankye Kai Zheng added a comment - +1 on the latest patch (as part of HADOOP-12579 which was already hit +1). Have committed it to trunk branch.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10396 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10396/)
          HADOOP-13218. Migrate other Hadoop side tests to prepare for removing (kai.zheng: rev 62a9667136ebd8a048f556b534fcff4fdaf8e2ec)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/RPCCallBenchmark.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRpcBase.java
          • (edit) hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java
          • (edit) hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • (delete) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestClientProtocolWithDelegationToken.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/server/HSAdminServer.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCallBenchmark.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10396 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10396/ ) HADOOP-13218 . Migrate other Hadoop side tests to prepare for removing (kai.zheng: rev 62a9667136ebd8a048f556b534fcff4fdaf8e2ec) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/RPCCallBenchmark.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRpcBase.java (edit) hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java (edit) hadoop-common-project/hadoop-common/src/test/proto/test.proto (delete) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestClientProtocolWithDelegationToken.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/server/HSAdminServer.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCallBenchmark.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
          Hide
          kihwal Kihwal Lee added a comment -

          So.... is it expected that many mapred tests are broken after this?

          Show
          kihwal Kihwal Lee added a comment - So.... is it expected that many mapred tests are broken after this?
          Hide
          jlowe Jason Lowe added a comment -

          Not just tests, MapReduce jobs can't run after this change. The tasks fail with this error:

          2016-09-07 17:51:56,296 WARN [main] org.apache.hadoop.mapred.YarnChild: Exception running child : java.lang.reflect.UndeclaredThrowableException
          	at com.sun.proxy.$Proxy10.getTask(Unknown Source)
          	at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:137)
          Caused by: com.google.protobuf.ServiceException: Too many or few parameters for request. Method: [getTask], Expected: 2, Actual: 1
          	at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:199)
          	at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:116)
          	... 2 more
          

          I think this needs to be reverted until things are sorted out.

          Show
          jlowe Jason Lowe added a comment - Not just tests, MapReduce jobs can't run after this change. The tasks fail with this error: 2016-09-07 17:51:56,296 WARN [main] org.apache.hadoop.mapred.YarnChild: Exception running child : java.lang.reflect.UndeclaredThrowableException at com.sun.proxy.$Proxy10.getTask(Unknown Source) at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:137) Caused by: com.google.protobuf.ServiceException: Too many or few parameters for request. Method: [getTask], Expected: 2, Actual: 1 at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:199) at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:116) ... 2 more I think this needs to be reverted until things are sorted out.
          Hide
          drankye Kai Zheng added a comment -

          Sorry for the inconvenience. I'll fire a new JIRA and sort out a fix soon.

          The cause should that the default engine should remain as the old one, before MAPREDUCE-6706 is solved. The fix should be simple in YARN/MapReduce side so necessary test cases are involved and triggered.

          @@ -207,7 +208,7 @@ static synchronized RpcEngine getProtocolEngine(Class<?> protocol,
               RpcEngine engine = PROTOCOL_ENGINES.get(protocol);
               if (engine == null) {
                 Class<?> impl = conf.getClass(ENGINE_PROP+"."+protocol.getName(),
          -                                    WritableRpcEngine.class);
          +                                    ProtobufRpcEngine.class);
                 engine = (RpcEngine)ReflectionUtils.newInstance(impl, conf);
                 PROTOCOL_ENGINES.put(protocol, engine);
               }
          
          Show
          drankye Kai Zheng added a comment - Sorry for the inconvenience. I'll fire a new JIRA and sort out a fix soon. The cause should that the default engine should remain as the old one, before MAPREDUCE-6706 is solved. The fix should be simple in YARN/MapReduce side so necessary test cases are involved and triggered. @@ -207,7 +208,7 @@ static synchronized RpcEngine getProtocolEngine( Class <?> protocol, RpcEngine engine = PROTOCOL_ENGINES.get(protocol); if (engine == null ) { Class <?> impl = conf.getClass(ENGINE_PROP+ "." +protocol.getName(), - WritableRpcEngine.class); + ProtobufRpcEngine.class); engine = (RpcEngine)ReflectionUtils.newInstance(impl, conf); PROTOCOL_ENGINES.put(protocol, engine); }
          Hide
          drankye Kai Zheng added a comment -

          MAPREDUCE-6775 was just fired for the fix.

          Show
          drankye Kai Zheng added a comment - MAPREDUCE-6775 was just fired for the fix.
          Hide
          jlowe Jason Lowe added a comment -

          Why do we need yet another JIRA? This just went in, breaks a major piece of functionality in the project, and reverts cleanly. I don't see why this wouldn't be fixed as part of this JIRA. Creating a separate JIRA has a couple of drawbacks:

          1. If this ever gets picked to other branches we need to remember to pick the "fix" as well or it breaks again.
          2. MapReduce remains broken until the other JIRA gets a patch up, reviewed, etc.

          IMHO punting a followup fix only makes sense if the original can't be easily reverted, but that's not the case here.

          Show
          jlowe Jason Lowe added a comment - Why do we need yet another JIRA? This just went in, breaks a major piece of functionality in the project, and reverts cleanly. I don't see why this wouldn't be fixed as part of this JIRA. Creating a separate JIRA has a couple of drawbacks: If this ever gets picked to other branches we need to remember to pick the "fix" as well or it breaks again. MapReduce remains broken until the other JIRA gets a patch up, reviewed, etc. IMHO punting a followup fix only makes sense if the original can't be easily reverted, but that's not the case here.
          Hide
          drankye Kai Zheng added a comment -

          Hi Jason Lowe,

          Thanks for your detailed thoughts. The major reason why we need another JIRA is we need it in MapReduce side to trigger the MR side tests. As you could see here, the Jenkins building results look pretty clean and no relevant test failures were found. My other humble consideration is when a simple fix does the work, we could do it for easy understanding of the editing history of related codes.

          Show
          drankye Kai Zheng added a comment - Hi Jason Lowe , Thanks for your detailed thoughts. The major reason why we need another JIRA is we need it in MapReduce side to trigger the MR side tests. As you could see here, the Jenkins building results look pretty clean and no relevant test failures were found. My other humble consideration is when a simple fix does the work, we could do it for easy understanding of the editing history of related codes.
          Hide
          drankye Kai Zheng added a comment -

          I thought your concern about cherry-picking is a good one, so the new issue should be linked in the master HADOOP-12579 one as part of tasks. HADOOP-12579 contained quite a few sub-tasks and should be picked together in future.

          Show
          drankye Kai Zheng added a comment - I thought your concern about cherry-picking is a good one, so the new issue should be linked in the master HADOOP-12579 one as part of tasks. HADOOP-12579 contained quite a few sub-tasks and should be picked together in future.
          Hide
          jlowe Jason Lowe added a comment -

          we need it in MapReduce side to trigger the MR side tests.

          This patch modified the HDFS project and the MapReduce project, and apparently we didn't need a separate JIRA for that. IMHO we don't need another JIRA for this. This is breaking precommit and nightly builds until it's fixed.

          Show
          jlowe Jason Lowe added a comment - we need it in MapReduce side to trigger the MR side tests. This patch modified the HDFS project and the MapReduce project, and apparently we didn't need a separate JIRA for that. IMHO we don't need another JIRA for this. This is breaking precommit and nightly builds until it's fixed.
          Hide
          jlowe Jason Lowe added a comment -

          What's particularly upsetting about this instance is that HADOOP-12579 was reverted for essentially the same reason. It completely broke MapReduce. The same is true here. Why are we treating it differently?

          Show
          jlowe Jason Lowe added a comment - What's particularly upsetting about this instance is that HADOOP-12579 was reverted for essentially the same reason. It completely broke MapReduce. The same is true here. Why are we treating it differently?
          Hide
          drankye Kai Zheng added a comment -

          I have a hard understanding why the Jenkins building here din't hit the failures found in precommit and nightly builds, could you post the relevant test cases either here or in MAPREDUCE-6775? Kindly let me check more.

          The same is true here. Why are we treating it differently?

          HADOOP-12579 aims to and will remove the old RPC engine from the code base. It has to be done when all the sub tasks are finished. The work here is part of its work to prepare for the removal. The changing of the default RPC engine is unexpected and deeply sorry for that.

          Show
          drankye Kai Zheng added a comment - I have a hard understanding why the Jenkins building here din't hit the failures found in precommit and nightly builds, could you post the relevant test cases either here or in MAPREDUCE-6775 ? Kindly let me check more. The same is true here. Why are we treating it differently? HADOOP-12579 aims to and will remove the old RPC engine from the code base. It has to be done when all the sub tasks are finished. The work here is part of its work to prepare for the removal. The changing of the default RPC engine is unexpected and deeply sorry for that.
          Hide
          kihwal Kihwal Lee added a comment -

          -1 Please revert it first and engage in further discussions. It is also confusing who is the real author of the patch.

          Show
          kihwal Kihwal Lee added a comment - -1 Please revert it first and engage in further discussions. It is also confusing who is the real author of the patch.
          Hide
          jlowe Jason Lowe added a comment -

          The Jenkins build here didn't hit the failures because the precommit builds only run the tests in the maven projects that were touched by the patch. This patch touched MapReduce but only in the history server project. If it had touched the jobclient project then you would have seen the failures. In short, you cannot know for certain that a patch doesn't break something when the precommit build is clean because the precommit build doesn't run all of the tests due to how long that would take for each precommit build.

          See https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/157/#showFailuresLink for a nightly build sample. Any precommit build that needs to run tests in jobclient is going to report a lot of failures due to this still being in the build.

          The changing of the default RPC engine is unexpected and deeply sorry for that.

          The summary implies this is just about tests, but it is not. It changes the default RPC engine. If that change is unexpected then this patch should be reverted, that portion removed from the patch, and then reviewed and recommitted.

          Show
          jlowe Jason Lowe added a comment - The Jenkins build here didn't hit the failures because the precommit builds only run the tests in the maven projects that were touched by the patch. This patch touched MapReduce but only in the history server project. If it had touched the jobclient project then you would have seen the failures. In short, you cannot know for certain that a patch doesn't break something when the precommit build is clean because the precommit build doesn't run all of the tests due to how long that would take for each precommit build. See https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/157/#showFailuresLink for a nightly build sample. Any precommit build that needs to run tests in jobclient is going to report a lot of failures due to this still being in the build. The changing of the default RPC engine is unexpected and deeply sorry for that. The summary implies this is just about tests, but it is not. It changes the default RPC engine. If that change is unexpected then this patch should be reverted, that portion removed from the patch, and then reviewed and recommitted.
          Hide
          drankye Kai Zheng added a comment -

          The summary implies this is just about tests, but it is not. It changes the default RPC engine. If that change is unexpected then this patch should be reverted, that portion removed from the patch, and then reviewed and recommitted.

          This is convincing. OK, let me proceed in the way.

          Thanks for your detailed information and thoughts!

          Show
          drankye Kai Zheng added a comment - The summary implies this is just about tests, but it is not. It changes the default RPC engine. If that change is unexpected then this patch should be reverted, that portion removed from the patch, and then reviewed and recommitted. This is convincing. OK, let me proceed in the way. Thanks for your detailed information and thoughts!
          Hide
          drankye Kai Zheng added a comment -

          Reopen it as discussed and will revert the work soon.

          Show
          drankye Kai Zheng added a comment - Reopen it as discussed and will revert the work soon.
          Hide
          drankye Kai Zheng added a comment -

          Done. Thanks all for the discussion.

          Show
          drankye Kai Zheng added a comment - Done. Thanks all for the discussion.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10406 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10406/)
          Revert "HADOOP-13218. Migrate other Hadoop side tests to prepare for (kai.zheng: rev d355573f5681f43e760a1bc23ebed553bd35fca5)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCallBenchmark.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java
          • (edit) hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • (edit) hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/RPCCallBenchmark.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRpcBase.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java
          • (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestClientProtocolWithDelegationToken.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/server/HSAdminServer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10406 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10406/ ) Revert " HADOOP-13218 . Migrate other Hadoop side tests to prepare for (kai.zheng: rev d355573f5681f43e760a1bc23ebed553bd35fca5) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCallBenchmark.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java (edit) hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java (edit) hadoop-common-project/hadoop-common/src/test/proto/test.proto (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/RPCCallBenchmark.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRpcBase.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestClientProtocolWithDelegationToken.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/server/HSAdminServer.java
          Hide
          zhouwei Wei Zhou added a comment -

          Fix MapReduce failure caused by changing the default rpc engine, thanks!

          Show
          zhouwei Wei Zhou added a comment - Fix MapReduce failure caused by changing the default rpc engine, thanks!
          Hide
          kihwal Kihwal Lee added a comment -

          Submitting the patch for precommit. Also marked it as an incompatible change. We should populate the release note filed, so that other downstream projects or users can be informed.

          Show
          kihwal Kihwal Lee added a comment - Submitting the patch for precommit. Also marked it as an incompatible change. We should populate the release note filed, so that other downstream projects or users can be informed.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 12 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 7m 2s trunk passed
          +1 compile 7m 8s trunk passed
          +1 checkstyle 1m 36s trunk passed
          +1 mvnsite 2m 17s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 3m 46s trunk passed
          +1 javadoc 2m 3s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 52s the patch passed
          +1 compile 7m 2s the patch passed
          +1 cc 7m 2s the patch passed
          +1 javac 7m 2s the patch passed
          -0 checkstyle 1m 41s root: The patch generated 2 new + 817 unchanged - 46 fixed = 819 total (was 863)
          +1 mvnsite 2m 22s the patch passed
          +1 mvneclipse 0m 50s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 19s the patch passed
          +1 javadoc 2m 9s the patch passed
          -1 unit 17m 13s hadoop-common in the patch failed.
          +1 unit 60m 32s hadoop-hdfs in the patch passed.
          +1 unit 7m 6s hadoop-mapreduce-client-hs in the patch passed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          154m 33s



          Reason Tests
          Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13218
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828161/HADOOP-13218-v03.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux c6fa2de73ee3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e3f7f58
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10495/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10495/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10495/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10495/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 12 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 7m 2s trunk passed +1 compile 7m 8s trunk passed +1 checkstyle 1m 36s trunk passed +1 mvnsite 2m 17s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 3m 46s trunk passed +1 javadoc 2m 3s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 52s the patch passed +1 compile 7m 2s the patch passed +1 cc 7m 2s the patch passed +1 javac 7m 2s the patch passed -0 checkstyle 1m 41s root: The patch generated 2 new + 817 unchanged - 46 fixed = 819 total (was 863) +1 mvnsite 2m 22s the patch passed +1 mvneclipse 0m 50s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 19s the patch passed +1 javadoc 2m 9s the patch passed -1 unit 17m 13s hadoop-common in the patch failed. +1 unit 60m 32s hadoop-hdfs in the patch passed. +1 unit 7m 6s hadoop-mapreduce-client-hs in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 154m 33s Reason Tests Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13218 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828161/HADOOP-13218-v03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux c6fa2de73ee3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e3f7f58 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10495/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10495/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10495/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10495/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Kihwal Lee, thanks for looking at this.

          Also marked it as an incompatible change. We should populate the release note filed, so that other downstream projects or users can be informed.

          Agree. Actually this was planned and meant to be done in the master JIRA HADOOP-12579 when all its sub-tasks are done. Kindly note this was just a sub-task migrating the left tests in Hadoop side and doesn't mean to have real impact like incompatible changes on production codes. As Jason Lowe pointed above, it's in fact a mistake that the default RPC engine was changed. I'd review Wei Zhou's updated patch and make sure this was corrected.

          Sounds good to you?

          Show
          drankye Kai Zheng added a comment - Kihwal Lee , thanks for looking at this. Also marked it as an incompatible change. We should populate the release note filed, so that other downstream projects or users can be informed. Agree. Actually this was planned and meant to be done in the master JIRA HADOOP-12579 when all its sub-tasks are done. Kindly note this was just a sub-task migrating the left tests in Hadoop side and doesn't mean to have real impact like incompatible changes on production codes. As Jason Lowe pointed above, it's in fact a mistake that the default RPC engine was changed. I'd review Wei Zhou 's updated patch and make sure this was corrected. Sounds good to you?
          Hide
          zhouwei Wei Zhou added a comment -

          The timeout issue of org.apache.hadoop.http.TestHttpServerLifecycle test reported by Jenkins has nothing to do with this patch, it passed in my local machine. I have done wide tests on this patch including unit tests and functional tests in real cluster. The functional tests are done by running build-in benchmarks like TestDFSIO, terasort, etc. Thanks!

          Show
          zhouwei Wei Zhou added a comment - The timeout issue of org.apache.hadoop.http.TestHttpServerLifecycle test reported by Jenkins has nothing to do with this patch, it passed in my local machine. I have done wide tests on this patch including unit tests and functional tests in real cluster. The functional tests are done by running build-in benchmarks like TestDFSIO, terasort, etc. Thanks!
          Hide
          zhouwei Wei Zhou added a comment -

          I have checked the checkstyle issues and think it's not suitable to be fixed as suggested, thanks!

          Show
          zhouwei Wei Zhou added a comment - I have checked the checkstyle issues and think it's not suitable to be fixed as suggested, thanks!
          Hide
          drankye Kai Zheng added a comment -

          Thanks Wei Zhou for the update and complete tests!
          +1 and committed to trunk.

          Show
          drankye Kai Zheng added a comment - Thanks Wei Zhou for the update and complete tests! +1 and committed to trunk.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10440 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10440/)
          HADOOP-13218. Migrate other Hadoop side tests to prepare for removing (kai.zheng: rev ea0c2b8b051a2d14927e8f314245442f30748dc8)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/RPCCallBenchmark.java
          • (delete) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestClientProtocolWithDelegationToken.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCallBenchmark.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/server/HSAdminServer.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRpcBase.java
          • (edit) hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • (edit) hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10440 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10440/ ) HADOOP-13218 . Migrate other Hadoop side tests to prepare for removing (kai.zheng: rev ea0c2b8b051a2d14927e8f314245442f30748dc8) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/RPCCallBenchmark.java (delete) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestClientProtocolWithDelegationToken.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCallBenchmark.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/server/HSAdminServer.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRpcBase.java (edit) hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java (edit) hadoop-common-project/hadoop-common/src/test/proto/test.proto (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java

            People

            • Assignee:
              zhouwei Wei Zhou
              Reporter:
              drankye Kai Zheng
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development