Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-10926

Improve smart-apply-patch.sh to apply binary diffs

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.0-alpha1
    • 3.0.0-alpha1
    • None
    • None

    Description

      The Unix patch command cannot apply binary diffs as generated via git diff --binary. This means we cannot get effective test-patch.sh runs when the patch requires adding a binary file.

      We should consider using a different patch method.

      Attachments

        1. HADOOP-10926.001.patch
          3 kB
          Colin McCabe
        2. HADOOP-10926.002.patch
          2 kB
          Colin McCabe
        3. HADOOP-10926.003.patch
          2 kB
          Colin McCabe
        4. HADOOP-10926.004.patch
          2 kB
          Colin McCabe

        Issue Links

          breaks

          Bug - A problem which impairs or prevents the functions of the product. HADOOP-11240 Jenkins build seems to be broken by changes in test-patch.sh

          • Blocker - Blocks development and/or testing work, production could not run
          • Resolved
          is duplicated by

          Improvement - An improvement or enhancement to an existing feature or task. HADOOP-11159 Use 'git apply' to apply patch instead of 'patch' command in Jenkins

          • Major - Major loss of function.
          • Resolved
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. HADOOP-11596 Allow smart-apply-patch.sh to add new files in binary git patches

          • Major - Major loss of function.
          • Resolved

          Activity

            People

              cmccabe Colin McCabe
              andrew.wang Andrew Wang
              Votes:
              0 Vote for this issue
              Watchers:
              16 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: