Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-10926

Improve smart-apply-patch.sh to apply binary diffs

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      The Unix patch command cannot apply binary diffs as generated via git diff --binary. This means we cannot get effective test-patch.sh runs when the patch requires adding a binary file.

      We should consider using a different patch method.

        Attachments

        1. HADOOP-10926.001.patch
          3 kB
          Colin P. McCabe
        2. HADOOP-10926.002.patch
          2 kB
          Colin P. McCabe
        3. HADOOP-10926.003.patch
          2 kB
          Colin P. McCabe
        4. HADOOP-10926.004.patch
          2 kB
          Colin P. McCabe

          Issue Links

            Activity

              People

              • Assignee:
                cmccabe Colin P. McCabe
                Reporter:
                andrew.wang Andrew Wang
              • Votes:
                0 Vote for this issue
                Watchers:
                16 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: