Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11596

Allow smart-apply-patch.sh to add new files in binary git patches

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      When a new file is added, the source is /dev/null (rather than the root of the tree (which would mean a a/b prefix)) Allow for this

      1. HADOOP-11596.01.patch
        0.5 kB
        Ravi Prakash
      2. HADOOP-11596.02.patch
        0.6 kB
        Ravi Prakash

        Issue Links

          Activity

          Hide
          raviprak Ravi Prakash added a comment -

          Here's a simple fix

          Show
          raviprak Ravi Prakash added a comment - Here's a simple fix
          Hide
          raviprak Ravi Prakash added a comment -

          Fixing comment too

          Show
          raviprak Ravi Prakash added a comment - Fixing comment too
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12698920/HADOOP-11596.02.patch
          against trunk revision ef950ea.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5700//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5700//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12698920/HADOOP-11596.02.patch against trunk revision ef950ea. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5700//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5700//console This message is automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, thanks Ravi Prakash.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, thanks Ravi Prakash .
          Hide
          raviprak Ravi Prakash added a comment -

          Thanks a lot Akira! I've pulled this into trunk.

          Show
          raviprak Ravi Prakash added a comment - Thanks a lot Akira! I've pulled this into trunk.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7133 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7133/)
          HADOOP-11596. Allow smart-apply-patch.sh to add new files in binary git patches (raviprak) (raviprak: rev 13d1ba9965236381e9014fce22120b999c36189a)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/smart-apply-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7133 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7133/ ) HADOOP-11596 . Allow smart-apply-patch.sh to add new files in binary git patches (raviprak) (raviprak: rev 13d1ba9965236381e9014fce22120b999c36189a) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/smart-apply-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7134 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7134/)
          HADOOP-11596 moving entry in CHANGES.TXT up to improvements there, as it wasn't in 2.7 & it was confusing diffs (stevel: rev 6be567094983057fa3532f301f7a37667eeae25a)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7134 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7134/ ) HADOOP-11596 moving entry in CHANGES.TXT up to improvements there, as it wasn't in 2.7 & it was confusing diffs (stevel: rev 6be567094983057fa3532f301f7a37667eeae25a) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #842 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/842/)
          HADOOP-11596. Allow smart-apply-patch.sh to add new files in binary git patches (raviprak) (raviprak: rev 13d1ba9965236381e9014fce22120b999c36189a)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/smart-apply-patch.sh
            HADOOP-11596 moving entry in CHANGES.TXT up to improvements there, as it wasn't in 2.7 & it was confusing diffs (stevel: rev 6be567094983057fa3532f301f7a37667eeae25a)
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #842 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/842/ ) HADOOP-11596 . Allow smart-apply-patch.sh to add new files in binary git patches (raviprak) (raviprak: rev 13d1ba9965236381e9014fce22120b999c36189a) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/smart-apply-patch.sh HADOOP-11596 moving entry in CHANGES.TXT up to improvements there, as it wasn't in 2.7 & it was confusing diffs (stevel: rev 6be567094983057fa3532f301f7a37667eeae25a) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #108 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/108/)
          HADOOP-11596. Allow smart-apply-patch.sh to add new files in binary git patches (raviprak) (raviprak: rev 13d1ba9965236381e9014fce22120b999c36189a)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/smart-apply-patch.sh
            HADOOP-11596 moving entry in CHANGES.TXT up to improvements there, as it wasn't in 2.7 & it was confusing diffs (stevel: rev 6be567094983057fa3532f301f7a37667eeae25a)
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #108 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/108/ ) HADOOP-11596 . Allow smart-apply-patch.sh to add new files in binary git patches (raviprak) (raviprak: rev 13d1ba9965236381e9014fce22120b999c36189a) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/smart-apply-patch.sh HADOOP-11596 moving entry in CHANGES.TXT up to improvements there, as it wasn't in 2.7 & it was confusing diffs (stevel: rev 6be567094983057fa3532f301f7a37667eeae25a) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #99 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/99/)
          HADOOP-11596. Allow smart-apply-patch.sh to add new files in binary git patches (raviprak) (raviprak: rev 13d1ba9965236381e9014fce22120b999c36189a)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/smart-apply-patch.sh
            HADOOP-11596 moving entry in CHANGES.TXT up to improvements there, as it wasn't in 2.7 & it was confusing diffs (stevel: rev 6be567094983057fa3532f301f7a37667eeae25a)
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #99 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/99/ ) HADOOP-11596 . Allow smart-apply-patch.sh to add new files in binary git patches (raviprak) (raviprak: rev 13d1ba9965236381e9014fce22120b999c36189a) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/smart-apply-patch.sh HADOOP-11596 moving entry in CHANGES.TXT up to improvements there, as it wasn't in 2.7 & it was confusing diffs (stevel: rev 6be567094983057fa3532f301f7a37667eeae25a) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2040 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2040/)
          HADOOP-11596. Allow smart-apply-patch.sh to add new files in binary git patches (raviprak) (raviprak: rev 13d1ba9965236381e9014fce22120b999c36189a)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/smart-apply-patch.sh
            HADOOP-11596 moving entry in CHANGES.TXT up to improvements there, as it wasn't in 2.7 & it was confusing diffs (stevel: rev 6be567094983057fa3532f301f7a37667eeae25a)
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2040 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2040/ ) HADOOP-11596 . Allow smart-apply-patch.sh to add new files in binary git patches (raviprak) (raviprak: rev 13d1ba9965236381e9014fce22120b999c36189a) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/smart-apply-patch.sh HADOOP-11596 moving entry in CHANGES.TXT up to improvements there, as it wasn't in 2.7 & it was confusing diffs (stevel: rev 6be567094983057fa3532f301f7a37667eeae25a) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #109 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/109/)
          HADOOP-11596. Allow smart-apply-patch.sh to add new files in binary git patches (raviprak) (raviprak: rev 13d1ba9965236381e9014fce22120b999c36189a)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/smart-apply-patch.sh
            HADOOP-11596 moving entry in CHANGES.TXT up to improvements there, as it wasn't in 2.7 & it was confusing diffs (stevel: rev 6be567094983057fa3532f301f7a37667eeae25a)
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #109 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/109/ ) HADOOP-11596 . Allow smart-apply-patch.sh to add new files in binary git patches (raviprak) (raviprak: rev 13d1ba9965236381e9014fce22120b999c36189a) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/smart-apply-patch.sh HADOOP-11596 moving entry in CHANGES.TXT up to improvements there, as it wasn't in 2.7 & it was confusing diffs (stevel: rev 6be567094983057fa3532f301f7a37667eeae25a) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2059 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2059/)
          HADOOP-11596. Allow smart-apply-patch.sh to add new files in binary git patches (raviprak) (raviprak: rev 13d1ba9965236381e9014fce22120b999c36189a)

          • dev-support/smart-apply-patch.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
            HADOOP-11596 moving entry in CHANGES.TXT up to improvements there, as it wasn't in 2.7 & it was confusing diffs (stevel: rev 6be567094983057fa3532f301f7a37667eeae25a)
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2059 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2059/ ) HADOOP-11596 . Allow smart-apply-patch.sh to add new files in binary git patches (raviprak) (raviprak: rev 13d1ba9965236381e9014fce22120b999c36189a) dev-support/smart-apply-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt HADOOP-11596 moving entry in CHANGES.TXT up to improvements there, as it wasn't in 2.7 & it was confusing diffs (stevel: rev 6be567094983057fa3532f301f7a37667eeae25a) hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              raviprak Ravi Prakash
              Reporter:
              raviprak Ravi Prakash
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development