Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-10387

Misspelling of threshold in log4j.properties for tests in hadoop-common-project

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: conf, test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      log4j.properties file for test contains misspelling "log4j.threshhold".
      We should use "log4j.threshold" correctly.

      1. HADOOP-10387.patch
        12 kB
        Kenji Kikushima
      2. HADOOP-10387-003.patch
        0.8 kB
        Brahma Reddy Battula
      3. HADOOP-10387-004.patch
        2 kB
        Brahma Reddy Battula
      4. HADOOP-10387-2.patch
        14 kB
        Kenji Kikushima

        Issue Links

          Activity

          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, I applied the patch locally and confirmed all of the misspellings 'threshhold' were fixed.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, I applied the patch locally and confirmed all of the misspellings 'threshhold' were fixed.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Hi Kenji Kikushima, now hadoop-azure and hadoop-nfs projects have typo 'threshhold', so would you please update the patch to fix them?

          Show
          ajisakaa Akira Ajisaka added a comment - Hi Kenji Kikushima , now hadoop-azure and hadoop-nfs projects have typo 'threshhold', so would you please update the patch to fix them?
          Hide
          kj-ki Kenji Kikushima added a comment -

          Attached an updated patch for hadoop-azure and hadoop-nfs.
          Thanks for reviewing and comments, Akira Ajisaka!

          Show
          kj-ki Kenji Kikushima added a comment - Attached an updated patch for hadoop-azure and hadoop-nfs. Thanks for reviewing and comments, Akira Ajisaka !
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1 (non-binding), pending Jenkins.

          Show
          ajisakaa Akira Ajisaka added a comment - +1 (non-binding), pending Jenkins.
          Hide
          aw Allen Wittenauer added a comment -

          This patch will never get tested by Jenkins as it touches way too many subsystems and gets killed before test-patch.sh completes. To move forward, it must get broken up into (minimally) each subproject.

          Show
          aw Allen Wittenauer added a comment - This patch will never get tested by Jenkins as it touches way too many subsystems and gets killed before test-patch.sh completes. To move forward, it must get broken up into (minimally) each subproject.
          Hide
          aw Allen Wittenauer added a comment -

          Cancelling patch to prevent test-patch.sh from triggering.

          Show
          aw Allen Wittenauer added a comment - Cancelling patch to prevent test-patch.sh from triggering.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Akira Ajisaka Attached patch for Hadoop common..Kindly Review..Thanks

          Show
          brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka Attached patch for Hadoop common..Kindly Review..Thanks
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Akira Ajisaka Same needs to be fixed in hadoop-azure and hadoop-aws ( did not file seperate jira for these two projects), thought of including HADOOP-11922 ,Please let me know your opinion..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka Same needs to be fixed in hadoop-azure and hadoop-aws ( did not file seperate jira for these two projects), thought of including HADOOP-11922 ,Please let me know your opinion..
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I'm thinking splitting into two patch is fine. HADOOP-10387 for hadoop-common-project (including hadoop-nfs) and HADOOP-11922 for hadoop-tools (including hadoop-azure and hadoop-aws).

          Show
          ajisakaa Akira Ajisaka added a comment - I'm thinking splitting into two patch is fine. HADOOP-10387 for hadoop-common-project (including hadoop-nfs) and HADOOP-11922 for hadoop-tools (including hadoop-azure and hadoop-aws).
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Ok.. I updated as per your comment..Kindly Review.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Ok.. I updated as per your comment..Kindly Review.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Brahma Reddy Battula for updating the patch. LGTM, +1 pending jenkins.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Brahma Reddy Battula for updating the patch. LGTM, +1 pending jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 5m 11s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 28s There were no new javac warning messages.
          +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
          +1 common tests 22m 39s Tests passed in hadoop-common.
              37m 49s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12731099/HADOOP-10387-003.patch
          Optional Tests javac unit
          git revision trunk / 449e442
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6515/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6515/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6515/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6515/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 11s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 28s There were no new javac warning messages. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 common tests 22m 39s Tests passed in hadoop-common.     37m 49s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731099/HADOOP-10387-003.patch Optional Tests javac unit git revision trunk / 449e442 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6515/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6515/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6515/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6515/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          -1 whitespace

          This patch does not include any trailing whitespaces. +1, committing this.

          Show
          ajisakaa Akira Ajisaka added a comment - -1 whitespace This patch does not include any trailing whitespaces. +1, committing this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Brahma Reddy Battula for contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Brahma Reddy Battula for contribution.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7756 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7756/)
          HADOOP-10387. Misspelling of threshold in log4j.properties for tests in hadoop-common-project. Contributed by Brahma Reddy Battula. (aajisaka: rev 305e4733d639830cb1801efaa2dba8e84b86cc29)

          • hadoop-common-project/hadoop-nfs/src/test/resources/log4j.properties
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/resources/log4j.properties
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7756 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7756/ ) HADOOP-10387 . Misspelling of threshold in log4j.properties for tests in hadoop-common-project. Contributed by Brahma Reddy Battula. (aajisaka: rev 305e4733d639830cb1801efaa2dba8e84b86cc29) hadoop-common-project/hadoop-nfs/src/test/resources/log4j.properties hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/resources/log4j.properties
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 5m 7s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 26s There were no new javac warning messages.
          +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
          +1 common tests 23m 26s Tests passed in hadoop-common.
          +1 common tests 0m 22s Tests passed in hadoop-nfs.
              38m 55s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12731112/HADOOP-10387-004.patch
          Optional Tests javac unit
          git revision trunk / 449e442
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6516/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-nfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6516/artifact/patchprocess/testrun_hadoop-nfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6516/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6516/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 7s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 26s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 common tests 23m 26s Tests passed in hadoop-common. +1 common tests 0m 22s Tests passed in hadoop-nfs.     38m 55s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731112/HADOOP-10387-004.patch Optional Tests javac unit git revision trunk / 449e442 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6516/artifact/patchprocess/testrun_hadoop-common.txt hadoop-nfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6516/artifact/patchprocess/testrun_hadoop-nfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6516/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6516/console This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #187 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/187/)
          HADOOP-10387. Misspelling of threshold in log4j.properties for tests in hadoop-common-project. Contributed by Brahma Reddy Battula. (aajisaka: rev 305e4733d639830cb1801efaa2dba8e84b86cc29)

          • hadoop-common-project/hadoop-nfs/src/test/resources/log4j.properties
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/resources/log4j.properties
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #187 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/187/ ) HADOOP-10387 . Misspelling of threshold in log4j.properties for tests in hadoop-common-project. Contributed by Brahma Reddy Battula. (aajisaka: rev 305e4733d639830cb1801efaa2dba8e84b86cc29) hadoop-common-project/hadoop-nfs/src/test/resources/log4j.properties hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/resources/log4j.properties
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #920 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/920/)
          HADOOP-10387. Misspelling of threshold in log4j.properties for tests in hadoop-common-project. Contributed by Brahma Reddy Battula. (aajisaka: rev 305e4733d639830cb1801efaa2dba8e84b86cc29)

          • hadoop-common-project/hadoop-nfs/src/test/resources/log4j.properties
          • hadoop-common-project/hadoop-common/src/test/resources/log4j.properties
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #920 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/920/ ) HADOOP-10387 . Misspelling of threshold in log4j.properties for tests in hadoop-common-project. Contributed by Brahma Reddy Battula. (aajisaka: rev 305e4733d639830cb1801efaa2dba8e84b86cc29) hadoop-common-project/hadoop-nfs/src/test/resources/log4j.properties hadoop-common-project/hadoop-common/src/test/resources/log4j.properties hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2118 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2118/)
          HADOOP-10387. Misspelling of threshold in log4j.properties for tests in hadoop-common-project. Contributed by Brahma Reddy Battula. (aajisaka: rev 305e4733d639830cb1801efaa2dba8e84b86cc29)

          • hadoop-common-project/hadoop-common/src/test/resources/log4j.properties
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-nfs/src/test/resources/log4j.properties
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2118 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2118/ ) HADOOP-10387 . Misspelling of threshold in log4j.properties for tests in hadoop-common-project. Contributed by Brahma Reddy Battula. (aajisaka: rev 305e4733d639830cb1801efaa2dba8e84b86cc29) hadoop-common-project/hadoop-common/src/test/resources/log4j.properties hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-nfs/src/test/resources/log4j.properties
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #177 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/177/)
          HADOOP-10387. Misspelling of threshold in log4j.properties for tests in hadoop-common-project. Contributed by Brahma Reddy Battula. (aajisaka: rev 305e4733d639830cb1801efaa2dba8e84b86cc29)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/resources/log4j.properties
          • hadoop-common-project/hadoop-nfs/src/test/resources/log4j.properties
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #177 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/177/ ) HADOOP-10387 . Misspelling of threshold in log4j.properties for tests in hadoop-common-project. Contributed by Brahma Reddy Battula. (aajisaka: rev 305e4733d639830cb1801efaa2dba8e84b86cc29) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/resources/log4j.properties hadoop-common-project/hadoop-nfs/src/test/resources/log4j.properties
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #187 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/187/)
          HADOOP-10387. Misspelling of threshold in log4j.properties for tests in hadoop-common-project. Contributed by Brahma Reddy Battula. (aajisaka: rev 305e4733d639830cb1801efaa2dba8e84b86cc29)

          • hadoop-common-project/hadoop-nfs/src/test/resources/log4j.properties
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/resources/log4j.properties
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #187 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/187/ ) HADOOP-10387 . Misspelling of threshold in log4j.properties for tests in hadoop-common-project. Contributed by Brahma Reddy Battula. (aajisaka: rev 305e4733d639830cb1801efaa2dba8e84b86cc29) hadoop-common-project/hadoop-nfs/src/test/resources/log4j.properties hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/resources/log4j.properties
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2136 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2136/)
          HADOOP-10387. Misspelling of threshold in log4j.properties for tests in hadoop-common-project. Contributed by Brahma Reddy Battula. (aajisaka: rev 305e4733d639830cb1801efaa2dba8e84b86cc29)

          • hadoop-common-project/hadoop-nfs/src/test/resources/log4j.properties
          • hadoop-common-project/hadoop-common/src/test/resources/log4j.properties
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2136 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2136/ ) HADOOP-10387 . Misspelling of threshold in log4j.properties for tests in hadoop-common-project. Contributed by Brahma Reddy Battula. (aajisaka: rev 305e4733d639830cb1801efaa2dba8e84b86cc29) hadoop-common-project/hadoop-nfs/src/test/resources/log4j.properties hadoop-common-project/hadoop-common/src/test/resources/log4j.properties hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              brahmareddy Brahma Reddy Battula
              Reporter:
              kj-ki Kenji Kikushima
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development